Bug 377310 - Single/double click option is inappropriately located in the mouse settings
Summary: Single/double click option is inappropriately located in the mouse settings
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_mouse (show other bugs)
Version: 5.9.2
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-06 21:13 UTC by Nate Graham
Modified: 2018-05-17 19:32 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-03-06 21:13:33 UTC
To make Dolphin files and folders open with double-clicks instead of single-clicks, you currently need to change a setting in systemsettings > Input Devices > Mouse > "Double-click to open files and folders ()select icons on first click)"

This is an inappropriate place for the setting, since it's not mouse-specific (I need to double-click with my laptop's touchpad, for example). It should be in Dolphin's settings, or somewhere else in systemsettings (Icons or Desktop Behavior seem more appropriate).
Comment 1 David Edmundson 2017-05-10 17:00:59 UTC
How is the mouse settings module an inappropriate place to configure your mouse settings.
Comment 2 Nate Graham 2017-05-10 17:55:46 UTC
Dolphin's single/double click folder behavior isn't a mouse setting. It's a folder behavior setting independent of what input device you use: I use a laptop and don't have a mouse.
Comment 3 Roman Gilg 2017-05-10 22:44:15 UTC
Well, it's a "pointer device" config option, so you're right that it's not the perfect place, but since we don't have a "pointer device KCM" it's still the best place because: It not only changes the behavior in Dolphin, but also in other areas. That's why it can't be in Dolphin settings. Icons or Desktop Berhavior is worse IMO.

What could be done is a single line of information in Dolphin settings, where to find this setting option. You could do it as a patch to Dolphin (it needs to consider that Dolphin is not only used on Plasma).
Comment 4 Nate Graham 2017-05-10 22:47:07 UTC
Where else does it change the behavior? The only other behavior it changes that I've found is in System Setting itself, which IMHO should *not* be affected by that setting (https://bugs.kde.org/show_bug.cgi?id=377309).

It seems like this behavior should be 100% Dolphin-specific, and then the setting should be in Dolphin's own settings.
Comment 5 Elvis Angelaccio 2017-05-11 07:57:31 UTC
(In reply to Nate Graham from comment #4)
> Where else does it change the behavior?

Ark, Gwenview, the Plasma file dialog, etc. It's not Dolphin-specific and that's the reason why it was moved from Dolphin to System Settings.
Comment 6 Nate Graham 2017-05-11 14:06:14 UTC
OK, I see what you mean. Still, this isn't a mouse setting, an input device setting, or a hardware setting ("Input Devices" is under "Hardware")--it's a program behavior setting. Perhaps "Desktop Behavior" might be a more appropriate place for it?
Comment 7 Michael 2018-05-08 18:20:55 UTC
Reading the blog about changing this, which I too think is a good idea [http://furkantokac.com/this-week-in-kde-part-1/], I was also thinking about the regular people who use KDE and will be intuitively looking for the single/double-click setting in the mouse or touchpad part of the KCM. If the option were to be moved out, I am sure they would feel confused and frustrated about not being able to make such a simple change. 

To add on to what has been proposed, I suggest a hyperlink in the old mouse/touchpad KCM's regarding single/double-click that takes them to the Workspace KCM. 

For example, this hyperlink might say, "Change single- and double-click settings  in Workspace".

The idea is to make things clear and helpful for the user.
Comment 8 Furkan Tokac 2018-05-17 19:32:52 UTC
Git commit d3ef895516fed319956e4ba843206dd118b998f5 by Furkan Tokac.
Committed on 17/05/2018 at 19:31.
Pushed by furkantokac into branch 'master'.

Single/Double Click Option at Workspace KCM

Summary:
This patch adds the single/double click option to
the Workspace KCM.
Related: bug 393547

Reviewers: romangg, ngraham, #plasma, mart

Reviewed By: romangg, #plasma, mart

Subscribers: mart, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12946

M  +3    -0    kcms/workspaceoptions/CMakeLists.txt
M  +33   -1    kcms/workspaceoptions/package/contents/ui/main.qml
M  +54   -3    kcms/workspaceoptions/workspaceoptions.cpp
M  +8    -0    kcms/workspaceoptions/workspaceoptions.h

https://commits.kde.org/plasma-desktop/d3ef895516fed319956e4ba843206dd118b998f5