Bug 393388 - Font vertical alignment problem in Global Menu
Summary: Font vertical alignment problem in Global Menu
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Global Menu (show other bugs)
Version: 5.12.4
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
: 393230 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-04-22 08:52 UTC by btstream
Modified: 2018-05-12 05:52 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (22.63 KB, image/png)
2018-04-22 08:52 UTC, btstream
Details
regular panel with global menu, 5.12.3 (203.74 KB, image/png)
2018-04-22 21:43 UTC, Dmitry
Details
regular panel with global menu, 5.12.4 (188.29 KB, image/png)
2018-04-22 21:44 UTC, Dmitry
Details
wrong alignment of menu, 5.12.4, archlinux (17.20 KB, image/png)
2018-04-25 13:28 UTC, Roman
Details
global menu vs title bar (20.25 KB, image/jpeg)
2018-05-10 13:24 UTC, PK
Details

Note You need to log in before you can comment on or make changes to this bug.
Description btstream 2018-04-22 08:52:29 UTC
Created attachment 112162 [details]
screenshot

After upgrading to 5.12.4, Global Menu in Latte Dock has a font align problem. My Latte Dock version is 0.7.4. 

I am pretty sure it is not distribution specified. I have one KDE neon user edition and one Archlinux, which have the same problem.

P.S 5.12.3 does not have this problem. And plasma's panel does not have this problem too (with both version 5.12.3 and 5.12.4).

Screenshot is attached. 

I am using Noto Sans for English, and Adobe Source Han CN for Chinese.
Comment 1 Michail Vourlakos 2018-04-22 20:42:25 UTC
sounds more Latte issue, but I cant replicate with master version
Comment 2 Dmitry 2018-04-22 21:43:32 UTC
Created attachment 112175 [details]
regular panel with global menu, 5.12.3
Comment 3 Dmitry 2018-04-22 21:44:12 UTC
Created attachment 112176 [details]
regular panel with global menu, 5.12.4
Comment 4 Dmitry 2018-04-22 21:49:45 UTC
(In reply to Michail Vourlakos from comment #1)
> sounds more Latte issue, but I cant replicate with master version

I found the way to reproduce this issue on Plasma 5.12.4 with regular plasma pannel (not latte).

There are a few steps with default layout:
1) Add 'Application Menu Bar' pannel
2) Add Digital Clock widget to the pannel
3) Add date to Digital Clock widget
4) Make this pannel so thin that both date and time will be on the one line

Also see this issue in openSUSE Tumbleweed
Comment 5 Roman 2018-04-23 08:56:38 UTC
In ArchLinux same with 5.12.4
Comment 6 Michail Vourlakos 2018-04-23 10:49:09 UTC
(In reply to Dmitry from comment #4)
> (In reply to Michail Vourlakos from comment #1)
> > sounds more Latte issue, but I cant replicate with master version
> 
> I found the way to reproduce this issue on Plasma 5.12.4 with regular plasma
> pannel (not latte).
> 
> There are a few steps with default layout:
> 1) Add 'Application Menu Bar' pannel
> 2) Add Digital Clock widget to the pannel
> 3) Add date to Digital Clock widget
> 4) Make this pannel so thin that both date and time will be on the one line
> 
> Also see this issue in openSUSE Tumbleweed

as long as you can replicate in plasma panel then this is plasma issue
Comment 7 Roman 2018-04-23 12:11:47 UTC
(In reply to Michail Vourlakos from comment #6)
> (In reply to Dmitry from comment #4)
> > (In reply to Michail Vourlakos from comment #1)
> > > sounds more Latte issue, but I cant replicate with master version
> > 
> > I found the way to reproduce this issue on Plasma 5.12.4 with regular plasma
> > pannel (not latte).
> > 
> > There are a few steps with default layout:
> > 1) Add 'Application Menu Bar' pannel
> > 2) Add Digital Clock widget to the pannel
> > 3) Add date to Digital Clock widget
> > 4) Make this pannel so thin that both date and time will be on the one line
> > 
> > Also see this issue in openSUSE Tumbleweed
> 
> as long as you can replicate in plasma panel then this is plasma issue

It doesn't matter whose problem it is for the end user. It is only important solution to the problem.
Comment 8 Michail Vourlakos 2018-04-23 12:19:30 UTC
> It doesn't matter whose problem it is for the end user. It is only important
> solution to the problem.

My concern was only about the issue to be reported in the correct place otherwise it will be lost and not be fixed
Comment 9 Roman 2018-04-25 13:28:52 UTC
Created attachment 112238 [details]
wrong alignment of menu, 5.12.4, archlinux
Comment 10 Kai Uwe Broulik 2018-04-25 14:02:09 UTC
I thought I fixed that.. :/ will have a look
Comment 11 Marian Arlt 2018-04-26 03:44:35 UTC
Can confirm this too on Arch 4.16.3 with Plasma 5.12.4
I tried to fiddle with the font settings and found that the global menu seems to take its font size only from the "General" font size setting. Maybe the font size adjustment calls depending on height got messed up?
Comment 12 Kai Uwe Broulik 2018-04-26 08:17:31 UTC
Try https://phabricator.kde.org/D12518
Comment 13 Kai Uwe Broulik 2018-04-26 15:20:14 UTC
Git commit c9e8e2e717f2b0aa71c2283ca60b111c1cdc3d8b by Kai Uwe Broulik.
Committed on 26/04/2018 at 15:04.
Pushed by broulik into branch 'master'.

[Button Styles] Fill height and vertical align

Otherwise the Text will never grow below its preferred height as the button grows smaller and will
eventually leak outside at the bottom rather than stay centered.

Differential Revision: https://phabricator.kde.org/D12518

M  +3    -1    src/declarativeimports/plasmastyle/ButtonStyle.qml
M  +3    -1    src/declarativeimports/plasmastyle/ToolButtonStyle.qml

https://commits.kde.org/plasma-framework/c9e8e2e717f2b0aa71c2283ca60b111c1cdc3d8b
Comment 14 Kai Uwe Broulik 2018-04-30 07:58:05 UTC
*** Bug 393230 has been marked as a duplicate of this bug. ***
Comment 15 PK 2018-05-10 13:24:13 UTC
Created attachment 112560 [details]
global menu vs title bar

Hai
I see the "Target Milestone" is "1.0" for this bug. It is not clear to me what this means. I received a lot of upgrades yesterday on my KDE Neon machine: "applications 18.04.1". 
I do not know if the bug should be officially resolved with this upgrade but I don't think it is. 
For me the most elegant situation would be if the items on the global menu were in one line with the title of the window as rendered in the title bar. To me that would be the best situation and that isn't yet achieved.
Comment 16 PK 2018-05-12 05:52:54 UTC
This morning I again got a lot of updates on my Neon User Edition box (frameworks 5.46). I am still testing but I think the global menu is placed exactly on the place where I would want it to be. It looks great!