Bug 393317 - Popup palette right click only partially disabled
Summary: Popup palette right click only partially disabled
Status: RESOLVED DUPLICATE of bug 402990
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: investigated, triaged
Depends on:
Blocks:
 
Reported: 2018-04-20 00:29 UTC by Storm Engineer
Modified: 2019-04-08 16:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Storm Engineer 2018-04-20 00:29:51 UTC
commit c7e6c0184f95 "Disable right-clicking on popup palette" is only partially working for me.

 - Right clicking on the painttop presets still selects them and closes palette
 - Right clicking on the recent colors ring closes palette without selecting

The rest ignores right click properly.

Arch Linux 64 bit + KDE 5
Master at 19f6e2ab340570 (not clean build)
Comment 1 Quiralta 2018-04-20 02:55:17 UTC
I can not reproduce in my build (clean) also on Arch/Plasma.

There is some "odd" behavior in the color wheel though, I can still pick the foreground color with the right click if I keep the button pressed for more than a second or drag slowly to pick.

Would expect to pick the background color as Dmitry mentioned on IRC. As for the selecting up presets, color (from the color history wheel) and automatic selection when close to edge of screen, for me all that is fixed.
Comment 2 Storm Engineer 2018-04-20 08:08:46 UTC
(In reply to Quiralta from comment #1)
> I can still pick the foreground color
Interestingly, I can not reproduce your issue.

Could be that it's some instability that causes different symptoms, or no symptoms, varying from system to system?

I'm going to try a clean build now.
Comment 3 Storm Engineer 2018-04-20 18:33:00 UTC
Clean build: same result
Comment 4 Quiralta 2018-04-21 00:28:05 UTC
That's odd, I still can not reproduce, I wonder if the type of tablet and or the input driver has anything to do with this too, for the sake of information I'm using the following:

Arch/Plasma
Huion 1060 tablet
libinput (and kernel provided support) no digimend driver
wacom driver/library to use the xsetwacom utility

Also applied the commit changes to my customized popup palette and shows same behavior as the original (all right click fixed except the background color picking).

Next link shows video where I'm using only right click till the close to the end where I change twice the presets to demonstrate that I can actually pick with left click.
Note: that I pick the green color holding right click down and dragging as mentioned earlier, I'm curious if you can reproduce this too.

https://drive.google.com/file/d/1E9B4ad22bBF1G2ttI5la8k46ZyWfUs5w/view?usp=sharing
Comment 5 Quiralta 2018-06-12 14:07:28 UTC
(In reply to Storm Engineer from comment #0)
> commit c7e6c0184f95 "Disable right-clicking on popup palette" is only
> partially working for me.
> 
>  - Right clicking on the painttop presets still selects them and closes
> palette
>  - Right clicking on the recent colors ring closes palette without selecting
> 
> The rest ignores right click properly.
> 
> Arch Linux 64 bit + KDE 5
> Master at 19f6e2ab340570 (not clean build)

Does still happening? I still can't reproduce these two mentioned issues. Also forgot to mention that by "clean build" I meant deleting/removing everything from the installation folder too (although you probably knew this already).
Comment 6 Storm Engineer 2018-06-13 15:05:02 UTC
Just built master and tested. Here is the current behavior on my end - note that my Wacom pen and actual mouse behave slightly different:

Mouse:
======
 - RMB and hold to open palette: holding is ignored, cursor not even present until releasing RMB.
 - RMB on open palette: Every element ignores click, palette closes.
VERDITC: I think mouse works perfectly now.

Wacom pen:
==========
 - "RMB" and hold to open palette: Cursor is visible but holding and releasing is ignored by all elements.
 - "RMB" on open palette: Color picker still reacting, though somewhat inconsistently: Sometimes the color is picked and sometimes it isn't, then the palette closes.
VERDICT: Picker still misbehaves, everything else seems consistent with mouse.


With the Wacom pen, accidental actions are mostly gone now, but since the switch is "shaky" in the buttons, they easily register as several clicks if not pressed firmly or released slowly, as such it's possible to open the palette, and end up with a random color selected and palette closed.
Comment 7 Quiralta 2018-06-14 16:47:05 UTC
(In reply to Storm Engineer from comment #6)
>...
>  - "RMB" on open palette: Color picker still reacting, though somewhat
> inconsistently: Sometimes the color is picked and sometimes it isn't, then
> the palette closes.
> VERDICT: Picker still misbehaves, everything else seems consistent with
> mouse...

I'm inclined to believe that that is the same symptom I'm sill have on it:
-single click (click-release) on open palette color triangle doesn't pick color but moves cursor and closes the palette.
-click, hold and drag will pick color, problem is that color is the foreground color not the background color as one would expect.

Would you mind checking if the same? I Would rather mark this report as confirmed (since has all the information) than making a new one, I just want to make sure we are experiencing the same issue.
Comment 8 Andrew Crouthamel 2018-10-02 22:09:00 UTC
Storm Engineer: Could you respond to Quiralta to proceed? Thanks!
Comment 9 Quiralta 2018-10-16 00:57:22 UTC
Just for the record, this is still present on the git master as of now(27bbf16) right click on stylus/tablet behaves the same as left click = moves cursor/picks foreground color.

Problem not present at all on mouse though.
Comment 10 Bug Janitor Service 2018-11-12 15:59:59 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Quiralta 2018-11-18 03:33:53 UTC
I'm going to go ahead and mark this as reported, I do still have the same behavior I reported on my part, and pretty sure is the same for Storm Engineer or anyone with similar system specs, also I haven't seen anything on Phabricator to indicate that this bug has been fixed or worked on (but I could be wrong), and I would hate to open another ticket for the same issue as it will just take away time from you guys to review again.

Please feel free to changed back to needs info (not sure what else we can provide or if it needs more triage) or close it if in case this has been resolved.

Note, I still use the master branch builds (almost daily build) on the same mentioned system.
Comment 12 Quiralta 2019-04-08 16:31:17 UTC

*** This bug has been marked as a duplicate of bug 402990 ***