Bug 393119 - No way to disable okularkirigami building
Summary: No way to disable okularkirigami building
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-13 22:43 UTC by Luca Beltrame
Modified: 2019-12-10 11:19 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/okular/1fb77446a7378368de5288ca9f57627ae2946d84
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Beltrame 2018-04-13 22:43:20 UTC 
The mobile version of Okular is built unconditionally, even on desktop systems. While its impact is arguably smaller, it would make sense to have a build switch (even default to ON) to enable/disable building.
Comment 1 Aleix Pol 2018-04-19 14:38:37 UTC 
https://phabricator.kde.org/D12352
Comment 2 Aleix Pol 2018-04-22 20:23:55 UTC 
Git commit 1fb77446a7378368de5288ca9f57627ae2946d84 by Aleix Pol.
Committed on 22/04/2018 at 20:23.
Pushed by apol into branch 'master'.

Make it possible to disable the build of okularkirigami

Summary:
Some distros seem to have the option.

Test Plan: Still builds, can disable build

Reviewers: #okular, mart, aacid, lbeltrame

Tags: #okular

Differential Revision: https://phabricator.kde.org/D12352

M  +4    -1    CMakeLists.txt
M  +28   -7    mobile/app/package/contents/ui/Documents.qml

https://commits.kde.org/okular/1fb77446a7378368de5288ca9f57627ae2946d84
Comment 3 RJVB 2019-12-10 11:19:06 UTC 
Wouldn't it make sense to use this switch to disable the build when using a Qt version that's not recent enough for all the required QML stuff?

cf. https://bugs.kde.org/show_bug.cgi?id=415012