Created attachment 124422 [details] backtrace SUMMARY Okular claims it supports Qt 5.9 yet okularkirigami seems to require at least Qt 5.10 . After addressing this I observed the attached crash. This is with the git/master head. STEPS TO REPRODUCE 1. Apply the QML patches from the attached patch file 2. rebuild and run okularkirigami 3. click the unlabeled lower-right control to open the page selector 4. click it again OBSERVED RESULT Crash EXPECTED RESULT I suppose the page selector should close again. SOFTWARE/OS VERSIONS KDE Frameworks Version: 5.60.0 Qt Version: 5.9.8 ADDITIONAL INFORMATION The PageItem::paint() method may never be called with a null window() when using a newer Qt version but given that other member functions check the property it may be wise to do so here. Idem for the change to DocumentPrivate::requestDone() (though one may wonder why a null observer would be held in m_observers).
Created attachment 124423 [details] patch to make things work
René, you know you don't send patches in bugzilla.
So sue me ... or remove the possibility to attach them.
We did, by explicitly removing the text that recommends submitting patches in the attachments view, and we replaced it with text saying: > KDE uses Phabricator for patch submissions. Please read our instructions on > how to submit a patch through Phabricator. Bugzilla is not monitored for > patches, so your patch is likely to be missed." Maybe you missed that? Either way, please submit using Phabricator.
No, neither did I miss the fact there are no guarantees. This is an issue tracker, used among others for reporting what could be bugs that need triaging. I consider it a courtesy to attach a patch if I have one, for something that's not important enough to me to request a patch review process (or because I don't want to allocate the time necessary to do the project devs' work for them the way they want it to be done). Feel free to ignore the patch, feel free even to ignore the whole ticket, I'm planning to cut the pointless gadget out of my okular packaging anyway.
Guys, don't fight. The patch is now at https://invent.kde.org/kde/okular/merge_requests/80.