Bug 392538 - Dockers empty
Summary: Dockers empty
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: 4.0
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-30 18:42 UTC by joao.oliveira.pombo
Modified: 2018-04-03 11:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
The broken dockers (12.81 KB, image/png)
2018-03-30 18:42 UTC, joao.oliveira.pombo
Details
Dockers on the same space (21.07 KB, image/png)
2018-03-30 18:42 UTC, joao.oliveira.pombo
Details
Krita page (152.12 KB, image/png)
2018-03-30 18:43 UTC, joao.oliveira.pombo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description joao.oliveira.pombo 2018-03-30 18:42:04 UTC
Created attachment 111739 [details]
The broken dockers

The layer and brush preset dockers are unusable and in a minimized state, every docker that shares the same space is unresizable and keeps the size of these two.
Both dockers lack any options and reinstaling krita from scratch did not fix the issue
Comment 1 joao.oliveira.pombo 2018-03-30 18:42:52 UTC
Created attachment 111740 [details]
Dockers on the same space
Comment 2 joao.oliveira.pombo 2018-03-30 18:43:25 UTC
Created attachment 111741 [details]
Krita page
Comment 3 Halla Rempt 2018-03-30 18:48:28 UTC
Sorry Joao, 

This is not a bug report. Just select a default workspace, or uncollapse the dockers. You don't need to reinstall from scratch, in fact, that will never help at all. Please consult the FAQ about how to reset the configuration or the manual on how to select a predefined workspace.
Comment 4 joao.oliveira.pombo 2018-03-30 19:38:00 UTC
(In reply to Boudewijn Rempt from comment #3)
> Sorry Joao, 
> 
> This is not a bug report. Just select a default workspace, or uncollapse the
> dockers. You don't need to reinstall from scratch, in fact, that will never
> help at all. Please consult the FAQ about how to reset the configuration or
> the manual on how to select a predefined workspace.

Changing the workspace doesn't help, this happens with all workspaces that use these dockers, it's also not a matter of uncollapsing the dockers, they aren't collapsed, the window simply doesn't have any options.
Comment 5 Halla Rempt 2018-03-31 11:06:48 UTC
Git commit b662043a20633d3bc52f9b178171a26ef9be532e by Boudewijn Rempt.
Committed on 31/03/2018 at 11:06.
Pushed by rempt into branch 'master'.

Remove the lock, collapse and hide option for dock titlebars

On asking around, it seems that even Krita power users were not
using these options. New users to Krita seemed unable to grasp this
functionality altogether. And we were always having trouble managing
the locked and collapsed state of dockers.

Note that not having a custom titlebar widget also makes it impossible
to keep having an option to remove the titlebars altogether, which was
another way to force the dockers to stay in one place.

A side-effect is that on macOS, floating dockers are resizable now.
Related: bug 385238
CCMAIL:kimageshop@kde.org

M  +0    -1    krita/krita4.xmlgui
M  +1    -13   krita/kritamenu.action
M  +1    -58   libs/ui/KisMainWindow.cpp
M  +0    -5    libs/ui/KisMainWindow.h
M  +0    -5    libs/ui/KisViewManager.cpp
M  +0    -10   libs/ui/kis_config.cc
M  +0    -3    libs/ui/kis_config.h
M  +0    -1    libs/ui/widgets/kis_workspace_chooser.cpp
M  +0    -2    libs/widgets/CMakeLists.txt
D  +0    -379  libs/widgets/KoDockWidgetTitleBar.cpp
D  +0    -67   libs/widgets/KoDockWidgetTitleBar.h
D  +0    -114  libs/widgets/KoDockWidgetTitleBarButton.cpp
D  +0    -55   libs/widgets/KoDockWidgetTitleBarButton.h
D  +0    -72   libs/widgets/KoDockWidgetTitleBar_p.h
M  +0    -5    libs/widgets/KoToolBoxDocker.cpp
M  +0    -3    libs/widgets/KoToolDocker.cpp
M  +0    -12   libs/widgets/kritawidgets.qrc
D  +-    --    libs/widgets/pics/dark_docker_close.png
D  +-    --    libs/widgets/pics/dark_docker_collapse_a.png
D  +-    --    libs/widgets/pics/dark_docker_collapse_b.png
D  +-    --    libs/widgets/pics/dark_docker_float.png
D  +-    --    libs/widgets/pics/dark_docker_lock_a.png
D  +-    --    libs/widgets/pics/dark_docker_lock_b.png
D  +-    --    libs/widgets/pics/light_docker_close.png
D  +-    --    libs/widgets/pics/light_docker_collapse_a.png
D  +-    --    libs/widgets/pics/light_docker_collapse_b.png
D  +-    --    libs/widgets/pics/light_docker_float.png
D  +-    --    libs/widgets/pics/light_docker_lock_a.png
D  +-    --    libs/widgets/pics/light_docker_lock_b.png

https://commits.kde.org/krita/b662043a20633d3bc52f9b178171a26ef9be532e
Comment 6 Halla Rempt 2018-04-03 11:47:32 UTC
Git commit 1cb9d7fd80ce61b003c311a879e31e4f9d2675f0 by Boudewijn Rempt.
Committed on 03/04/2018 at 11:20.
Pushed by rempt into branch 'krita/4.0'.

Remove the lock, collapse and hide option for dock titlebars

On asking around, it seems that even Krita power users were not
using these options. New users to Krita seemed unable to grasp this
functionality altogether. And we were always having trouble managing
the locked and collapsed state of dockers.

Note that not having a custom titlebar widget also makes it impossible
to keep having an option to remove the titlebars altogether, which was
another way to force the dockers to stay in one place.

A side-effect is that on macOS, floating dockers are resizable now.
Related: bug 385238
CCMAIL:kimageshop@kde.org
(cherry picked from commit b662043a20633d3bc52f9b178171a26ef9be532e)

M  +0    -1    krita/krita4.xmlgui
M  +1    -13   krita/kritamenu.action
M  +1    -58   libs/ui/KisMainWindow.cpp
M  +0    -5    libs/ui/KisMainWindow.h
M  +0    -5    libs/ui/KisViewManager.cpp
M  +0    -10   libs/ui/kis_config.cc
M  +0    -3    libs/ui/kis_config.h
M  +0    -1    libs/ui/widgets/kis_workspace_chooser.cpp
M  +0    -2    libs/widgets/CMakeLists.txt
D  +0    -379  libs/widgets/KoDockWidgetTitleBar.cpp
D  +0    -67   libs/widgets/KoDockWidgetTitleBar.h
D  +0    -114  libs/widgets/KoDockWidgetTitleBarButton.cpp
D  +0    -55   libs/widgets/KoDockWidgetTitleBarButton.h
D  +0    -72   libs/widgets/KoDockWidgetTitleBar_p.h
M  +0    -5    libs/widgets/KoToolBoxDocker.cpp
M  +0    -3    libs/widgets/KoToolDocker.cpp
M  +0    -12   libs/widgets/kritawidgets.qrc
D  +-    --    libs/widgets/pics/dark_docker_close.png
D  +-    --    libs/widgets/pics/dark_docker_collapse_a.png
D  +-    --    libs/widgets/pics/dark_docker_collapse_b.png
D  +-    --    libs/widgets/pics/dark_docker_float.png
D  +-    --    libs/widgets/pics/dark_docker_lock_a.png
D  +-    --    libs/widgets/pics/dark_docker_lock_b.png
D  +-    --    libs/widgets/pics/light_docker_close.png
D  +-    --    libs/widgets/pics/light_docker_collapse_a.png
D  +-    --    libs/widgets/pics/light_docker_collapse_b.png
D  +-    --    libs/widgets/pics/light_docker_float.png
D  +-    --    libs/widgets/pics/light_docker_lock_a.png
D  +-    --    libs/widgets/pics/light_docker_lock_b.png

https://commits.kde.org/krita/1cb9d7fd80ce61b003c311a879e31e4f9d2675f0