Bug 385238 - Floating dockers not resizable on OS X
Summary: Floating dockers not resizable on OS X
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: 4.0 pre-alpha
Platform: Other macOS
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-30 15:57 UTC by Bernhard Liebl
Modified: 2018-04-03 11:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Liebl 2017-09-30 15:57:55 UTC
On OS X (and maybe certain Linux window managers), floating docker windows are not properly resizable (the margin for resizing them seems to be 1 pixel wide and the resize cursor is not working properly). This is a QT bug related to custom titles, reported now as https://bugreports.qt.io/browse/QTBUG-63526.
Comment 1 Halla Rempt 2017-09-30 16:36:43 UTC
Hm, that's kind of interesting -- we could, perhaps, disable the custom titlebar on OSX, but I'm not sure we can do anything about the actual issue...
Comment 2 Bernhard Liebl 2017-09-30 16:57:28 UTC
Yes, disabling the custom titlebar is the only fix in Krita, I looked at the QT code and there's no way to fix it from the outside. I'll look into titlebar disabling on OS X a bit more, it would need to only happen if palettes are floating. I also hope the QT guys take the report seriously, it's a small but highly annoying issue.
Comment 3 Halla Rempt 2017-11-23 10:20:21 UTC
I think that the chances for the Qt guys working on this bug are remote... It's marked as P3, so we'll need a workaround where all custom titlebar items are removed if the docker is floating.
Comment 4 Halla Rempt 2018-03-31 11:06:48 UTC
Git commit b662043a20633d3bc52f9b178171a26ef9be532e by Boudewijn Rempt.
Committed on 31/03/2018 at 11:06.
Pushed by rempt into branch 'master'.

Remove the lock, collapse and hide option for dock titlebars

On asking around, it seems that even Krita power users were not
using these options. New users to Krita seemed unable to grasp this
functionality altogether. And we were always having trouble managing
the locked and collapsed state of dockers.

Note that not having a custom titlebar widget also makes it impossible
to keep having an option to remove the titlebars altogether, which was
another way to force the dockers to stay in one place.

A side-effect is that on macOS, floating dockers are resizable now.
Related: bug 392538
CCMAIL:kimageshop@kde.org

M  +0    -1    krita/krita4.xmlgui
M  +1    -13   krita/kritamenu.action
M  +1    -58   libs/ui/KisMainWindow.cpp
M  +0    -5    libs/ui/KisMainWindow.h
M  +0    -5    libs/ui/KisViewManager.cpp
M  +0    -10   libs/ui/kis_config.cc
M  +0    -3    libs/ui/kis_config.h
M  +0    -1    libs/ui/widgets/kis_workspace_chooser.cpp
M  +0    -2    libs/widgets/CMakeLists.txt
D  +0    -379  libs/widgets/KoDockWidgetTitleBar.cpp
D  +0    -67   libs/widgets/KoDockWidgetTitleBar.h
D  +0    -114  libs/widgets/KoDockWidgetTitleBarButton.cpp
D  +0    -55   libs/widgets/KoDockWidgetTitleBarButton.h
D  +0    -72   libs/widgets/KoDockWidgetTitleBar_p.h
M  +0    -5    libs/widgets/KoToolBoxDocker.cpp
M  +0    -3    libs/widgets/KoToolDocker.cpp
M  +0    -12   libs/widgets/kritawidgets.qrc
D  +-    --    libs/widgets/pics/dark_docker_close.png
D  +-    --    libs/widgets/pics/dark_docker_collapse_a.png
D  +-    --    libs/widgets/pics/dark_docker_collapse_b.png
D  +-    --    libs/widgets/pics/dark_docker_float.png
D  +-    --    libs/widgets/pics/dark_docker_lock_a.png
D  +-    --    libs/widgets/pics/dark_docker_lock_b.png
D  +-    --    libs/widgets/pics/light_docker_close.png
D  +-    --    libs/widgets/pics/light_docker_collapse_a.png
D  +-    --    libs/widgets/pics/light_docker_collapse_b.png
D  +-    --    libs/widgets/pics/light_docker_float.png
D  +-    --    libs/widgets/pics/light_docker_lock_a.png
D  +-    --    libs/widgets/pics/light_docker_lock_b.png

https://commits.kde.org/krita/b662043a20633d3bc52f9b178171a26ef9be532e
Comment 5 Halla Rempt 2018-04-03 11:46:09 UTC
Git commit 1cb9d7fd80ce61b003c311a879e31e4f9d2675f0 by Boudewijn Rempt.
Committed on 03/04/2018 at 11:20.
Pushed by rempt into branch 'krita/4.0'.

Remove the lock, collapse and hide option for dock titlebars

On asking around, it seems that even Krita power users were not
using these options. New users to Krita seemed unable to grasp this
functionality altogether. And we were always having trouble managing
the locked and collapsed state of dockers.

Note that not having a custom titlebar widget also makes it impossible
to keep having an option to remove the titlebars altogether, which was
another way to force the dockers to stay in one place.

A side-effect is that on macOS, floating dockers are resizable now.
Related: bug 392538
CCMAIL:kimageshop@kde.org
(cherry picked from commit b662043a20633d3bc52f9b178171a26ef9be532e)

M  +0    -1    krita/krita4.xmlgui
M  +1    -13   krita/kritamenu.action
M  +1    -58   libs/ui/KisMainWindow.cpp
M  +0    -5    libs/ui/KisMainWindow.h
M  +0    -5    libs/ui/KisViewManager.cpp
M  +0    -10   libs/ui/kis_config.cc
M  +0    -3    libs/ui/kis_config.h
M  +0    -1    libs/ui/widgets/kis_workspace_chooser.cpp
M  +0    -2    libs/widgets/CMakeLists.txt
D  +0    -379  libs/widgets/KoDockWidgetTitleBar.cpp
D  +0    -67   libs/widgets/KoDockWidgetTitleBar.h
D  +0    -114  libs/widgets/KoDockWidgetTitleBarButton.cpp
D  +0    -55   libs/widgets/KoDockWidgetTitleBarButton.h
D  +0    -72   libs/widgets/KoDockWidgetTitleBar_p.h
M  +0    -5    libs/widgets/KoToolBoxDocker.cpp
M  +0    -3    libs/widgets/KoToolDocker.cpp
M  +0    -12   libs/widgets/kritawidgets.qrc
D  +-    --    libs/widgets/pics/dark_docker_close.png
D  +-    --    libs/widgets/pics/dark_docker_collapse_a.png
D  +-    --    libs/widgets/pics/dark_docker_collapse_b.png
D  +-    --    libs/widgets/pics/dark_docker_float.png
D  +-    --    libs/widgets/pics/dark_docker_lock_a.png
D  +-    --    libs/widgets/pics/dark_docker_lock_b.png
D  +-    --    libs/widgets/pics/light_docker_close.png
D  +-    --    libs/widgets/pics/light_docker_collapse_a.png
D  +-    --    libs/widgets/pics/light_docker_collapse_b.png
D  +-    --    libs/widgets/pics/light_docker_float.png
D  +-    --    libs/widgets/pics/light_docker_lock_a.png
D  +-    --    libs/widgets/pics/light_docker_lock_b.png

https://commits.kde.org/krita/1cb9d7fd80ce61b003c311a879e31e4f9d2675f0