Bug 391798 - Improve UX for Text Editor
Summary: Improve UX for Text Editor
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Text (show other bugs)
Version: 4.0 pre-alpha
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 463865 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-03-13 06:00 UTC by Tyson Tan
Modified: 2023-01-11 21:08 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2018-03-13 06:00:15 UTC
In krita-4.1.0-pre-alpha-a41aeb7-x86_64:
When a text object is active (with dashed outline), it cannot be edited by double clicking on it. It required triple clicking on it, or by pressing the Keyboard's Enter key. This is very confusing. Compound with https://bugs.kde.org/show_bug.cgi?id=391795 , first time text tool users will never figure things out.
Comment 1 mvowada 2018-03-13 08:54:36 UTC
I can confirm it requires triple double-clicking in "Krita 4.1.0-pre-alpha (git d0e6714)" appimage - Ubuntu 14.04 Unity.
Comment 2 Scott Petrovic 2018-03-25 17:16:51 UTC
You have to press "Enter" right now to activate the text editor. We know that the UX isn't good with the text editor in 4.0 and we need to revise it.
Comment 3 Scott Petrovic 2018-03-25 17:18:01 UTC
I am changing this as an improvement to improve the UX for the text editor
Comment 4 Tyson Tan 2018-03-26 01:24:03 UTC
In that case, I have one more suggestion:

Considering there maybe technical limitations that make editing on canvas like GIMP difficult to implement in Krita, the following may improve the quality-of-life for text editing greatly:

1) Automatically update the text on canvas realtime instead of requiring the user pressing the Apply button. This will deliver a semi-responsive UI experience.

2) Add two more buttons to text editor's toolbar: "font size +", "font size -". They make fine-tunning the font size much more intuitive, and thus helps to improve the sense of UI responsiveness.

3) If we implemented (1), then we should change the bottom buttons to "OK" and "Cancel", and their icons to "☑" and "☒" respectively. In this way the UI feel more familiar to normal users.

4) Add a button to change input box background color, to work against the text and background blending together.

5) Before the "100%" widget, insert a text string "Line-height" or a related icon to aid first time user learning the function.

6) Add tool tip baloons for every button and widget so that user can learn their usage.
Comment 5 Tyson Tan 2018-03-29 03:49:44 UTC
One more suggestion:

If possible, add a color picker to the text tool's toolbar. It's much easier and more intuitive to just sample color directly from the canvas than managing a palette first.
Comment 6 Gin 2019-05-24 19:30:46 UTC
I see that 4.2.0 beta fixed some bugs and added colour picker to text editor toolbar, good job!
But now text editor background is fixed white, that makes hard to work with white and light-coloured fonts. So I support Tyson Tan's suggestion #4 to add BG colour picker directly on the editor toolbar. #1 and #2 are also highly wanted.

(There is now setting -> colours -> editor background in menu, but it doesn't seem to affect anything, even after Krita restart)
Comment 7 vanyossi 2019-05-24 21:32:43 UTC
Double clicking is fixed now

1) Directly from the textEditor is very posible, let me test adding the events in the proper places
2) Buttons for + / - will change font size, instead of changing zoom. is that correct?
3) Ok
4) Change the bg solid color of the textbox just for previewing purposes?
5) At least we hae the Tooltip working again ;)
6) That's Done already :D

4 Needs discussion and 5 needs the icons, the ones available are not suitable.
Comment 8 Gin 2019-05-25 00:48:02 UTC
>> 2) Buttons for + / - will change font size, instead of changing zoom. is that correct?

What buttons, I don't see any now (4.2.0b)?
Problem is that font size only have preset fonts, if I want custom one (I often use 100+) I have to type it in each time. It would be convenient to have buttons for fine-tuning or mouse scroll changing value freely, instead of cycling through presets.

>> 4) Change the bg solid color of the textbox just for previewing purposes?

Previewing? If I have white text I can't even see it until I select it or save it. I don't think it's that uncommon to have white or light fonts in image editor. In 4.1 textarea was dark grey, which was probably better choice than white in 4.2. There is probably no pressing need for free RGB colour selection, toggle between dark\light BG could be just enough. It could be even better if text editing would happen directly on canvas and not in separate window, but since it's implemented this way it's quite important feature, imho.

>> 1) Directly from the textEditor is very posible, let me test adding the events in the proper places

Cool
Comment 9 Halla Rempt 2019-05-25 09:53:44 UTC
Maybe we should change the color of the background depending on the color of the text... Or make an option for it.
Comment 10 Gin 2019-05-26 21:38:21 UTC
But text could be multicoloured, each letter own colour even. But may worth considering.
Comment 11 Scott Petrovic 2019-05-28 17:28:23 UTC
I think having the ability to change the background color for the editor is the only solution. I think we could just default it to one color, then have an option in the editor if people want to change it. I guess this could be saved in the kritarc file?
Comment 12 Halla Rempt 2019-05-28 17:30:23 UTC
Yes, that's possible. I was actually looking into capturing the projection under the text shape and put that as background image in the editor, though. But that's much more complicated.
Comment 13 Tiar 2021-05-18 23:37:08 UTC
All wishes mentioned in this report:
[ ] means it's not implemented yet; [X] means it's fixed or implemented already.

A) [X] double clicking (Ivan says it's fixed now) - from comment0
1) [ ] Update text in real time - from comment4 - this one probably needs discussion (mostly technical)
2) [ ] font size +, font size - buttons
3) [ ] (after (1)) change [Apply] to [OK]/[Cancel] pair
4) [X] add a button to change the background color (it's implemented in Settings of the text editor - maybe not easy to access, but it's there)
5) [ ] add "Line-height" before "100%" numeric box
6) [X] add tool tips for everything - the only one that's missing the tooltip is the color picker button, but it's more understandable from the context and the icon is familiar.
B) [X] add a color picker - from comment5 - it's located next to the text color chooser.
Comment 14 Tyson Tan 2021-05-19 02:06:49 UTC
The current text editor, while not ideal (not WYSIWYG), is functional and not a pain to use anymore. The Font-style (reported as another bug?) not working is still a huge issue though. 

I think:

1) Adding a button on the toolbar to change editor background color

2) Adding a shortcut,like [Ctrl+S] to allow quick save in that dialogue. Then put a text inform people about it before the Save button.

Can greatly improve the usability for what we have, without a lot of work.
Comment 15 wolthera 2023-01-11 21:08:39 UTC
*** Bug 463865 has been marked as a duplicate of this bug. ***