Bug 390928 - GlobalDrawer used as an always-visible sidebar rather than for its intended purpose
Summary: GlobalDrawer used as an always-visible sidebar rather than for its intended p...
Status: RESOLVED NOT A BUG
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.12.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-22 22:28 UTC by Nate Graham
Modified: 2018-03-04 11:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-22 22:28:01 UTC
From reading the docs and talking to Kirigami developers, it seems like we're abusing GlobalDrawer. It was intended to only be visible on mobile, as a kind of vertical menubar that you could call up at any time (on the desktop, a regular horizontal menubar would be displayed instead). Instead, we're using it on the desktop as an always-visible sidebar, which doesn't seem right, and causes bugs based on implementation details (see Bug 390927).

We should consider using a more appropriate UI element that's designed to be an always-visible sidebar.
Comment 1 Aleix Pol 2018-03-02 15:37:28 UTC
I don't see it as a problem at the moment and it's proved useful to maintain the mobile version.

If it becomes a big problem, let's solve it.
Comment 2 Nate Graham 2018-03-02 20:48:29 UTC
One downside is that it's not resizable and our implementation somehow breaks its ability to auto-resize based on content width. Previously, people complained that it was too wide. Since I shortened it, people are happy about that, but I keep waiting for Dr Chapatin to file a bug report that it's now too narrow to accommodate long Brazilian Portuguese strings. :) (e.g. see Bug 385109)

If it were resizable, either manually or automatically, both issues would be resolved. As is, we have to choose which one we can live with.
Comment 3 Patrick Silva 2018-03-04 11:32:01 UTC
(In reply to Nate Graham from comment #2)
> I keep waiting for Dr Chapatin to file a bug report that
> it's now too narrow to accommodate long Brazilian Portuguese strings. :)
> (e.g. see Bug 385109)
lol
yesterday I was thinking about reporting this issue.
Now I can see it's not necessary.