Bug 390927 - GlobalDrawer's minimum width is 360 pixels on the desktop
Summary: GlobalDrawer's minimum width is 360 pixels on the desktop
Status: RESOLVED NOT A BUG
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-22 22:19 UTC by Nate Graham
Modified: 2018-02-23 01:18 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-22 22:19:35 UTC 
In src/controls/GlobalDrawer.qml#n215, the width of the GlobalDrawer is set to Math.min (Units.gridUnit * 20, root.parent.width * 0.8)

Units.gridUnit * 20 works out to 260 pixels on the desktop. That's really wide for a minimum width. Why not just use the content width?

Because Discover uses the GlobalDrawer as an always-visible sidebar, it's comically wide and generates user complaints. See Bug 385992.
Comment 1 Nate Graham 2018-02-23 01:18:17 UTC 
Not needed, and I was misreading the code anyway (confused min() and max() ). This width is probably fine when it's used for its intended purpose.