Bug 390809 - Remove "Remember last used Save mode" checkbox in Configure window
Summary: Remove "Remember last used Save mode" checkbox in Configure window
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords: junior-jobs
Depends on:
Blocks: 390793
  Show dependency treegraph
 
Reported: 2018-02-20 20:27 UTC by Nate Graham
Modified: 2018-02-22 21:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2018-02-20 20:27:29 UTC
This UI control is a relic from a prior version of spectacle when the "Save" split button's menu was full of items. Now, it only has two, and this setting is checked by default. The use case for turning it off is pretty difficult to envision now. Therefore, in the interest of de-cluttering, let's remove it.
Comment 1 Andrew Crouthamel 2018-02-21 15:05:36 UTC
https://phabricator.kde.org/D10718
Comment 2 Nate Graham 2018-02-22 17:08:32 UTC
Git commit d8c78b2934110e7e705e7cbba21945dcddd28f5f by Nathaniel Graham, on behalf of Roman Inflianskas.
Committed on 22/02/2018 at 17:08.
Pushed by ngraham into branch 'master'.

Remove "Remember last used Save mode" checkbox

Summary:
Per Nate Graham: "This UI control is a relic from a prior version of spectacle when the "Save" split button's menu was full of items. Now, it only has two, and this setting is checked by default. The use case for turning it off is pretty difficult to envision now. Therefore, in the interest of de-cluttering, let's remove it."

Before:
{F5723847}

After:
{F5723849}

Test Plan:
# Select `Save` button.
# Close Spectacle.
# Open Spectacle.
# `Save` is active.
# Select `Save As`.
# Close Spectacle.
# Open Spectacle.
# `Save As` is active.

Reviewers: rkflx, ngraham, #spectacle

Reviewed By: rkflx, ngraham, #spectacle

Subscribers: acrouthamel, ngraham, rkflx

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D10711

M  +1    -7    doc/index.docbook
M  +2    -8    src/Gui/KSMainWindow.cpp
M  +0    -4    src/Gui/KSMainWindow.h
M  +0    -9    src/Gui/SettingsDialog/GeneralOptionsPage.cpp
M  +0    -1    src/Gui/SettingsDialog/GeneralOptionsPage.h
M  +0    -13   src/SpectacleConfig.cpp
M  +0    -3    src/SpectacleConfig.h

https://commits.kde.org/spectacle/d8c78b2934110e7e705e7cbba21945dcddd28f5f