Bug 390793 - "General" settings page has save-related options that should be on the "Save" page
Summary: "General" settings page has save-related options that should be on the "Save"...
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords: junior-jobs
Depends on: 390809
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-20 16:25 UTC by Eike Hein
Modified: 2018-09-04 02:14 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 18.12.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2018-02-20 16:25:42 UTC
There's two checkboxes at the top of the "General" settings page in the config dialog that relate to saving behavior, when there's already a dedicated "Save" page for those.
Comment 1 null 2018-02-20 19:51:18 UTC
Thanks Eike, you make a good point, and this is one of the usability issues which is still open.

"Remember last used Save mode":
Do we actually need this? As we removed "Save & Exit", there are only two options left anyway, and recently we changed the default to "checked". Also, I cannot think of any similar radiobutton-type UI element having a separate config for making it stick or not.

"Copy save location to the clipboard":
In https://bugs.kde.org/show_bug.cgi?id=390415#c5 we are wondering whether to make this more about "copy to clipboard" and less about "save location".
Comment 2 Nate Graham 2018-02-20 19:56:07 UTC
I would be in favor of removing the "Remember last used Save mode" checkbox, as it was mostly useful when the menu was full of items. With only two items and being checked by default... not so much.
Comment 3 null 2018-02-20 19:58:43 UTC
> removing the "Remember last used Save mode" checkbox
This part would make for a great junior job (should someone ask).
Comment 4 Nate Graham 2018-02-20 20:28:18 UTC
I've split that task out into Bug 390809.
Comment 5 utecht 2018-08-28 13:45:20 UTC
I've posted a patch to address this bug: https://phabricator.kde.org/D14812
Comment 6 Nate Graham 2018-09-03 22:31:06 UTC
Git commit 85a0436e7e71f78066ce890fdf1370c202735f56 by Nathaniel Graham.
Committed on 03/09/2018 at 22:30.
Pushed by ngraham into branch 'master'.

Move 'copy file location after saving' to Save Options page

Summary:
Removed check box for 'copy file location after saving' from General options page and added back to Save options page. Also renamed group box to 'Save Location' and renamed label for default save location to 'Default Save Location' to make the group box title more applicable to the 'copy file location after saving' setting.
FIXED-IN: 18.12.0

Before:
{F6191546}

After:
{F6191548}

Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D14812

M  +0    -8    src/Gui/SettingsDialog/GeneralOptionsPage.cpp
M  +0    -1    src/Gui/SettingsDialog/GeneralOptionsPage.h
M  +10   -2    src/Gui/SettingsDialog/SaveOptionsPage.cpp
M  +4    -1    src/Gui/SettingsDialog/SaveOptionsPage.h

https://commits.kde.org/spectacle/85a0436e7e71f78066ce890fdf1370c202735f56
Comment 7 Nate Graham 2018-09-04 02:14:52 UTC
Git commit dd493d262d9f2e51a3d57e00388f0ec13e12656f by Nate Graham, on behalf of Kyle Utecht.
Committed on 04/09/2018 at 02:14.
Pushed by ngraham into branch 'master'.

Move 'copy file location after saving' to Save Options page

Summary:
Removed check box for 'copy file location after saving' from General options page and added back to Save options page. Also renamed group box to 'Save Location' and renamed label for default save location to 'Default Save Location' to make the group box title more applicable to the 'copy file location after saving' setting.
FIXED-IN: 18.12.0

Before:
{F6191546}

After:
{F6191548}

Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D14812

M  +0    -8    src/Gui/SettingsDialog/GeneralOptionsPage.cpp
M  +0    -1    src/Gui/SettingsDialog/GeneralOptionsPage.h
M  +10   -2    src/Gui/SettingsDialog/SaveOptionsPage.cpp
M  +4    -1    src/Gui/SettingsDialog/SaveOptionsPage.h

https://commits.kde.org/spectacle/dd493d262d9f2e51a3d57e00388f0ec13e12656f