Bug 390322 - Discover shows updates notification while flatpaks are updated
Summary: Discover shows updates notification while flatpaks are updated
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (interactive) (show other bugs)
Version: 5.13.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-12 15:01 UTC by Patrick Silva
Modified: 2018-09-24 06:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.12.7
Sentry Crash Report:


Attachments
screenshot (76.16 KB, image/png)
2018-02-12 15:01 UTC, Patrick Silva
Details
Discover 5.12.2 on Arch Linux (90.85 KB, image/png)
2018-02-23 14:35 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2018-02-12 15:01:37 UTC
Created attachment 110562 [details]
screenshot

See screenshot taken on Arch Linux.
Comment 1 Aleix Pol 2018-02-12 17:46:26 UTC
Git commit 670bdaef73042facc66b9aaf6fd39697ede8167b by Aleix Pol.
Committed on 12/02/2018 at 17:45.
Pushed by apol into branch 'Plasma/5.12'.

Don't notify when the number of updates becomes smaller

M  +3    -3    notifier/DiscoverNotifier.cpp

https://commits.kde.org/discover/670bdaef73042facc66b9aaf6fd39697ede8167b
Comment 2 Patrick Silva 2018-02-23 14:35:49 UTC
Created attachment 110940 [details]
Discover 5.12.2 on Arch Linux

just happened again on Arch Linux.
Comment 3 Kai Uwe Broulik 2018-09-24 06:35:27 UTC
Git commit 8b2cf5d81a6133445e0bf838a7f6996391c5be8f by Kai Uwe Broulik.
Committed on 24/09/2018 at 06:34.
Pushed by broulik into branch 'Plasma/5.12'.

Fix showing update notification

It would check whether the old count was greater than or equal to the new count which is the wrong way round and as such the notification was never shown.
Related: bug 396426
FIXED-IN: 5.12.7

Differential Revision: https://phabricator.kde.org/D15682

M  +1    -1    notifier/DiscoverNotifier.cpp

https://commits.kde.org/discover/8b2cf5d81a6133445e0bf838a7f6996391c5be8f