Bug 389483 - VLC leaks playing video details to lock screen
Summary: VLC leaks playing video details to lock screen
Status: RESOLVED FIXED
Alias: None
Product: kscreenlocker
Classification: Plasma
Component: breeze-theme (show other bugs)
Version: unspecified
Platform: Kubuntu Linux
: NOR critical
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-26 22:25 UTC by Tom Chiverton
Modified: 2020-10-24 17:05 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
No lock screen L&F options except wallpaper (257.09 KB, image/png)
2018-04-03 07:01 UTC, onitake
Details
System settings version dialogue (33.74 KB, image/png)
2018-04-03 07:01 UTC, onitake
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Chiverton 2018-01-26 22:25:13 UTC
By default, the lock screen displays the currently playing media on VLC. 

This leaks details of media being played to anyone.

Can't see where to flag this as security issue.
Comment 1 Martin Flöser 2018-01-27 08:37:26 UTC
To my knowledge Plasma 5.12 will introduce a config option.
Comment 2 Tom Chiverton 2018-02-10 15:49:43 UTC
I have plasma-desktop 4:5.12.0-0neon+16.04+xenial+build80 on KDE Neon.

No such option has appeared in workspace->screenlocking under either tab
Comment 3 Rog131 2018-02-13 10:13:27 UTC
By the Plasma 5.12.0 release announcement : https://www.kde.org/announcements/plasma-5.12.0.php has:

"Media controls have been added to the lock screen. For added privacy, they can be disabled in Plasma 5.12..."

There is bug report: Bug 384264 - Make it possible to disable media controls on lock screen - https://bugs.kde.org/show_bug.cgi?id=384264 .

It is marked as fixed with the https://cgit.kde.org/kscreenlocker.git/commit/?id=e36101cd1b4857a23e05b9d1f039e9358bd1f49b

BUT the 'config.qml' is not shown by the lock screen configuration with the plasma 5.12.0. Tested with the Neon and with the Arch.

A workaround is to manually edit the /usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/config.xml . Change the '<default>true</default>' to '<default>false</default>'
Comment 4 David Edmundson 2018-02-13 11:17:37 UTC
Urgh, there's a bug.

If the "Appareance" tab is not the active tab on load, then it doesn't render the second QtQuick UI
Comment 5 Tom Chiverton 2018-02-13 20:58:00 UTC
Are you going to rate this more seriously then ? 

Not only is KDE insecure by default now, but it's not possible to change the settings to make it more secure!

I'm thinking you want to issue an out-of-band update ASAP...
Comment 6 David Edmundson 2018-02-13 21:18:50 UTC
The impliciation was that I would fix it.
Comment 7 David Edmundson 2018-02-13 22:52:22 UTC
Git commit 639d1809e4d3605903e0efe379f104e35a03fc38 by David Edmundson.
Committed on 13/02/2018 at 22:29.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Update size hint of lnf config widget

The old code implicitly used the initial size, which depending on when source is set, was often 0

M  +2    -2    kcm/kcm.ui
M  +3    -0    kcm/lnfconfig.qml

https://commits.kde.org/kscreenlocker/639d1809e4d3605903e0efe379f104e35a03fc38
Comment 8 Christoph Feck 2018-02-14 19:19:49 UTC
Thanks Sam for your continues bug triaging efforts. I have just raised your bugzilla privileges to edit any aspects of bugs (mark duplicates, etc.)
Comment 9 Tom Chiverton 2018-02-15 18:48:13 UTC
So is this just getting lumped into the next monthly patch set ?
Comment 10 Rog131 2018-02-15 19:21:32 UTC
(In reply to Tom Chiverton from comment #9)
> So is this just getting lumped into the next monthly patch set ?

It is fixed in branch 'Plasma/5.12'. Next, 5.12.2 , is planned: Tue 2018-02-20. 
Plasma Schedules:  https://community.kde.org/Schedules/Plasma_5 .

...and yes it is working: [img]https://i.imgur.com/vpLWRoF.png[/img]
Comment 11 David Edmundson 2018-02-15 20:19:04 UTC
>So is this just getting lumped into the next monthly patch set ?

Yes.
Comment 12 onitake 2018-04-02 20:37:06 UTC
I just updated to Plasma 5.12.3 from the Debian testing repository and I don't see the new UI in the lock screen settings.

Is there something different about the Debian Plasma packages?
Comment 13 Rog131 2018-04-03 06:30:17 UTC
(In reply to onitake from comment #12)
> I just updated to Plasma 5.12.3 from the Debian testing repository and I
> don't see the new UI in the lock screen settings.
> 
> Is there something different about the Debian Plasma packages?

What do you see ?
Could you add a link to the screen capture ?
Comment 14 onitake 2018-04-03 07:01:31 UTC
Created attachment 111794 [details]
No lock screen L&F options except wallpaper
Comment 15 onitake 2018-04-03 07:01:58 UTC
Created attachment 111795 [details]
System settings version dialogue
Comment 16 onitake 2018-04-03 07:02:46 UTC
Here you go - see the attachments
Comment 17 Rog131 2018-04-03 18:54:54 UTC
(In reply to onitake from comment #12)
> I just updated to Plasma 5.12.3 from the Debian testing repository and I
> don't see the new UI in the lock screen settings.
> 
> Is there something different about the Debian Plasma packages?

A quick test with the Debian, Ubuntu and the Neon:

Debian - not working: https://imgur.com/oluO1Tu
Ubuntu - not working: https://imgur.com/tu1q2iL
Neon - working: https://imgur.com/57EgU2d

Also working, at here, with the Arch Linux.

It seems that the Debian is not executing the /usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/config.qml

Tested with the:

Breaking the config.qml - You should get an error message: https://imgur.com/fHTtQ2c

With the Debian: No error messages.

and adding the config.qml line: Component.onCompleted: console.log("Executing this !!")

When executing command: kcmshell5 screenlocker

There should be output: qml: Executing this !!

An image: https://imgur.com/0Td6xBB

With the Debian: No output.


This seems to be an Debian/Ubuntu problem. Maybe a bug repot in the Debian/Ubuntu bug tracking system will help.
Comment 18 onitake 2018-04-04 13:24:55 UTC
Thank you very much for debugging this.
I'll open a bug report on the Debian BTS.
Comment 19 Tom Chiverton 2018-04-05 18:40:00 UTC
What's the Debian / Ubuntu bug ID ?
Comment 20 Rog131 2018-04-05 20:35:30 UTC
(In reply to Tom Chiverton from comment #19)
> What's the Debian / Ubuntu bug ID ?

The Debian seems to have : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894815
Comment 21 onitake 2018-04-05 20:39:16 UTC
Yes, exactly.
That's the bug I created yesterday.
Comment 22 Fonic 2020-10-24 17:05:23 UTC
This bug is marked as RESOLVED FIXED, but was this actually ever fixed?

Comment #17 suggests that the patch mentioned in comment #7 failed to do the trick for a number of distributions, and the Debian bug (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894815) does not seem to come to any conclusion.

I'm currently experiencing this bug on Gentoo Linux (amd64, stable) with Plasma 5.19.5 and I'm wondering wether this is a regression or the same bug that just never got fixed.

Operating System: Gentoo Linux
KDE Plasma Version: 5.19.5
KDE Frameworks Version: 5.74.0
Qt Version: 5.15.1
Kernel Version: 5.4.72-gentoo
OS Type: 64-bit