Basically implement this: https://github.com/KDE/plasma-workspace/blob/master/lookandfeel/contents/lockscreen/LockScreenUi.qml#L183
I'm against adding more options to the lock screen. As this is completely controlled by the Look'n'Feel package it's not possible for the lock screen to expose the options as it doesn't know what the current look'n'feel package provides. This would be highly confusing to users. Given that I prefer that such customization is moved outside the core feature set we provide. This should be provided in a specialized look and feel package provided by users on store.kde.org. We just cannot take on the maintenance burden for every customization a user wants.
(In reply to Martin Flöser from comment #1) > I'm against adding more options to the lock screen. As this is completely > controlled by the Look'n'Feel package it's not possible for the lock screen > to expose the options as it doesn't know what the current look'n'feel > package provides. This would be highly confusing to users. > > Given that I prefer that such customization is moved outside the core > feature set we provide. This should be provided in a specialized look and > feel package provided by users on store.kde.org. We just cannot take on the > maintenance burden for every customization a user wants. I think the OP didn't mean to add more options on the "lock screen" screen according to the comments on a post related to this topic. Maybe the title is a little implicit. When the media-controller-on-lock-screen feature was introduced, it has an option for disabling this feature in the qml (mentioned in comment #1). But this option is not exposed to user, so we cannot set it to be disabled unless we change the qml directly as root. Exposing this option to the setting/configuration for users is what we ask for.
Sorry, I mean comment #0 for the qml file. And, to keep it simple, I do not want the media controller to appear on the lock screen so that the lock screen can be the same as before the feature is introduced.
In general, the reason I want to disable these controls is of privacy: when you leave your computer locked, curious people could just come to your desk and browse through your songs with the previous/next buttons. To achieve the desired results, I think we can look at different levels. 1) Adding a setting on the screen locker level From my understand this doesn't fit the architecture, because a look and feel package is able to provide a free range of controls. The screen locker cannot guess what other kind of crazy controls a look and feel implementor would come up with. So this is clearly not a good solution. 2) Adding a setting on the look and feel level I'm not sure whether look and feel plugins are able to provide their own configuration pages and settings. If yes, then the setting could be added in the look and feel config page. Now I understand that adding one there might be an additional maintenance burden as it requires extra testing to make sure the enabling/disabling works correctly. 3) Implementing a separate look and feel that does not contain any media controls (or provides the setting from 2)) From what I understand, people can publish their own look and feel plugins on https://store.kde.org So one alternative would be to clone the base look and feel and modify it (assuming the license permits, but I guess it does). The drawback here is that you need to regularily check if the original version has changed and pull the changes into the clone. Does QML support any kind of overlay ? If a look and feel was able to extend another one, then this extra version could simply modify that one. 3b) Modify the distro's custom look and feel For example openSUSE provides its own look and feel which also has the media buttons. Similar to 3) and 2), but the maintenance burden would then be on said distro look and feel maintainers. Also it doesn't have the benefit that it would apply to all possible distros out there. 4) Disabling the general media control engine I've noticed that many apps seem to be able to register themselves into some kind of media control engine/backend (not sure what it is called, data service?). This is likely the same engine into which the media buttons from the system tray are connecting to. Maybe there's a way to uninstall or disable this media engine and prevent any kind of media control buttons to appear anywhere, even on the systray (I personally don't use these). If not possible, then add a setting on this level. Might be a bit too advanced for regular users though. 5) Preventing your favorite media player to advertise itself to the media control engine This would require modifying the source code of said media player, or having a switch in the media player itself (ex: Amarok) to tell it to not connect to the media engine. This feels a bit too far fetched and patching source code is a no-go. 6) Automatically close the media player / clear playlist when screen is locked Likely too hacky and far-fetched. Any other ideas ? So far it seems that having an own look and feel might be the best.
Setting back to WONTFIX for now, sorry (not sure how this slipped)
(In reply to Vincent Petry from comment #5) > Setting back to WONTFIX for now, sorry (not sure how this slipped) As per Martin Flöser said, maybe this should be a "look'n'feel" issue instead of setting in "kscreenlocker". Do you know how to make this bug report targeting at what "look'n'feel" component?
Seems a bit odd to be marked as wont fix when its commented as TODO in the code
How can this be set to resolved? I used the screen lock in xfce to prevent people from messing with the music that is playing. This must be customizable in the options or is pointless altogether. but atleast it looks like my android phone now. Shall I open a new ticket now?
Please see comment #1 which clearly shows how to do it. There are now so many people commenting here, it's trivial to setup a look and feel package which has this feature disabled and put it on store.kde.org. The strength here is that we as in KDE don't need to provide every possible option users want, but can allow users to share their personal preferences through store.kde.org.
my bad, changing the theme got indeed rid of it. im sorry. works fine as it is.
*** Bug 387868 has been marked as a duplicate of this bug. ***
(In reply to Vincent Petry from comment #4) > Any other ideas ? > So far it seems that having an own look and feel might be the best. Yup! why not simply dropping this 'feature' ? What is the rationale and use case behind adding media controls to the lock screen in the first place ? This media controls on the lock screen has been giving me headaches as for some reason it unpause the media when computer goes into suspend and blasts sound full volume when going out of suspend. So basically I pause some music or other media, go AFK for a bit so KDE locks itself then goes into suspend, I grab the laptop and move somewhere else and when I want to use the laptop again it becomes a huge annoyance and possible liability. What if it was porn that was paused and got blaring when I want to use the laptop again. This media control thing is a big no-no for me.
(In reply to Martin Flöser from comment #9) > Please see comment #1 which clearly shows how to do it. There are now so > many people commenting here, it's trivial to setup a look and feel package > which has this feature disabled and put it on store.kde.org. > The strength here is that we as in KDE don't need to provide every possible > option users want, but can allow users to share their personal preferences > through store.kde.org. This is not a strength but a severe weakness, as you know most users do not change default settings or even look further than what is provided in system settings. I've been using linux every day as my main OS for over 15 years and KDE as my main DE for 12 years and I did not even know store.kde.org existed. I just went to have a look and I have no clue what this is about or how to use it. I clicked the first look and feel theme and the first comment is asking how to install it[1]. It seems obvious store.kde.org is not ready for prime time yet, let alone a practical way to solve the problem raised in this bug report. How would anyone confronted with the need to remove media player controls from their lock screen find out that they have to go to store.kde.org and figure out how to use it and hopefully find that some nice user had shared the exact theme they're using with the media controls disabled ? Is this really the official solution behind the "RESOLVED" "WONTFIX" status of this bug ? you gotta be kidding me. The phabricator task[2] clearly states that part of the plan in adding media controls to lock screen includes: What's to be done: Allow to disable this for privacy reasons When you go to edit the LockScreenUi.qml to turn it off it is clearly marked as having to be configurable: active: true // TODO configurable Is there a package that can be removed to remove this functionality altogether as can be done with the baloo nonsense, or a way to stop it from running entirely as can be done with akonadi ? [1]: https://store.kde.org/p/1192970/ [2]: https://phabricator.kde.org/D3684
(In reply to Martin Flöser from comment #9) > Please see comment #1 which clearly shows how to do it. There are now so > many people commenting here, it's trivial to setup a look and feel package > which has this feature disabled and put it on store.kde.org. Sorry forgot to answer that part. Following your suggestion, I went to this website and failed to find any such look and feel packages pointing to not being so trivial. There's only 15 of them and only one reaches a 70% score. As there's none despite the problem being real, I though maybe I could share the existing theme I use with the active setting turned to false. But I have no clue how to use store.kde.org and apparently there's no documentation either. I'm curious to know how many people actually use this site. As it is much faster to simply edit the config file to set the media controls to off as seems to be the popular solution, I'll stick to that until someone publishes a sane theme without media controls. Asking around it seems knowledeable people either edit the config file or use their own theme to get rid of this. PS: I'm not sure adding an impossible to turn off privacy issue in the current times is a smart move.
Git commit e36101cd1b4857a23e05b9d1f039e9358bd1f49b by David Edmundson. Committed on 08/01/2018 at 13:13. Pushed by davidedmundson into branch 'master'. Load config specified by the LnF theme Summary: This is loaded in a QQuickView like the wallpaper, rest of the code is mostly based on something quite similar. Only differences is that wallpapers packages can change during the config, whereas the base package cannot; which simplifies some code. Test Plan: Started playing some tunes Locked screen, still had my controls Changed setting Locked screen, didn't have my controls Changed wallpaper to confirm I hadn't broken anything Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D9684 M +1 -0 greeter/CMakeLists.txt M +11 -1 greeter/greeterapp.cpp M +3 -0 greeter/greeterapp.h A +74 -0 greeter/lnf_integration.cpp [License: GPL] A +83 -0 greeter/lnf_integration.h [License: GPL] M +1 -0 kcm/CMakeLists.txt M +43 -2 kcm/kcm.cpp M +10 -0 kcm/kcm.h M +28 -9 kcm/kcm.ui C +6 -7 kcm/lnfconfig.qml [from: kcm/config.qml - 085% similarity] M +2 -1 kcm/resources.qrc R +0 -0 kcm/wallpaperconfig.qml [from: kcm/config.qml - 100% similarity] https://commits.kde.org/kscreenlocker/e36101cd1b4857a23e05b9d1f039e9358bd1f49b
Not fixed; see #389483 Seems no one tested actually opening the "screen locking" settings to see if the box appeared :(
Not fixed for me. on Kubuntu 17.10 with backports. changing /etc/sddm.conf to "breeze-text-only" which i downloaded from the builtin store .bad ratings but still the most reasonable choice which itself is frustrating. unfortunately none of the login screens are getting rid of the media controls. its bad user experience.
(In reply to knet from comment #17) > Not fixed for me. on Kubuntu 17.10 with backports. > changing /etc/sddm.conf to "breeze-text-only" which i downloaded from the > builtin store .bad ratings but still the most reasonable choice which itself > is frustrating. unfortunately none of the login screens are getting rid of > the media controls. its bad user experience. This bug report is about Plasma lock screen media controls, not SDDM login greeter. If you have problems with the Breeze SDDM login greeter, please open a new bug report. Marking this as fixed (worksforme). Working at here with the Plasma 5.12.2.
Any privacy breaking setting should be off by default. The "setting" mentioned in comment #15 is not visible on openSUSE Leap 15 (plasma 5.12.6) After reading https://phabricator.kde.org/D9684, Workspace>Desktop Behavior>Screen locking seemed the place to look at. Is it elsewhere ?
(In reply to ederag from comment #19) > Any privacy breaking setting should be off by default. > > The "setting" mentioned in comment #15 > is not visible on openSUSE Leap 15 (plasma 5.12.6) > After reading https://phabricator.kde.org/D9684, > Workspace>Desktop Behavior>Screen locking > seemed the place to look at. > Is it elsewhere ? It's in the 'Appearance' tab of the 'Screen locking' settings.
> It's in the 'Appearance' tab of the 'Screen locking' settings. Definitely not there on my system described in comment #19. Only "Wallpaper type" and "Positioning". What's your system ?
(In reply to ederag from comment #21) > > It's in the 'Appearance' tab of the 'Screen locking' settings. > > Definitely not there on my system described in comment #19. > Only "Wallpaper type" and "Positioning". > What's your system ? I have a checkbox titled 'show media controls' on top of 'wallpaper type'. I'm using Plasma 5.16.5 on Arch Linux.
(In reply to Kishore Gopalakrishnan from comment #22) > I have a checkbox titled 'show media controls' on top of 'wallpaper type'. > I'm using Plasma 5.16.5 on Arch Linux. Thanks, despite v5.12.6 being in the commit tags https://phabricator.kde.org/source/kscreenlocker/tags/master/;e36101cd1b4857a23e05b9d1f039e9358bd1f49b, the checkbox is not there in v5.12.6. Thank you for the information, time to upgrade.