Bug 388942 - Scrollable pop-ups can scroll vertically past content
Summary: Scrollable pop-ups can scroll vertically past content
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: Not decided
Assignee: Aleix Pol
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2018-01-14 05:35 UTC by Andres Betts
Modified: 2018-02-13 16:35 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: KDE Frameworks 5.44


Attachments
Screenshot (112.95 KB, image/png)
2018-01-14 05:35 UTC, Andres Betts
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Betts 2018-01-14 05:35:44 UTC
Created attachment 109852 [details]
Screenshot

The review screen needs to stop at the bottom of its size and not go past all the way up.
Comment 1 Nate Graham 2018-01-17 19:38:28 UTC
+1, this drives me crazy. I keep accidentally closing the pop-up when I scroll down to see more reviews.
Comment 2 Nate Graham 2018-01-29 17:40:28 UTC
Sadly this appears to be per Kirigami's design: https://cgit.kde.org/kirigami.git/tree/src/controls/OverlaySheet.qml#n27

I happen to think that this offers a sub-standard user experience, especially on the desktop. If you agree, you might consider filing a bug against Kirigami (https://bugs.kde.org/enter_bug.cgi?product=frameworks-kirigami). Our options here are to fix it in Kirigami and close this bug, or use this bug to track using a different UI element to display reviews in Discover (I would be strongly in favor of that).
Comment 3 Nate Graham 2018-02-13 16:35:26 UTC
author	Marco Martin <notmart@gmail.com>
committer	Marco Martin <notmart@gmail.com>
commit	a532f673f1b64aa61eb77d26ee0f5c886dec3e58 (patch)
tree	c0b645bf80c98edb6c8ac722471c8d1b870d2be1
parent	68a2ceb60e805fcdef10669f2415c6a3084898cf (diff)
not possible to close the sheet with mousewheelHEADmaster
Diffstat
-rw-r--r--	src/controls/templates/OverlaySheet.qml	59	
		
1 files changed, 23 insertions, 36 deletions
diff --git a/src/controls/templates/OverlaySheet.qml b/src/controls/templates/OverlaySheet.qml
index e63fb6e..9bacd32 100644
--- a/src/controls/templates/OverlaySheet.qml
+++ b/src/controls/templates/OverlaySheet.qml
@@ -96,11 +96,11 @@ QtObject {