Bug 387815 - Popups lack close button
Summary: Popups lack close button
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.41.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords: usability
: 389975 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-12-12 01:47 UTC by Nate Graham
Modified: 2018-02-15 02:27 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Getting there... (238.71 KB, image/png)
2018-02-13 19:57 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-12-12 01:47:32 UTC
When you click on a screenshot, it opens in a pop-up that lacks any visible means of closing it. It should have a close button in the corner or something.
Comment 1 Aleix Pol 2017-12-12 12:49:53 UTC
It's what we do on every overlay TBH, they are to be closed by clicking outside. I don't think it's all that weird.
Comment 2 Nate Graham 2017-12-12 14:16:05 UTC
I managed to figure it out too, but there wouldn't have been anything to figure out in the first place if there was a close button. :)

Also, in cases where the pop-up takes up most of the screen (this is possible with Discover), the click area outside of the pop-up may be rather small.
Comment 3 Nate Graham 2018-02-06 22:13:06 UTC
*** Bug 389975 has been marked as a duplicate of this bug. ***
Comment 4 Nate Graham 2018-02-06 22:13:50 UTC
It's true that you can always click outside the pop-up, but this has been and will continue to be a source of user confusion and bug reports. We just got our first from a user of Discover on 5.12: https://bugs.kde.org/show_bug.cgi?id=389975

What is obvious to developers is not always obvious to users. Please consider adding close buttons to pop-ups.
Comment 5 Marco Martin 2018-02-13 17:03:31 UTC
Git commit fb31f9013b3901ebd40e6bd1343152967911c1c6 by Marco Martin.
Committed on 13/02/2018 at 17:00.
Pushed by mart into branch 'master'.

show a close button on desktop

M  +16   -0    src/controls/templates/OverlaySheet.qml

https://commits.kde.org/kirigami/fb31f9013b3901ebd40e6bd1343152967911c1c6
Comment 6 Aleix Pol 2018-02-13 17:25:26 UTC
In Discover we are using QQC2.Popup now for screenshots...
Comment 7 Nate Graham 2018-02-13 17:27:02 UTC
Sounds like we'll need to apply a similar patch for Discover, or else re-adopt the Kirigami pop-up.
Comment 8 Nate Graham 2018-02-13 19:57:58 UTC
Created attachment 110627 [details]
Getting there...

Getting there! We now have a close button and it works. However, it has some visual and usability issues:
- It doesn't scroll with scrollable content and just stays where it is, which feels weird
- It floats above the darkened area rather than seeming like a part of the pop-up itself
- It doesn't change its visual appearance when hovered or clicked the way most widgets do
Comment 9 Nate Graham 2018-02-15 02:27:28 UTC
With the latest commits, we can call this done.