Bug 388072 - window dragged to top of the screen is not maximized under Wayland
Summary: window dragged to top of the screen is not maximized under Wayland
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: core (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL: https://phabricator.kde.org/D10156
Keywords:
: 389183 390365 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-12-20 13:52 UTC by Patrick Silva
Modified: 2018-02-13 15:59 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/kwin/aefa11f11a251d1270da08a73b367088baec0d56
Version Fixed In: 5.12.1
mgraesslin: Wayland+
mgraesslin: X11-
mgraesslin: ReviewRequest+

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-12-20 13:52:35 UTC 
neon dev unstble here, reproducible when I use a touchpad. I did not test a usb mouse.

open dolphin and unmaximize it
use your touchpad to drag the window to top of the screen
maximize animation can be noticed but the window is not maximized
Comment 1 Martin Flöser 2017-12-20 15:47:41 UTC 
works fine for me
Comment 2 Patrick Silva 2017-12-20 22:18:01 UTC 
Hi Martin. New steos...

open dolphin and unmaximize it
resize the window dragging some border
drag the window to top of the screen
Comment 3 Patrick Silva 2018-01-17 01:35:58 UTC 
This bug is even worst in plasma 5.12 beta, Arch Linux.
I can reproduce it on my desktop using an usb mouse. Resize the window dragging a border is not necessary.
Just open okular or gwenview and drag it to top of the screen... the window is not maximized.
Comment 4 Martin Flöser 2018-01-17 16:04:40 UTC 
You are right. I'm surprised now. That used to work...
Comment 5 Martin Flöser 2018-01-19 05:15:45 UTC 
*** Bug 389183 has been marked as a duplicate of this bug. ***
Comment 6 Martin Flöser 2018-01-21 10:14:29 UTC 
Git commit 0d2a34172357c016f74f5374e6db1785e7739f11 by Martin Flöser.
Committed on 21/01/2018 at 10:13.
Pushed by graesslin into branch 'Plasma/5.12'.

[autotests/integration] Add test for broken quick tiling for xdg_shell

See also D9980.

M  +1    -0    autotests/integration/kwin_wayland_test.h
M  +66   -0    autotests/integration/quick_tiling_test.cpp

https://commits.kde.org/kwin/0d2a34172357c016f74f5374e6db1785e7739f11
Comment 7 Martin Flöser 2018-01-28 09:37:59 UTC 
patch at https://phabricator.kde.org/D10156
Comment 8 Martin Flöser 2018-02-04 14:00:34 UTC 
Git commit aefa11f11a251d1270da08a73b367088baec0d56 by Martin Flöser.
Committed on 04/02/2018 at 13:59.
Pushed by graesslin into branch 'Plasma/5.12'.

Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked

Summary:
We send out too many configure requests when finishing move resize which
also triggers quick tiling. This change addresses the problem of the too
many configure requests by making the configure method check whether
geometry updates are blocked. And to make this work properly for the end
of finish move resize the complete method is wrapped in a geometry
update blocker.
FIXED-IN: 5.12.1

Test Plan:
Quick tiling test passes, both Wayland and X11 windows are
quick tiled correctly.

Reviewers: #kwin, #plasma, jgrulich

Subscribers: plasma-devel, kwin

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10156

M  +1    -3    autotests/integration/quick_tiling_test.cpp
M  +1    -0    geometry.cpp
M  +3    -0    shell_client.cpp
M  +2    -0    shell_client.h

https://commits.kde.org/kwin/aefa11f11a251d1270da08a73b367088baec0d56
Comment 9 Martin Flöser 2018-02-13 15:59:32 UTC 
*** Bug 390365 has been marked as a duplicate of this bug. ***