Bug 387851 - New tabs should have better title
Summary: New tabs should have better title
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 18.04.2
Platform: Archlinux Linux
: NOR minor
Target Milestone: ---
Assignee: David Hallas
Keywords: junior-jobs
Depends on:
Reported: 2017-12-12 23:24 UTC by Patrick Silva
Modified: 2018-08-25 19:09 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 18.12.0

screenshot (16.74 KB, image/png)
2017-12-12 23:24 UTC, Patrick Silva
tab and window decoration show different titles (37.90 KB, image/png)
2017-12-13 00:30 UTC, Patrick Silva
Tab of pen drive shows weird title (33.11 KB, image/png)
2018-03-09 14:17 UTC, Patrick Silva

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-12-12 23:24:54 UTC
Created attachment 109343 [details]

I think tabs names currently are not good when I open items from the sidebar in a new tab.
For example...

root shows "/"
network shows "remote"
documents shows "baloosearch"

See the screenshot.
Comment 1 Nate Graham 2017-12-12 23:51:00 UTC
These are just their normal window titles. If you navigate to those sidebar items on their own, you should see the same titles. So this should really be split into multiple bugs requesting better titles for root and network

Note: I'm not sure how you could have gotten "baloosearch" from Documents. But "baloosearch" being the window title for all search-related views was recently fixed in https://bugs.kde.org/show_bug.cgi?id=321575
Comment 2 Patrick Silva 2017-12-13 00:30:17 UTC
Created attachment 109344 [details]
tab and window decoration show different titles

Normal window titles?

Network for example: tab shows "remote", dolphin window decoration shows "Rede".
"Rede" = "Network" in my language.
Comment 3 Nate Graham 2017-12-13 00:32:45 UTC
Ah, I see what you mean now. looks like this is a broader issue in Dolphin where the titles set for the Sidebar items aren't getting re-used for tab titles.
Comment 4 Patrick Silva 2018-03-09 14:17:44 UTC
Created attachment 111278 [details]
Tab of pen drive shows weird title
Comment 5 Patrick Silva 2018-06-12 20:21:40 UTC
tab title also is not good when I use ctrl+t to open a new tab.
For example, open dolphin and click "network" in the sidebar.
Now press ctrl+t: now you have two tabs titled "remote".
Comment 6 Julian Steinmann 2018-07-03 21:36:23 UTC
This problem does still exist with Dolphin 18.04.2, confirmed.
Comment 7 David Hallas 2018-07-28 15:30:21 UTC
I am working on implementing this. The solution I am going for is basically to have the tab titles follow the window title, I think that is the most logical.
Comment 8 Christoph Feck 2018-08-17 20:45:29 UTC
Comment 9 David Hallas 2018-08-24 10:09:38 UTC
Git commit 44a21ea51a055c7429ddee866e35b0a5a21c072b by David Hallas.
Committed on 24/08/2018 at 10:09.
Pushed by hallas into branch 'master'.

Unify window and tab title

Previously the title of tabs was a prettyfied version of the URL.
This is inconsistent with the title of the Window and in some cases
for specials URLs kind of misleading. This commit generalizes the
code from DolphinMainWindow so that both the DolphinMainWindow title
and the tab title uses the same function for the title. This also
means that the 'Show Full Path in Title Bar' also applies to the
tab title, and also that searches changes the tab title.

Test Plan: Open a new tab from the places panel and navigate around.

Reviewers: #dolphin, ngraham, elvisangelaccio, markg

Reviewed By: #dolphin, ngraham, markg

Subscribers: markg, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D14442

M  +4    -43   src/dolphinmainwindow.cpp
M  +2    -3    src/dolphinmainwindow.h
M  +10   -16   src/dolphintabwidget.cpp
M  +1    -1    src/dolphintabwidget.h
M  +47   -0    src/dolphinviewcontainer.cpp
M  +7    -0    src/dolphinviewcontainer.h