Bug 321575 - Dolphin window title gets set to ugly strings ("Baloosearch -/", ) when displaying a Place that comes from a KIOSlave
Summary: Dolphin window title gets set to ugly strings ("Baloosearch -/", ) when displ...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: search (show other bugs)
Version: 4.12.4
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: usability
: 328859 333195 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-06-24 19:32 UTC by Julián Unrrein
Modified: 2017-12-03 15:00 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Window title while searching (86.19 KB, image/png)
2013-06-24 19:33 UTC, Julián Unrrein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Julián Unrrein 2013-06-24 19:32:56 UTC
The window title could be set to something along the lines of "Searching in %directory".

Reproducible: Always
Comment 1 Julián Unrrein 2013-06-24 19:33:19 UTC
Created attachment 80760 [details]
Window title while searching
Comment 2 Frank Reininghaus 2014-04-09 13:35:24 UTC
*** Bug 333195 has been marked as a duplicate of this bug. ***
Comment 3 Frank Reininghaus 2014-04-09 13:39:50 UTC
Thanks for the suggestion. Note that this also applies to tab titles, and also to the 'baloosearch' kioslave.

Replacing the tab/window titles manually based on the protocol is not pretty code-wise, but I see that there is no great value in showing the names of the different search protocols, which are implementation details, to the user.
Comment 4 Nate Graham 2017-09-03 05:57:55 UTC
yes, this should probably be replaced with the actual search term.
Comment 5 Nate Graham 2017-09-03 05:58:01 UTC
*** Bug 328859 has been marked as a duplicate of this bug. ***
Comment 6 Nate Graham 2017-09-23 05:04:14 UTC
Looks like we already fixed this for some use cases (Trash, home) in https://cgit.kde.org/dolphin.git/commit/?id=652f57d28152491c42ad740d2bacd12a12d3d3d7

Not for the "baloosearch -/" one, though.
Comment 7 Nate Graham 2017-09-23 15:58:38 UTC
Another data point: if you add a Places item with the URL baloosearch:/ and some label, as of the patch I mentioned, it now correctly displays the label in the window title instead of "baloosearch - /".

So this is still wrong in only two situations:
1. Places with the "search:/" URL display "baloosearch - /" in the window title
2. Using the Find feature replaces the window title with "baloosearch - /"
Comment 8 Nate Graham 2017-12-03 15:00:33 UTC
Git commit 702429ac8e64a5aff4e110a56f526b96ecb795fd by Nathaniel Graham, on behalf of Julian Schraner.
Committed on 03/12/2017 at 15:00.
Pushed by ngraham into branch 'master'.

Change window title when searching

Summary:
When you search for a file (e.g. "hello world") the window title of Dolphin will now change to "Search for [input]" instead of "baloosearch - /".

Test Plan:
  - Disables it iself after search bar is hidden
  - Works with multiple word searches

Reviewers: #dolphin, ngraham, elvisangelaccio

Reviewed By: #dolphin, ngraham, elvisangelaccio

Subscribers: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D8273

M  +10   -0    src/dolphinmainwindow.cpp
M  +5    -0    src/dolphinviewcontainer.cpp
M  +2    -0    src/dolphinviewcontainer.h

https://commits.kde.org/dolphin/702429ac8e64a5aff4e110a56f526b96ecb795fd