Bug 386895 - dialog-password grossly oversized in gtk3
Summary: dialog-password grossly oversized in gtk3
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-14 07:26 UTC by Andrew Chen
Modified: 2018-01-09 11:42 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
example screenshot (19.82 KB, image/png)
2017-11-14 07:26 UTC, Andrew Chen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Chen 2017-11-14 07:26:59 UTC
Created attachment 108856 [details]
example screenshot

Gtk3 applications that use the `dialog-password` icon have them displayed much larger than other icons.

`blueman-manager` is used as an example here. In the screenshot, notice the 3rd icon from the left in the taskbar.
Comment 1 Andrew Chen 2017-11-14 07:33:31 UTC
Actually now that I think about it again, maybe the icon should've never been used in a taskbar in the first place. Although Adwaita's version of this icons is in-line with the other toolbar icon sizes.

Could you let me know what you think about this. If this is indeed a misuse of the icon, I'll go file a bug with blueman instead.
Comment 2 Jens Reuterberg 2017-11-14 08:30:11 UTC
Well I would see this as a Breeze-Icon theme bug since we don't have a "dialogue-password" symbolic icon (as far as I can see the others in the toolbar are symbolic icons). 

Lemme mark this email as "important" and make a symbolic icon for the theme and ping Andreas Kainz to see if he can throw it in there and if that helps it.
Comment 3 Nate Graham 2017-11-14 16:25:08 UTC
Any chance this is resolved (or at least improved) by https://cgit.kde.org/breeze-icons.git/commit/?id=cb168d3a0bd56879746fc534e4cf09648ae2d7cc?

Seems somewhat similar to https://bugs.kde.org/show_bug.cgi?id=384473, especially as seen in https://bugsfiles.kde.org/attachment.cgi?id=107740
Comment 4 Andrew Chen 2017-11-19 01:29:13 UTC
@Nate No it doesn't help.

The issue seems to be that the icon is marked as fixed size:

> #64x64 - Fixed size - For dialog icons >!!!ONLY!!!< - DO_NOT_USE_ANYWHERE_ELSE - Color
> [status/64]
> Size=64
> Context=Status
> Type=Fixed

Whereas in Adwaita multiple sizes are provided.

Perhaps we could just make it scalable since it is already a svg?
Comment 5 andreas 2018-01-09 11:42:43 UTC
Git commit 13532b7e6a584368cea429d50385c83938e02269 by andreas kainz.
Committed on 09/01/2018 at 11:45.
Pushed by andreask into branch 'master'.

scalle px status icons

M  +3    -2    icons-dark/index.theme
A  +13   -0    icons-dark/status/24/dialog-password.svg
M  +3    -2    icons/index.theme
A  +13   -0    icons/status/24/dialog-password.svg

https://commits.kde.org/breeze-icons/13532b7e6a584368cea429d50385c83938e02269