Bug 384473 - Missing icon sizes
Summary: Missing icon sizes
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: OpenMandriva Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-07 18:41 UTC by mandian
Modified: 2018-01-31 02:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.41


Attachments
Fix icon size for MATE (960 bytes, patch)
2017-09-07 18:41 UTC, mandian
Details
Not properly scaled icons on MATE Desktop (30.76 KB, image/jpeg)
2017-09-07 18:44 UTC, mandian
Details
Not properly scaled icons with caja on MATE Desktop (45.39 KB, image/jpeg)
2017-09-07 18:45 UTC, mandian
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mandian 2017-09-07 18:41:29 UTC
Created attachment 107738 [details]
Fix icon size for MATE

Hi,

while I was trying to use breeze icons with MATE desktop I encountered some troubles with some icons not properly sized. It happens because according to index.theme not all size are covered by scalable icons (maybe MATE uses different size from PLASMA).

I attached the patch I use to solve it. Note for some reasons I can't understand 32 sized Emblems scalable icons are not scaled at 48 so I used 64 sized icons and they32 are scaled properly.
Comment 1 mandian 2017-09-07 18:44:41 UTC
Created attachment 107739 [details]
Not properly scaled icons on MATE Desktop

Here is an example of properly scaled icons on MATE Desktop.
Comment 2 mandian 2017-09-07 18:45:31 UTC
Created attachment 107740 [details]
Not properly scaled icons with caja on MATE Desktop

Here is an example of not properly scaled icons with caja on MATE Desktop.
Comment 3 Nate Graham 2017-09-08 16:06:54 UTC
Thanks for the patch! Please upload it to http://phabricator.kde.org/, which is where KDE tracks patches. It's likely to get lost here.
Comment 4 mandian 2017-09-13 22:15:53 UTC
Hi,

I did my best to submit the patch at phabricator. I do not find it so easy, at least at first time so I hope I did it fine.

The link is:
  https://phabricator.kde.org/D7810
Comment 5 Nate Graham 2017-09-13 23:59:33 UTC
You did great! Are you planning to make additional changes to your patch?
Comment 6 mandian 2017-09-14 17:00:28 UTC
I am not but I can't find the way to remove it from plan.
Comment 7 Nate Graham 2017-11-14 03:02:31 UTC
Git commit cb168d3a0bd56879746fc534e4cf09648ae2d7cc by Nathaniel Graham.
Committed on 14/11/2017 at 03:02.
Pushed by ngraham into branch 'master'.

Add missing icon sizes

Summary:
Add missing scalable icon sizes

Test Plan:
Add missing scalable icon sizes at index.theme. If not all size are covered by scalable icons some desktop environment other than PLASMA may show icons not properly scaled.

See also bug #384473 for more detailed explaination and screenshot
https://bugs.kde.org/show_bug.cgi?id=384473

Update:
>From the MATE Desktop environment you may use 'Appearance' (the binary is (/usr/bin/mate-appearance-properties) to modify its look-and-feel. There is not a Breeze theme listed there here but from the 'Theme' tab you may click the 'Customise...' button and from the new window you may select 'Breeze' in 'Controls', 'Pointer' and 'Icons' tabs.

{F5404548}

Then restart MATE to see the applied changes. Here is how MATE desktop appears with Breeze icons before the changes.

{F5402571}

As you may see (scalable) icons from Breeze theme are bigger than others (which are .svg icons too). In caja application this is even more evident especially for 'computer' icon

{F5402644}

After I inspected the caja code I found it uses scalable icons and I found the problem is Breeze does not provide for some icon sizes for some scalable icons required  by caja so it uses a bigger sized icon (all works fine with MATE default theme, of course). So I modified the Breeze index.theme as reported here and ,as you may see from the screenshots below, all icons are of the right size

desktop
{F5403169}

caja
{F5403202}

I used the fixed Breeze theme both in PLASMA and LXQt and I not noticed any differences from before to after so I believe my changes are not dangerous for other DE.

Reviewers: #breeze, #vdg, jensreuterberg, #frameworks, hein, mandian

Reviewed By: hein

Subscribers: andreask, hein, ngraham, cfeck, #frameworks

Tags: #frameworks, #breeze

Differential Revision: https://phabricator.kde.org/D7810

M  +4    -4    icons-dark/index.theme
M  +3    -3    icons/index.theme

https://commits.kde.org/breeze-icons/cb168d3a0bd56879746fc534e4cf09648ae2d7cc