Bug 386748 - Some icons are missing in tooltips
Summary: Some icons are missing in tooltips
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.15.4
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-11 12:46 UTC by Patrick Silva
Modified: 2019-04-03 15:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.15.5


Attachments
workspace theme (57.62 KB, image/png)
2017-11-11 12:46 UTC, Patrick Silva
Details
fonts (41.48 KB, image/png)
2017-11-11 12:46 UTC, Patrick Silva
Details
desktop behavior (54.02 KB, image/png)
2017-11-11 12:47 UTC, Patrick Silva
Details
window management (52.61 KB, image/png)
2017-11-11 12:47 UTC, Patrick Silva
Details
startup and shutdown (55.40 KB, image/png)
2017-11-11 12:48 UTC, Patrick Silva
Details
account details (33.92 KB, image/png)
2017-11-11 12:48 UTC, Patrick Silva
Details
bluetooth (33.50 KB, image/png)
2017-11-11 12:49 UTC, Patrick Silva
Details
input devices (28.83 KB, image/png)
2017-11-11 12:50 UTC, Patrick Silva
Details
multimedia (31.36 KB, image/png)
2017-11-11 12:50 UTC, Patrick Silva
Details
power management (35.95 KB, image/png)
2017-11-11 12:51 UTC, Patrick Silva
Details
removable devices (20.14 KB, image/png)
2017-11-11 12:51 UTC, Patrick Silva
Details
icon view, plasma 5.15.4 (41.97 KB, image/png)
2019-04-02 21:50 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-11-11 12:46:23 UTC
Created attachment 108785 [details]
workspace theme

neon dev unstable here.
See the screenshots please.
Comment 1 Patrick Silva 2017-11-11 12:46:46 UTC
Created attachment 108786 [details]
fonts
Comment 2 Patrick Silva 2017-11-11 12:47:10 UTC
Created attachment 108787 [details]
desktop behavior
Comment 3 Patrick Silva 2017-11-11 12:47:41 UTC
Created attachment 108788 [details]
window management
Comment 4 Patrick Silva 2017-11-11 12:48:18 UTC
Created attachment 108789 [details]
startup and shutdown
Comment 5 Patrick Silva 2017-11-11 12:48:56 UTC
Created attachment 108790 [details]
account details
Comment 6 Patrick Silva 2017-11-11 12:49:33 UTC
Created attachment 108791 [details]
bluetooth
Comment 7 Patrick Silva 2017-11-11 12:50:00 UTC
Created attachment 108792 [details]
input devices
Comment 8 Patrick Silva 2017-11-11 12:50:36 UTC
Created attachment 108793 [details]
multimedia
Comment 9 Patrick Silva 2017-11-11 12:51:03 UTC
Created attachment 108794 [details]
power management
Comment 10 Patrick Silva 2017-11-11 12:51:32 UTC
Created attachment 108795 [details]
removable devices
Comment 11 Patrick Silva 2018-02-07 12:49:14 UTC
Same thing in plasma 5.12, Arch Linux.
Breeze dark is not affected.
Comment 12 Nate Graham 2019-01-17 21:27:20 UTC
For subcategories, the tooltip uses 22px icons. When there is no 22px version of the icon, it downscales the 32px color version, so there is no problem. But for icons with a 22px monochrome version that, that's shown instead.

So this is caused by a combination of inter-related issues:

1. The tooltip's background is dark and the icons are not hinted to reverse their color scheme, so when using Breeze light, any monochrome icons will be the same color as the tooltip and be invisible.

2. Some of the icons here have no 32px color version, only a 22px monochrome version.

3. Some of the icons have both 32px color versions and 22px monochrome versions.


---


#1 is fixable with code changes to make monochrome icons be color-scheme-aware in the tooltip, but this will still result in some color icons and some monochrome icons, which is not the visual effect we're looking for.

So I think the real fix here is to make sure that all icons are colorized, not monochrome. This will involve creating color versions of the icons that are currently monochrome (fixing #2), and removing the monochrome versions of the icons that have 32px color versions (fixing #3)

Adding as an action item for https://phabricator.kde.org/T10273.
Comment 13 Nate Graham 2019-02-06 21:58:46 UTC
Or alternatively we could just hardcode a 24px size, which bypasses these problems entirely, which is what the equivalent tooltip in KInfoCenter does. Patch: https://phabricator.kde.org/D18797
Comment 14 Nate Graham 2019-02-06 22:46:13 UTC
Git commit a7141be3091f46a2cfac3b1a6cfc6c78b2d684ed by Nate Graham.
Committed on 06/02/2019 at 22:46.
Pushed by ngraham into branch 'master'.

Use colorful icon in KCM

Summary:
Use a nice new colorful icon.

Master only since this icon is provided by a symlink created in Frameworks 5.56.

Test Plan:
Before: {F6592327, size=full}
After: {F6592328, size=full}

Reviewers: #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18800

M  +1    -1    src/user_manager.desktop

https://commits.kde.org/user-manager/a7141be3091f46a2cfac3b1a6cfc6c78b2d684ed
Comment 15 Nate Graham 2019-03-16 21:10:44 UTC
This can be fixed with code similar to https://cgit.kde.org/kinfocenter.git/commit/?id=23fa369831709f43a3100476b00ced10a1123f7f
Comment 16 Nate Graham 2019-03-16 23:54:20 UTC
I'll give it a try tomorrow or the next day if I can rustle up the time...
Comment 17 Nate Graham 2019-03-17 16:48:25 UTC
Fixed in https://phabricator.kde.org/D19834
Comment 18 Patrick Silva 2019-04-02 19:57:27 UTC
bug persists when icon view is used.
Comment 19 Nate Graham 2019-04-02 20:32:57 UTC
New screenshot please.
Comment 20 Patrick Silva 2019-04-02 21:50:57 UTC
Created attachment 119217 [details]
icon view, plasma 5.15.4
Comment 21 Nate Graham 2019-04-03 15:31:22 UTC
Oh jeez, icon view has its own tooltip code. :/ Fixing that too.
Comment 22 Nate Graham 2019-04-03 15:33:54 UTC
Git commit 8b2e8d7eb61a82b61df40489eb09ce297a21c3eb by Nate Graham.
Committed on 03/04/2019 at 15:33.
Pushed by ngraham into branch 'Plasma/5.15'.

Fix invisible monochrome icons in Icon View tooltips too
This is a straight port of 8996c9bb8b248c23b4b96c633e5baefedffb6e15
FIXED-IN: 5.15.5

M  +20   -1    app/ToolTips/tooltipmanager.cpp

https://commits.kde.org/systemsettings/8b2e8d7eb61a82b61df40489eb09ce297a21c3eb