Bug 384743 - Remove "Do not show again" from "Help" menu>"System check"
Summary: Remove "Do not show again" from "Help" menu>"System check"
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: GUI/Usability (show other bugs)
Version: 17.08.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-15 13:59 UTC by Patrick Silva
Modified: 2017-09-29 19:39 UTC (History)
4 users (show)

See Also:
Latest Commit: https://commits.kde.org/k3b/e5174fc9661a8e60623d650f4934d8265d442bc6
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2017-09-15 13:59:52 UTC 
Because this dialog should always be shown when called by the menu.
Comment 1 Patrick Silva 2017-09-15 14:02:15 UTC 
Or K3b should show "no problem found" or similar message when this is the case.
Comment 2 Leslie Zhai 2017-09-25 01:45:40 UTC 

*** This bug has been marked as a duplicate of bug 381368 ***
Comment 3 Patrick Silva 2017-09-25 02:16:23 UTC 
Thank you Leslie
This report is not a duplicate.
The dalog mentioned in 381368 is result of a automatic check when K3b is started. Such dialog must appear only if the user allow this automatic check at K3b startup. Ok, this issue is solved, the user can disable it by checking "do not show..."

The dialog called from "help" menu is a manual check, it must ALWAYS to be open, a "do not show..." option here does no sense. Otherwise if the user checks "do not show..." the dilaog is never opened and "system check" option from "help" menu becomes useless.

"do not show..." must to be shown only on the dialog called by K3b at startup.
Comment 4 Leslie Zhai 2017-09-25 02:29:01 UTC 
Git commit e5174fc9661a8e60623d650f4934d8265d442bc6 by Leslie Zhai.
Committed on 25/09/2017 at 02:27.
Pushed by lesliezhai into branch 'master'.

Hide Do not show again CheckBox for forceCheck.

M  +3    -1    src/k3bsystemproblemdialog.cpp
M  +1    -0    src/k3bsystemproblemdialog.h

https://commits.kde.org/k3b/e5174fc9661a8e60623d650f4934d8265d442bc6