Created attachment 106155 [details] screenshot K3b always shows this dialog no matter I check "do not show again".
do you have frameworkintegration installed?
Yes, frameworkintegration 5.35.0+p16.04+git20170616.1345-0.
ok
Fixed https://git.reviewboard.kde.org/r/130162/ but why QDialogButtonBox::Close could not emit closeEvent?
Git commit c1fae2adc90fac9a2af11ec9ef95ecc12033fa41 by Leslie Zhai. Committed on 19/06/2017 at 08:42. Pushed by lesliezhai into branch 'master'. Fix "do not show again" from system configuration problems dialog is not remembered REVIEW: 130162 M +5 -6 src/k3bsystemproblemdialog.cpp M +1 -1 src/k3bsystemproblemdialog.h https://commits.kde.org/k3b/c1fae2adc90fac9a2af11ec9ef95ecc12033fa41
this bug is still happening with k3b 17.08 beta on neon dev stable.
(In reply to Dr. Chapatin from comment #6) > this bug is still happening with k3b 17.08 beta on neon dev stable. Please review the patch https://git.reviewboard.kde.org/r/130162/
Sorry, I'm not a software developer.
(In reply to Dr. Chapatin from comment #8) > Sorry, I'm not a software developer. The patch had been reviewed by Harald Sitter https://twitter.com/apachelogger and I can not reproduce it!
(In reply to Leslie Zhai from comment #9) > The patch had been reviewed by Harald Sitter > https://twitter.com/apachelogger and I can not reproduce it! The patch works fine AFAICT, the setting is saved correctly now. But it is not respected it seems. FWICT, this is the culprit: connect( k3bcore->deviceManager(), SIGNAL(changed()), this, SLOT(slotCheckSystemTimed()) ); (src/k3b.cpp, line 261) This causes K3b::SystemProblemDialog::checkSystem() being called *without* checking the "do not show again" setting. Removing that line fixes it, but I don't know whether this is a good idea as I don't know why it is there in the first place. Maybe it would be better to change K3b::MainWindow::slotCheckSystem() to check the setting like it is done in K3b::Application::checkSystemConfig(). But to me it seems that both are called on startup currently, which doesn't really make sense either. Btw, AFAICS this problem has been introduced in master (but not 2.0.x) years ago already, long before the port to KF5 started.
PS: for being able to reproduce it, maybe try to remove the mad decoder (/usr/lib64/qt5/plugins/k3bmaddecoder.so and /usr/share/kservices5/k3bmaddecoder.desktop or similar). That should trigger the dialog on startup and the problem, according to http://bugzilla.opensuse.org/show_bug.cgi?id=1051368 .
Git commit 9408b834d4eb20264a526beb3bbbb1c5882db564 by Leslie Zhai. Committed on 01/08/2017 at 06:24. Pushed by lesliezhai into branch 'master'. Add readCheckSystemConfig before checkSystem to fix "do not show again" from system configuration problems dialog is not remembered issue. A great patch by Wolfgang Bauer! M +8 -5 src/k3bsystemproblemdialog.cpp https://commits.kde.org/k3b/9408b834d4eb20264a526beb3bbbb1c5882db564
Well, this fixes the problem reported here, but it also "breaks" the manual check (Help->System Check) if "Check system configuration" is disabled. I think it would be better to test the setting in K3b::MainWindow::slotCheckSystem() instead. (the "System Check" menu entry calls K3b::MainWindow::slotManualCheckSystem()...)
Git commit 762fc98addfc5a83e80aa1c7d83384a512c48f33 by Leslie Zhai. Committed on 02/08/2017 at 06:44. Pushed by lesliezhai into branch 'master'. Add forceCheck for ManualCheckSystem. M +1 -1 src/k3b.cpp M +2 -2 src/k3bsystemproblemdialog.cpp M +1 -1 src/k3bsystemproblemdialog.h https://commits.kde.org/k3b/762fc98addfc5a83e80aa1c7d83384a512c48f33
Seems to be fine now, thank you!
*** Bug 384743 has been marked as a duplicate of this bug. ***