Bug 384032 - Get new hot stuff sorting not applied when selecting option 'most downloads'
Summary: Get new hot stuff sorting not applied when selecting option 'most downloads'
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: HI normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
: 419485 428341 431648 435080 443392 445823 447616 462987 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-08-26 04:06 UTC by tneo
Modified: 2023-04-09 15:14 UTC (History)
13 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Get Hot New Stuff dialog randomly sorted while 'most downloads' is selected (128.32 KB, image/png)
2017-08-26 04:06 UTC, tneo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tneo 2017-08-26 04:06:49 UTC
Created attachment 107525 [details]
Get Hot New Stuff dialog randomly sorted while 'most downloads' is selected

Given that a user is opening the 'get hot new stuff' dialog
When the user is activating option 'most downloads'
Then the browse window is sorted based upon the actual amount of downloads for 'hot new stuff'
And when multiple items have the same download count then these are sorted alphabetically
Comment 1 Alexander Lohnau 2020-07-18 05:55:48 UTC
Can confirm, this is still an issue with both the QtQuick and QWidgets based dialog.
Comment 2 Alexander Lohnau 2020-07-21 06:51:31 UTC
*** Bug 419485 has been marked as a duplicate of this bug. ***
Comment 3 Alexander Lohnau 2020-08-30 05:49:34 UTC
KNewstuff uses the attica provider to get these entries and there an url is constructed which contains the sort order (example query for icons category):
https://api.kde-look.org/ocs/v1/content/data?categories=132&distribution&license&search&sortmode=down&page=0&pagesize=20

And there we can see that the results from the API are not sorted. Also when looking at the KDE Store I noticed that there is no option to sort by downloads.
Comment 4 Alexander Lohnau 2020-08-30 06:02:34 UTC
Looking at the spec https://www.freedesktop.org/wiki/Specifications/open-collaboration-services-1.7/ the API request looks IMO good (just search for sortmode on this page)

And doing a manual sorting in the attica framework would be really hacky, maybe we should reach out to the people responsible for maintaining the API?
Comment 5 Alexander Schmidt 2020-09-01 08:47:14 UTC
Hello, 
we have heard about the problems and we will try to fix them as soon as possible.
Comment 6 Alexander Lohnau 2021-03-01 11:23:26 UTC
*** Bug 431648 has been marked as a duplicate of this bug. ***
Comment 7 Patrick Silva 2021-06-01 15:03:55 UTC
*** Bug 435080 has been marked as a duplicate of this bug. ***
Comment 8 Patrick Silva 2021-06-04 19:16:29 UTC
*** Bug 428341 has been marked as a duplicate of this bug. ***
Comment 9 Patrick Silva 2021-10-06 17:21:26 UTC
*** Bug 443392 has been marked as a duplicate of this bug. ***
Comment 10 Patrick Silva 2021-11-20 19:08:26 UTC
*** Bug 445823 has been marked as a duplicate of this bug. ***
Comment 11 Patrick Silva 2021-12-28 23:56:42 UTC
*** Bug 447616 has been marked as a duplicate of this bug. ***
Comment 12 Paul Worrall 2022-12-13 09:04:21 UTC
*** Bug 462987 has been marked as a duplicate of this bug. ***
Comment 13 Alexander Lohnau 2022-12-13 17:56:07 UTC
@Alexander Schmidt Any update on this?
Comment 14 Alexander Schmidt 2022-12-16 19:06:53 UTC
I hope what takes a long time will finally be good. I just worked on the API for another reason and tried to solve the problem described here at the same time. We have sorted by the downloads of the last 24h, but the total sum of downloads is shown in the list. This is of course confusing for the user and not helpful. We are now sorting by the total sum of downloads and I hope the result now matches what the user's expected.
Comment 15 tneo 2022-12-16 19:24:13 UTC
Sounds good to me. Waiting to see it land to give final review. :-)
Comment 16 Patrick Silva 2023-04-09 13:24:34 UTC
Cannot reproduce.

Operating System: Arch Linux 
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.8
Graphics Platform: Wayland
Comment 17 tneo 2023-04-09 15:14:53 UTC
(In reply to Patrick Silva from comment #16)
> Cannot reproduce.
> 
> Operating System: Arch Linux 
> KDE Plasma Version: 5.27.4
> KDE Frameworks Version: 5.105.0
> Qt Version: 5.15.8
> Graphics Platform: Wayland

Yes it is resolved. Thanks!