Bug 383725 - Not fully visible top list item after scrolling in Discover
Summary: Not fully visible top list item after scrolling in Discover
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-20 04:33 UTC by Alexander Mentyu
Modified: 2018-02-13 22:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
not-fully-visible-top-list-item (308.96 KB, image/png)
2017-08-20 04:33 UTC, Alexander Mentyu
Details
not-fully-visible-top-list-item-2 (297.60 KB, image/png)
2017-08-20 04:33 UTC, Alexander Mentyu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mentyu 2017-08-20 04:33:12 UTC
Created attachment 107375 [details]
not-fully-visible-top-list-item

Sometimes top list item is not fully visible in a list after scrolling.

This happens more often when there are a lot of items in a list and scrolling down (approximately to the middle) were made by mouse click on scrollbar and dragging it lower

 - and after that - 

scrolling up to the ALMOST very top were made by mouse click on scrollbar and dragging it upper

 - and than - 

scrolling to the very top were made by mouse wheel.
Comment 1 Alexander Mentyu 2017-08-20 04:33:47 UTC
Created attachment 107376 [details]
not-fully-visible-top-list-item-2
Comment 2 Marco Martin 2017-08-28 12:24:11 UTC
Git commit d37a938f2a13286f629d0a16d0b2efe78ab463d4 by Marco Martin.
Committed on 28/08/2017 at 12:23.
Pushed by mart into branch 'master'.

adress FIXME: remove resetTimer

remove resetTimer from refreshableScrollView: doesn't seem
to be necessary anymoe, was an hack and breaks top margin sometimes

together with previous commit, fixes 383725 and 383772
Related: bug 383772

M  +0    -29   src/controls/private/RefreshableScrollView.qml

https://commits.kde.org/kirigami/d37a938f2a13286f629d0a16d0b2efe78ab463d4
Comment 3 Marco Martin 2017-08-28 12:26:02 UTC
sorry, the commit closed the wrong bug
Comment 4 Marco Martin 2017-08-28 13:29:04 UTC
Git commit 3c2d1e23e45c03321e110dabfe77c89d3c3e0703 by Marco Martin.
Committed on 28/08/2017 at 13:28.
Pushed by mart into branch 'master'.

don't take into account the header 2 times when scrolling

flickableItem.topMargin already comprises the header item,
so the calculation where to stop scrolling was wrong, giving the erratic
behavior
Related: bug 382191

M  +0    -4    src/controls/templates/private/ScrollView.qml

https://commits.kde.org/kirigami/3c2d1e23e45c03321e110dabfe77c89d3c3e0703
Comment 5 Marco Martin 2017-08-28 13:30:46 UTC
can this be tried again in kirigami master after the above commit?
Comment 6 Alexander Mentyu 2017-08-30 10:12:00 UTC
Can't reproduce anymore in KDE neon 

kirigami-gallery 2.2.0+p16.04+git20170830

plasma-discover 5.10.5+p16.04+git20170825.1638-0