Bug 382191 - update page gets freaky when scrolling past top
Summary: update page gets freaky when scrolling past top
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-10 10:17 UTC by Harald Sitter
Modified: 2018-02-13 22:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
video (1.25 MB, video/x-matroska)
2017-07-10 10:18 UTC, Harald Sitter
Details
flickering-scroll-past-top-discover (497.11 KB, video/mp4)
2017-08-20 04:04 UTC, Alexander Mentyu
Details
flickering-scroll-past-top-discover-2 (1.45 MB, video/mp4)
2017-08-20 04:05 UTC, Alexander Mentyu
Details
flickering-scroll-past-top-discover-3 (984.60 KB, video/mp4)
2017-08-20 04:05 UTC, Alexander Mentyu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2017-07-10 10:17:30 UTC
- have a bunch of updates
- start updates
- scroll down a bit
- scroll to top
- scroll up some more
- update page gets jumpy layout
- scroll up some more very fast by accelerating wheel sufficiently
- update page starts breathing heavily and jumpin about like wild (due to quick probably repeated layout reshuffling)
Comment 1 Harald Sitter 2017-07-10 10:18:44 UTC
Created attachment 106531 [details]
video
Comment 2 Aleix Pol 2017-07-10 10:26:23 UTC
I cannot reproduce. Which version of Kirigami are you using?
Comment 3 Harald Sitter 2017-07-10 10:27:56 UTC
2.2.0
Comment 4 Alexander Mentyu 2017-08-19 17:10:04 UTC
This bug no longer appears for me in:

Distribution: KDE neon Developer Edition Unstable Branches live iso 20170813
KDE Plasma Version: 5.10.90
KDE Frameworks Version: 5.37.0
Qt Version: 5.9.1
Kernel Version: 4.10.0-32-generic
Discover: 5.10.90
Comment 5 Alexander Mentyu 2017-08-20 04:04:48 UTC
Created attachment 107372 [details]
flickering-scroll-past-top-discover
Comment 6 Alexander Mentyu 2017-08-20 04:05:08 UTC
Created attachment 107373 [details]
flickering-scroll-past-top-discover-2
Comment 7 Alexander Mentyu 2017-08-20 04:05:30 UTC
Created attachment 107374 [details]
flickering-scroll-past-top-discover-3
Comment 8 Alexander Mentyu 2017-08-20 04:06:16 UTC
I still managed to reproduce flickering - but not upon updates. It's reproducing sometimes upon regular navigating for me. Three recorder videos attached.
Comment 9 Alexander Mentyu 2017-08-20 04:25:21 UTC
It happens more often for me if scrolling with touchpad.
Comment 10 Marco Martin 2017-08-28 13:29:04 UTC
Git commit 3c2d1e23e45c03321e110dabfe77c89d3c3e0703 by Marco Martin.
Committed on 28/08/2017 at 13:28.
Pushed by mart into branch 'master'.

don't take into account the header 2 times when scrolling

flickableItem.topMargin already comprises the header item,
so the calculation where to stop scrolling was wrong, giving the erratic
behavior
Related: bug 383725

M  +0    -4    src/controls/templates/private/ScrollView.qml

https://commits.kde.org/kirigami/3c2d1e23e45c03321e110dabfe77c89d3c3e0703
Comment 11 Marco Martin 2017-08-28 13:30:32 UTC
can this be tried again in kirigami master after the above commit?
Comment 12 Alexander Mentyu 2017-08-30 10:18:15 UTC
Can't reproduce anymore in KDE neon 

kirigami-gallery 2.2.0+p16.04+git20170830

plasma-discover 5.10.5+p16.04+git20170825.1638-0