Bug 382864 - wrong info about PDF backend
Summary: wrong info about PDF backend
Status: CONFIRMED
Alias: None
Product: okular
Classification: Applications
Component: PDF backend (show other bugs)
Version: 1.1.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-28 14:51 UTC by Uwe Stöhr
Modified: 2020-11-25 10:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Stöhr 2017-07-28 14:51:09 UTC
- open a PDF with Okular 1.1.3
- use the menu Help -> About Backend

result:
"
2005-2008 Albert Astals Cid
"

Is this really true? Only one developer and no progress since 9 years?
Comment 1 Albert Astals Cid 2017-07-29 10:19:22 UTC
We can either fix that or spend time on bugs, you decide ;)
Comment 2 Uwe Stöhr 2017-07-29 13:47:48 UTC
> We can either fix that or spend time on bugs, you decide ;)

I am confused. Usually developers like feedback. Personally for me every feedback is welcome, no matter if users report severe things or cosmetic ones.
Comment 3 Oliver Sander 2017-07-30 22:46:29 UTC
I agree with Uwe: it is very minor, but it is a bug. Albert, I will prepare a patch if you tell me who is to be listed in that 'About' dialog.  Everybody who changed a file in okular/generators/poppler ?
Comment 4 Albert Astals Cid 2017-07-30 22:49:26 UTC
(In reply to Oliver Sander from comment #3)
> I agree with Uwe: it is very minor, but it is a bug. Albert, I will prepare
> a patch if you tell me who is to be listed in that 'About' dialog. 
> Everybody who changed a file in okular/generators/poppler ?

That is the big question, isn't it :D

What constitutes copyright and who should be listed or not on places and should people that contributed 1 line be listed in the same place that people that contributed 1000000. I've no answers for those questions.
Comment 5 Oliver Sander 2017-07-30 22:55:17 UTC
Well.  In that case, why not simply remove those 'About backend' dialogs, and have one copyright list for all of okular only?  That would not solve your fundamental question, but it would make it easier.
Comment 6 Uwe Stöhr 2017-07-30 22:56:00 UTC
> should people that contributed 1 line be listed in the same place that people that contributed 1000000.

Unfortunately, legally spoken, yes. One line is enough to claim the same rights. That is why we list in LyX everybody in the credits who gave once his agreement to the GPL.
I know and it is crazy that people spending countless hours appear there with ones with a single contribution.

But what about adding the number of commits etc. behind the name in parentheses if you like?
Comment 7 Oliver Sander 2017-07-31 14:28:21 UTC
Hmm, unfortunately Uwe is correct, and legally one line is enough.

A tentative

git log --pretty=format:"%an" generators/poppler | sort | uniq

gives me 53 names, though...
Comment 8 Albert Astals Cid 2017-07-31 21:17:14 UTC
(In reply to Oliver Sander from comment #7)
> Hmm, unfortunately Uwe is correct, and legally one line is enough.

That is true and not true at the same time, you don't have to list people on the UI, you have to list them ideally in the file header, which we don't do either, since we cop out and say "you can always have a look at the git log"

> 
> A tentative
> 
> git log --pretty=format:"%an" generators/poppler | sort | uniq
> 
> gives me 53 names, though...

And the ones that when we used svn that doesn't have a concept of "author" vs "commited" so we commented on the commit log who was the author if we got a patch via email, etc.

Note i'm not against listing anyone in the UI, i really think it may be a nice thing for newbies and encourage them to contribute more, what i am against is spending my time discussing how this has to be done, but well, here i am answering this email instead of doing a poppler release.
Comment 9 Uwe Stöhr 2017-08-02 00:21:36 UTC
Dear Albert, you got me wrong. I was just reporting all bugs with my first trials with Okular. I did not sort for severe and cosmetic bugs. My reports were also not meant to force you to have a look at them right now.

We develop for fun in our spare time so no need to stress ourselves. So please postpone this issue and do a poppler release or another thing that is more important.

If you ask me which of the bugs I reported are the most pressing one, I will answer https://bugs.kde.org/show_bug.cgi?id=382857
However, this bug is there the same way in Evince, Xreader and qpdfview, so it seems to be a bug in a library these programs all use.
Comment 10 Uwe Stöhr 2020-11-25 10:33:31 UTC
Thus bug is still in Okular 1.11.