Bug 382550 - man pages not created in kaffeine 2.0.12
Summary: man pages not created in kaffeine 2.0.12
Status: RESOLVED FIXED
Alias: None
Product: releaseme
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Sitter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-20 20:11 UTC by Jan Palus
Modified: 2017-08-11 09:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Palus 2017-07-20 20:11:52 UTC
Looks like "kdoctools_create_manpage" is missing in release tarball found under https://download.kde.org/stable/kaffeine/.
Comment 1 Mauro Carvalho Chehab 2017-07-21 10:52:54 UTC
For 2.0.12 tarball, I started using releaseme. It seems that releaseme completely replaced Kaffeine's doc/CMakeLists.txt, instead of just appending translations to it.

The original content of the file is:

kdoctools_create_handbook(index.docbook INSTALL_DESTINATION ${HTML_INSTALL_DIR}/
en SUBDIR kaffeine)
kdoctools_create_manpage (man-kaffeine.1.docbook 1 INSTALL_DESTINATION ${MAN_INS
TALL_DIR})

It got replaced by: 

add_subdirectory(ca)
add_subdirectory(pt)
add_subdirectory(en)
add_subdirectory(sv)
add_subdirectory(uk)
add_subdirectory(pt_BR)
add_subdirectory(it)
add_subdirectory(nl)

Additionally, I had to remove a .gitignore file from that dir, as otherwise it would be creating an add_subdirectory(.gitignore)
Comment 2 Mauro Carvalho Chehab 2017-07-23 02:06:28 UTC
(In reply to Jan Palus from comment #0)
> Looks like "kdoctools_create_manpage" is missing in release tarball found
> under https://download.kde.org/stable/kaffeine/.

I created a new tarball using kde-create-tarball script, instead of releaseme. It should provide manpages:

https://download.kde.org/stable/kaffeine/2.0.12/src/kaffeine-2.0.12.1.tar.xz.mirrorlist
Comment 3 Jan Palus 2017-07-23 23:05:02 UTC
(In reply to Mauro Carvalho Chehab from comment #2)
> I created a new tarball using kde-create-tarball script, instead of
> releaseme. It should provide manpages:
> 
> https://download.kde.org/stable/kaffeine/2.0.12/src/kaffeine-2.0.12.1.tar.xz.
> mirrorlist

Works fine now. Thanks!
Comment 4 Harald Sitter 2017-07-24 14:03:45 UTC
Related to bug #381103 which is kinda blocked by weirdly shitty stuff we support for one reason or another.
Comment 5 Harald Sitter 2017-08-11 09:58:53 UTC
Git commit d701767a34fc38b24fb5d4379338fc1420f2ef54 by Harald Sitter.
Committed on 10/08/2017 at 10:03.
Pushed by sitter into branch 'master'.

port documentation handling to kdoctools

now that plasma dropped the if conditionals in doc/CMakeLists.txt
requirement we can rely on kdoctools' somewhat less sophisticated
documentation handling. saves us excessive amounts of code with insane
complexity and aligns the source tree more with what frameworks have.

this also gives us "free" manpage support, add some minor branching to
correctly detect and copy manpage docbooks into the final tree. also
new test case to assert the results are well-formed
Related: bug 381103

M  +7    -7    .gitignore
M  +14   -86   lib/releaseme/cmakeeditor.rb
M  +82   -81   lib/releaseme/documentation.rb
M  +4    -102  test/cmakeeditor_test.rb
A  +1    -0    test/data/l10nrepo/trunk/l10n-kf5/de/docs/extragear-multimedia/amarok/man-amarok.1.docbook
A  +1    -0    test/data/l10nrepo/trunk/l10n-kf5/de/docs/extragear-multimedia/amarok/unicorn/man-unicorn.1.docbook
A  +4    -0    test/data/multi-doc/doc/doc-valid1/CMakeLists.txt
A  +4    -0    test/data/single-pot/doc/CMakeLists.txt
A  +0    -0    test/data/source-with-manpage/CMakeLists.txt
A  +8    -0    test/data/source-with-manpage/Messages.sh
A  +4    -0    test/data/source-with-manpage/doc/CMakeLists.txt
A  +1    -0    test/data/source-with-manpage/doc/man-amarok.1.docbook
A  +4    -0    test/data/source-with-manpage/doc/subdir/CMakeLists.txt
A  +1    -0    test/data/source-with-manpage/doc/subdir/man-unicorn.1.docbook
M  +100  -50   test/documentation_test.rb

https://commits.kde.org/releaseme/d701767a34fc38b24fb5d4379338fc1420f2ef54