Bug 381103 - releaseme should use kdoctools_install
Summary: releaseme should use kdoctools_install
Status: RESOLVED FIXED
Alias: None
Product: releaseme
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Harald Sitter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-11 15:39 UTC by Elvis Angelaccio
Modified: 2017-08-11 09:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elvis Angelaccio 2017-06-11 15:39:14 UTC
kdoctools_install() is the equivalent of ki18n_install() for documentation translations. It enables simpler tarballs with a single po folder containing all the translations (code + documentation).

This would also make releaseme's tarballs consistent with the Applications and Frameworks tarballs.
Comment 1 Harald Sitter 2017-06-12 11:10:56 UTC
Yeah, it's on the todo for ages.
Comment 2 Harald Sitter 2017-08-11 09:58:53 UTC
Git commit d701767a34fc38b24fb5d4379338fc1420f2ef54 by Harald Sitter.
Committed on 10/08/2017 at 10:03.
Pushed by sitter into branch 'master'.

port documentation handling to kdoctools

now that plasma dropped the if conditionals in doc/CMakeLists.txt
requirement we can rely on kdoctools' somewhat less sophisticated
documentation handling. saves us excessive amounts of code with insane
complexity and aligns the source tree more with what frameworks have.

this also gives us "free" manpage support, add some minor branching to
correctly detect and copy manpage docbooks into the final tree. also
new test case to assert the results are well-formed
Related: bug 382550

M  +7    -7    .gitignore
M  +14   -86   lib/releaseme/cmakeeditor.rb
M  +82   -81   lib/releaseme/documentation.rb
M  +4    -102  test/cmakeeditor_test.rb
A  +1    -0    test/data/l10nrepo/trunk/l10n-kf5/de/docs/extragear-multimedia/amarok/man-amarok.1.docbook
A  +1    -0    test/data/l10nrepo/trunk/l10n-kf5/de/docs/extragear-multimedia/amarok/unicorn/man-unicorn.1.docbook
A  +4    -0    test/data/multi-doc/doc/doc-valid1/CMakeLists.txt
A  +4    -0    test/data/single-pot/doc/CMakeLists.txt
A  +0    -0    test/data/source-with-manpage/CMakeLists.txt
A  +8    -0    test/data/source-with-manpage/Messages.sh
A  +4    -0    test/data/source-with-manpage/doc/CMakeLists.txt
A  +1    -0    test/data/source-with-manpage/doc/man-amarok.1.docbook
A  +4    -0    test/data/source-with-manpage/doc/subdir/CMakeLists.txt
A  +1    -0    test/data/source-with-manpage/doc/subdir/man-unicorn.1.docbook
M  +100  -50   test/documentation_test.rb

https://commits.kde.org/releaseme/d701767a34fc38b24fb5d4379338fc1420f2ef54