Bug 380511 - Kirigami 2.2.0 scrolling doesn't work properly for scroll wheels, touchpads, or touchscreens
Summary: Kirigami 2.2.0 scrolling doesn't work properly for scroll wheels, touchpads, ...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR major
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
: 386912 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-06-03 17:15 UTC by Nate Graham
Modified: 2017-11-19 03:16 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-06-03 17:15:56 UTC
Commit e0a623414cfb34df8e3ae717d720f7a0f952b2c8 was introduced to fix https://bugs.kde.org/show_bug.cgi?id=376910. Before this commit, scrolling with a mouse wheel was fine, but scrolling with a touchpad resulted in acceleration being continuously increased.

With commit e0a623414cfb34df8e3ae717d720f7a0f952b2c8, scrolling with both a mouse wheels and a touchpad results in the view scrolling one line at a time at a constant speed.

For a mouse wheel, this is far too slow and ignores the systemwide setting (System Settings > Input Devices > Mouse > Advanced > Mouse wheel scrolls by).

For a touchpad, this is still *effectively* too slow; it should scroll in one-pixel increments, but with the speed determined by the speed of the finger motion.

You can see the problem in Discover on a machine with Kirigami 2.1. The scrolling behavior is poor for both input devices.


It was mentioned in https://bugs.kde.org/show_bug.cgi?id=376910 that the QuickControls ScrollView has the correct behavior for both devices out of the box in QT 5.9 onwards. QT 5.9 was just released a few days ago: http://blog.qt.io/blog/2017/05/31/qt-5-9-released/

Maybe we should redirect our effort to use QT 5.9 which has appropriate behavior rather than try to fix it manually and stay with an old QT version.
Comment 1 Nate Graham 2017-06-03 17:30:33 UTC
Also, now touch doesn't work at all. Drags don't work because the initial finger down movement is interpreted as a click, and no scrolling ever happens.
Comment 2 Alexander Mentyu 2017-08-19 17:04:06 UTC
Not confirming this bug with mouse and touchpad in:

Distribution: KDE neon Developer Edition Unstable Branches live iso 20170813
KDE Plasma Version: 5.10.90
KDE Frameworks Version: 5.37.0
Qt Version: 5.9.1
Kernel Version: 4.10.0-32-generic

normal scrolling and dragging works fine with mouse and touchpad - wasn't tested with touchscreen.
Comment 3 Nate Graham 2017-08-19 17:36:02 UTC
Are you sure, Alexander? The problem isn't that they don't work at all, but that they don't work *correctly.* I just tried again with an up-to-date Neon, which has Discover 5.10.90 and, crucially, Kirigami 2.2.0.

Now, mouse scroll wheel behavior seems fine, but touch scrolling still doesn't work, and two-finger touchpad scrolling still scrolls line-by-line, not pixel-by-pixel.
Comment 4 Nate Graham 2017-08-19 17:47:24 UTC
Actually you're right--sort of. I was testing in a virtual machine that wasn't passing scroll events properly. Here are the results of a proper test:

As of Kirigami 2.2.0, mousewheel scrolling is *still* broken in the way I originally reported: it goes only one line at a time, which is far too slow.

Touchpad scrolling does go pixel-by-pixel, but the acceleration is totally off. It speeds up much, much too quickly.

Touchscreen scrolling is still broken in the way I originally reported.
Comment 5 Alexander Mentyu 2017-08-19 18:02:29 UTC
My bad - i was testing scrolling in Kirigami Gallery only.

With Discover - mouse scrolls works fine and touchpad has one obvious issue for me - in the end of scrolling - scrolled list scrolls fast to the top or to the bottom depending on scroll movement and snaps in place at random height. As for touchpad scroll speed - think very fast and accelerated movement when scrolling with touchpad is not needed in this app.
Comment 6 Nate Graham 2017-08-19 18:26:56 UTC
When you say, "mouse scrolls works fine", do you mean "mouse scrolls a number of lines at a time equal to the value of System Settings > Input Devices > Mouse Advances > Mouse wheel scrolls by: <n lines>"

For me, that value is 3 lines, but in Kirigami, the mouse wheel only scrolls one line at a time. Kirigami is not correctly reading or using that setting.
Comment 7 Alexander Mentyu 2017-08-19 18:58:12 UTC
Yes, scroll speed isn't changing for me too after set different values in Mouse Advanced settings.
Comment 8 Nate Graham 2017-08-19 18:58:49 UTC
OK, so my original issue remains, then.
Comment 9 Nate Graham 2017-10-10 00:04:09 UTC
*** Bug 385534 has been marked as a duplicate of this bug. ***
Comment 10 Nate Graham 2017-10-17 01:59:35 UTC
*** Bug 385836 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2017-10-29 21:28:51 UTC
*** Bug 386326 has been marked as a duplicate of this bug. ***
Comment 12 Nate Graham 2017-10-29 21:29:51 UTC
Marking this as Major, since scroll behavior is pretty critical and this will bite more and more apps as we continue to use Kirigami scrollviews for new development.
Comment 13 Nate Graham 2017-10-30 20:31:35 UTC
*** Bug 381182 has been marked as a duplicate of this bug. ***
Comment 14 Marco Martin 2017-11-03 09:26:20 UTC
is this still happening on master? 
it was supposed to be fixed by 23ca2077027b214189ba72ca8dab1590a163c955 on 3rd october.
note that the fix is about giving it a reasonable speed with scrolling with a touchpad, it is *not* about the number of lines it should scroll according to systemsettings. that is a completely unrelated bug which fixing will be quite problematic
Comment 15 Patrick Silva 2017-11-03 11:29:48 UTC
Scrolling with touchpad is fast in Discover, neon dev unstable.
The problem related in comment 1 is still happening.
Comment 16 Nate Graham 2017-11-04 01:36:35 UTC
Marco, would you like me to close this and file separate bugs about the brokenness on touch screens and inappropriate number of lines scrolled with scroll wheels?
Comment 17 Nate Graham 2017-11-14 20:21:48 UTC
*** Bug 386912 has been marked as a duplicate of this bug. ***
Comment 18 Nate Graham 2017-11-19 03:16:15 UTC
I can confirm that the touchpad scroll behavior has been fixed as of 23ca2077027b214189ba72ca8dab1590a163c955. For anybody who is now experiencing *slow* scroll speed, you are most likely using libinput on Xorg, and that's triggering an upstream Qt bug: https://bugreports.qt.io/browse/QTBUG-59261

If you're still experiencing bad scrolling using Wayland, you're hitting https://bugs.kde.org/show_bug.cgi?id=381182

If you're still experiencing slow scroll speed with a wheel on your mouse, you're hitting https://bugs.kde.org/show_bug.cgi?id=385836