Bug 376910 - Scrolling does not follow system settings
Summary: Scrolling does not follow system settings
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.9.1
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
: 377740 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-25 09:02 UTC by Sascha Zenglein
Modified: 2017-05-04 16:10 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Zenglein 2017-02-25 09:02:19 UTC
Using Discover with a touchpad is not working as expected. Every scrolling input accelerates the page without regard to whether the fingers are lifted or not. 

It also does not follow the system scroll speed which leads to much too fast scroll speeds and coasting even when coasting is disabled.


I don't know if this bug should be filed against Discover or Kirigami, but it's a bit annoying for an Application that wants to be convergent.
Comment 1 Patrick Silva 2017-03-02 14:27:44 UTC
I can confirm fast scrolling on Discover installed from Arch repositories.
Comment 2 Marco Martin 2017-03-10 12:15:44 UTC
does this happen with a plain qml flickable as well?
I think is a qml problem, we should have to override the wheel event with a custom c++ element i fear
Comment 3 Marco Martin 2017-03-10 16:29:11 UTC
Git commit e0a623414cfb34df8e3ae717d720f7a0f952b2c8 by Marco Martin.
Committed on 10/03/2017 at 16:29.
Pushed by mart into branch 'master'.

manage scrollwheel by hand on desktop

Summary:
when on desktop, skip the flickable internal
scrollwheel manah=gement that is completely
broken and manage scrolling by ourselves
with a MouseArea instead

Test Plan:
tried mouse wheel and touchpad two finger
scrolling, both look more sensible now
(how many lines the mouse wheel scrolls
is still to be implemented)
exported QT_QUICK_CONTROLS_MOBILE=true
env var and it works again as before

Reviewers: #kirigami

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D5004

M  +22   -1    src/controls/templates/private/ScrollView.qml

https://commits.kde.org/kirigami/e0a623414cfb34df8e3ae717d720f7a0f952b2c8
Comment 4 Sascha Zenglein 2017-03-11 15:26:14 UTC
Thanks for patching this. Additionally, I want to point you to a new old feature in Qt Quick Controls, the Scrollview. In the description it says it handles both touch and mouse nicely. 

Would it be possible to change to this in the implementation or is it a problem that it depends on Qt 5.9? Of course only after 5.9 is released.


References:
New Features in Qt 5.9: https://wiki.qt.io/New_Features_in_Qt_5.9
Scrollview in QtQuickControls 2: https://doc-snapshots.qt.io/qt5-dev/qml-qtquick-controls2-scrollview.html#details

Do you get a notification if I'm adding another comment now? Who knows...
Comment 5 Aleix Pol 2017-03-14 23:05:39 UTC
We use that already... ^^'
Comment 6 Sascha Zenglein 2017-03-15 11:08:08 UTC
(In reply to Aleix Pol from comment #5)
> We use that already... ^^'

I don't understand. The old Scrollview from Quick Controls 1.4 or do you mean you already changed it in the developer version?

Because I can't use a Scrollview on Quick Controls 2.
Comment 7 Aleix Pol 2017-03-17 18:14:04 UTC
*** Bug 377740 has been marked as a duplicate of this bug. ***
Comment 8 Marco Martin 2017-03-23 16:08:18 UTC
(In reply to Sascha Zenglein from comment #4)
> 
> Would it be possible to change to this in the implementation or is it a
> problem that it depends on Qt 5.9? Of course only after 5.9 is released.


we'll use that eventually, but only after we can depend from Qt 5.9, that will take a while
Comment 9 Nate Graham 2017-03-30 04:14:07 UTC
What version of Discover or Kirigami did this fix make in into? I just updated to discover 5.9.4 and have Kirigami 2.0.0, and the problem remains. Two-finger touchpad scrolling results in the view moving n number of lines at a time, not pixel-by-pixel.
Comment 10 Nate Graham 2017-05-03 20:23:33 UTC
Still not fixed in discover 5.9.5 and kirigami 2.0.0-1.1.
Comment 11 Aleix Pol 2017-05-04 16:07:20 UTC
You need Kirigami 2.1, as this is a new feature.
Comment 12 Nate Graham 2017-05-04 16:10:25 UTC
Thanks for the Info!