Bug 379958 - UI inconsistencies with brush size and opacity sliders
Summary: UI inconsistencies with brush size and opacity sliders
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-17 20:34 UTC by Nicholas LaPointe
Modified: 2018-01-30 10:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas LaPointe 2017-05-17 20:34:24 UTC
When the brush size or opacity sliders are disabled, the shortcuts to modify their values ("[" and "]" or "I" and "O", respectively) still function.

I also noticed some special cases with the smart patch tool:
* The size slider is enabled and the tool itself doesn't seem to make any special usage of the shift key, but shift+drag doesn't work.
* In the conditions of bug 379957, shift+drag will continue to change the brush size on the freehand brush tool even though the slider is disabled.
This isn't much of a problem since it seems like tools which intend to disable the slider don't support shift+drag, but I thought I'd mention it.
Comment 1 Halla Rempt 2017-11-26 13:22:16 UTC
The first bullet point was reported here: https://bugs.kde.org/show_bug.cgi?id=383640...

For the rest, could we expect a patch? :P
Comment 2 Nicholas LaPointe 2018-01-01 03:25:43 UTC
Git commit de42bbe38647815d93be8d440d7000597333a841 by Nicholas LaPointe.
Committed on 01/01/2018 at 03:25.
Pushed by nicholasl into branch 'master'.

Disable the brush size shortcuts when the brush size slider is disabled

Differential Revision: https://phabricator.kde.org/D9279

M  +8    -5    libs/ui/tool/kis_tool_paint.cc

https://commits.kde.org/krita/de42bbe38647815d93be8d440d7000597333a841