Bug 379957 - Smart Patch shortcut issues
Summary: Smart Patch shortcut issues
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-17 20:23 UTC by Nicholas LaPointe
Modified: 2017-07-27 11:37 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas LaPointe 2017-05-17 20:23:30 UTC 
* The shortcut chosen for the tool, Shift+I, conflicts with the default shortcut "Show color selector". If I disable the color selector shortcut, Shift+I still doesn't work.

* The tooltip shown when hovering over the icon for the smart patch tool displays the shortcut as an unusual character, and the text "OpenType support missing for script 32" is printed to the terminal when it appears. This was also noted in bug 379564 (by Quiralta in comment 1) and bug 378557 (by Scott Petrovic, number 3 in their first list).

This is because of the following line (#95) in kis_tool_smart_patch.h:
setShortcut(QKeySequence(Qt::Key_Shift + Qt::Key_I));
Which needs to be
setShortcut(QKeySequence(Qt::SHIFT + Qt::Key_I));

However, the shortcut still doesn't work.
Comment 1 Nicholas LaPointe 2017-07-25 13:32:24 UTC 
*** Bug 382714 has been marked as a duplicate of this bug. ***
Comment 2 Nicholas LaPointe 2017-07-27 11:37:15 UTC 
Closing due to the closure of bug 382714

I'm still a little curious as to why the shortcut didn't work even after resolving the conflict and fixing the QKeySequence; perhaps I simply made a mistake somewhere when I was trying it.