Bug 379691 - Color Sliders (Saturation and Luma) default to 0 when switching between two open documents.
Summary: Color Sliders (Saturation and Luma) default to 0 when switching between two o...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: 3.1.3
Platform: PCLinuxOS Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-10 11:39 UTC by Daulat Neupane
Modified: 2018-06-26 15:10 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/krita/8b366fe6834cf26388266142eeb96a95dd58e72a
Version Fixed In:

Attachments
attachment-22517-0.html (2.98 KB, text/html)
2018-06-24 06:16 UTC, Daulat Neupane 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Daulat Neupane 2017-05-10 11:39:57 UTC 
In the color Slider docker, the saturation and luma sliders default back to 0 when switching between two open documents. And the same sliders don't update the first time a color is picked from the document, right after importing an image or a file.
Comment 1 Halla Rempt 2017-05-10 12:23:57 UTC 
Thanks for the report. I can confirm the issue.
Comment 2 Halla Rempt 2018-06-16 08:20:53 UTC 
Git commit dd434d69ce24cc644322394f4f6184e9600508d5 by Boudewijn Rempt.
Committed on 16/06/2018 at 08:20.
Pushed by rempt into branch 'master'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 352940, bug 395469, bug 385405

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/dd434d69ce24cc644322394f4f6184e9600508d5
Comment 3 Halla Rempt 2018-06-16 08:22:25 UTC 
Git commit e3301f9727c4be2ba9a58172dc53c80d57471b14 by Boudewijn Rempt.
Committed on 16/06/2018 at 08:22.
Pushed by rempt into branch 'krita/4.1'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 352940, bug 395469, bug 385405
(cherry picked from commit 2553aa1e50640a6f757c458b560e2bbb7ca0f239)

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/e3301f9727c4be2ba9a58172dc53c80d57471b14
Comment 4 Daulat Neupane 2018-06-24 06:16:49 UTC 
Created attachment 113532 [details]
attachment-22517-0.html

Thanks for the info on this issue.

Regards,
Daulat

On Sat, Jun 16, 2018 at 1:52 PM Boudewijn Rempt <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=379691
>
> Boudewijn Rempt <boud@valdyas.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>       Latest Commit|https://commits.kde.org/kri |
> https://commits.kde.org/kri
>                    |ta/dd434d69ce24cc644322394f
> |ta/e3301f9727c4be2ba9a58172
>                    |4f6184e9600508d5            |dc53c80d57471b14
>
> --- Comment #3 from Boudewijn Rempt <boud@valdyas.org> ---
> Git commit e3301f9727c4be2ba9a58172dc53c80d57471b14 by Boudewijn Rempt.
> Committed on 16/06/2018 at 08:22.
> Pushed by rempt into branch 'krita/4.1'.
>
> Remove the color slider docker
>
> Since Wolthera notes in bug 352940 that it needs to be rewritten,
> let's remove it for now.
> Related: bug 352940, bug 395469, bug 385405
> (cherry picked from commit 2553aa1e50640a6f757c458b560e2bbb7ca0f239)
>
> M  +0    -1    plugins/dockers/CMakeLists.txt
> D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
> D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
> D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
> D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
> D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
> D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
> D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
> D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
> D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
> D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
> D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
> D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json
>
> https://commits.kde.org/krita/e3301f9727c4be2ba9a58172dc53c80d57471b14
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 5 Andrey 2018-06-26 15:10:10 UTC 
Git commit 8b366fe6834cf26388266142eeb96a95dd58e72a by Andrey Kamakin, on behalf of Boudewijn Rempt.
Committed on 26/06/2018 at 14:18.
Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 352940, bug 395469, bug 385405

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/8b366fe6834cf26388266142eeb96a95dd58e72a