Bug 352940 - Color Sliders docker is broken
Summary: Color Sliders docker is broken
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: 2.9.7
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 359075 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-20 10:45 UTC by romuluspb
Modified: 2018-06-26 15:10 UTC (History)
3 users (show)

See Also:
Latest Commit: https://commits.kde.org/krita/8b366fe6834cf26388266142eeb96a95dd58e72a
Version Fixed In:
Sentry Crash Report:

Attachments
attachment-3373-0.html (2.19 KB, text/html)
2016-02-06 17:25 UTC, Danilo JR 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description romuluspb 2015-09-20 10:45:26 UTC 
It has a diverse number of problems:

1 some times you cant change only one slider, it produce changes in all sliders.
2 trying to insert a numerical value can some times don't work:
  inserting a value x and pressing enter give another value 
3 values set numerically can not only be set wrongly but change after selecting another layer.


Reproducible: Sometimes
Comment 1 wolthera 2016-02-06 17:04:30 UTC 
*** Bug 359075 has been marked as a duplicate of this bug. ***
Comment 2 Danilo JR 2016-02-06 17:13:39 UTC 
Confirmed...      Same issue in krita 2.9.11

https://bugs.kde.org/show_bug.cgi?id=359075
Comment 3 Danilo JR 2016-02-06 17:25:02 UTC 
Created attachment 97051 [details]
attachment-3373-0.html

Hi Wolthera!  Can you chante the status of the bug to confirmed?
Bug 352940 <https://bugs.kde.org/show_bug.cgi?id=352940>



On Sat, Feb 6, 2016 at 2:04 PM, wolthera via KDE Bugzilla <
bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=352940
>
> wolthera <griffinvalley@gmail.com> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |danilojunior@gmail.com
>
> --- Comment #1 from wolthera <griffinvalley@gmail.com> ---
> *** Bug 359075 has been marked as a duplicate of this bug. ***
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>
Comment 4 wolthera 2016-02-06 17:53:34 UTC 
this requires a full rewrite of the color sliders docker. It never worked.
Comment 5 Halla Rempt 2018-06-16 08:20:53 UTC 
Git commit dd434d69ce24cc644322394f4f6184e9600508d5 by Boudewijn Rempt.
Committed on 16/06/2018 at 08:20.
Pushed by rempt into branch 'master'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 395469, bug 385405, bug 379691

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/dd434d69ce24cc644322394f4f6184e9600508d5
Comment 6 Halla Rempt 2018-06-16 08:22:25 UTC 
Git commit e3301f9727c4be2ba9a58172dc53c80d57471b14 by Boudewijn Rempt.
Committed on 16/06/2018 at 08:22.
Pushed by rempt into branch 'krita/4.1'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 395469, bug 385405, bug 379691
(cherry picked from commit 2553aa1e50640a6f757c458b560e2bbb7ca0f239)

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/e3301f9727c4be2ba9a58172dc53c80d57471b14
Comment 7 Andrey 2018-06-26 15:10:46 UTC 
Git commit 8b366fe6834cf26388266142eeb96a95dd58e72a by Andrey Kamakin, on behalf of Boudewijn Rempt.
Committed on 26/06/2018 at 14:18.
Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'.

Remove the color slider docker

Since Wolthera notes in bug 352940 that it needs to be rewritten,
let's remove it for now.
Related: bug 395469, bug 385405, bug 379691

M  +0    -1    plugins/dockers/CMakeLists.txt
D  +0    -13   plugins/dockers/colorslider/CMakeLists.txt
D  +0    -82   plugins/dockers/colorslider/kis_color_slider.cpp
D  +0    -40   plugins/dockers/colorslider/kis_color_slider.h
D  +0    -131  plugins/dockers/colorslider/kis_color_slider_dock.cpp
D  +0    -53   plugins/dockers/colorslider/kis_color_slider_dock.h
D  +0    -709  plugins/dockers/colorslider/kis_color_slider_input.cpp
D  +0    -92   plugins/dockers/colorslider/kis_color_slider_input.h
D  +0    -483  plugins/dockers/colorslider/kis_color_slider_widget.cpp
D  +0    -87   plugins/dockers/colorslider/kis_color_slider_widget.h
D  +0    -268  plugins/dockers/colorslider/kis_hsv_slider.cpp
D  +0    -62   plugins/dockers/colorslider/kis_hsv_slider.h
D  +0    -9    plugins/dockers/colorslider/krita_colorslider.json

https://commits.kde.org/krita/8b366fe6834cf26388266142eeb96a95dd58e72a