Bug 377895 - "Close Description" button has UI/UX issues; should just be a regular back button
Summary: "Close Description" button has UI/UX issues; should just be a regular back bu...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.9.4
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-21 19:23 UTC by Nate Graham
Modified: 2017-09-21 05:32 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.10


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-03-21 19:23:08 UTC
Discover 5.9.3-1.1 with KDE Plasma 5.9.2 on openSUSE Tumbleweed.

Steps to reproduce:
1. Open Discover
2. Resize the window so that it's less than 1202 pixels wide
3. Click "Applications"
4. Click "Developer Tools"
5. Click "Kdevelop"
6. Desire to go back and view the list of developer apps again

Desired result:
There should be a back button somewhere that lets me go back and see the list of developer apps.

Actual results:
There is no apparent way to go back only one level. The Back button in the source list on the left goes back two levels, all the way to the category browser.

Workarounds:
- You can click-and-drag or swipe (if you have a touchscreen) to the right to go back one level. But that's an invisible UI; there is no corresponding visible one.
- Resize the window to be greater than 1201 pixels wide, and the app list becomes always visible, making the problem go away as long as you're willing to make the window really big
Comment 1 Nate Graham 2017-03-30 19:18:28 UTC
The issue persists in Discover 5.9.4.
Comment 2 Aleix Pol 2017-04-13 01:17:23 UTC
Fixed in master, will have a button for that on 5.10.

Thanks for reporting and helping make it happen!
Comment 3 Nate Graham 2017-04-13 15:27:06 UTC
You're very welcome!
Comment 4 Nate Graham 2017-06-03 17:26:21 UTC
I see in 5.10 that there is now a "Close description" button, but this isn't adequate for several reasons:

1. It's in the wrong place: it should be at the top, not the bottom. Back buttons go on top as a standard UI convention.
2. It has an arrow the points to the right, not the left. Back buttons always point to the left.
3. Only the arrow is clickable, not the text. The click/touch area is very small.
4. The text "Close description" is ambiguous. It should just be a regular back button with the word "Back".
Comment 5 Aleix Pol 2017-09-20 14:07:04 UTC
Git commit d6318b0d0df488cb401964e7607d4dc0ea85a21d by Aleix Pol.
Committed on 20/09/2017 at 14:03.
Pushed by apol into branch 'master'.

Add a header into the ApplicationPage

Removes the clashing with the controls when it's compact.
Solves some issues with the current close control

M  +150  -180  discover/qml/ApplicationPage.qml

https://commits.kde.org/discover/d6318b0d0df488cb401964e7607d4dc0ea85a21d
Comment 6 Nate Graham 2017-09-21 05:11:18 UTC
Much better! Just a few remaining niggles, which I'll track individually with new tickets to avoid torturing this poor bug report.

- https://bugs.kde.org/show_bug.cgi?id=384912 [patch submitted]
- https://bugs.kde.org/show_bug.cgi?id=384913
- https://bugs.kde.org/show_bug.cgi?id=384914 [patch submitted]
Comment 7 Nate Graham 2017-09-21 05:28:17 UTC
Also submitted a patch for https://bugs.kde.org/show_bug.cgi?id=384913
Comment 8 Nate Graham 2017-09-21 05:32:22 UTC
One more: https://bugs.kde.org/show_bug.cgi?id=384916