Bug 384914 - [git master] Don't hide Launch button under a hamburger menu
Summary: [git master] Don't hide Launch button under a hamburger menu
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-21 05:00 UTC by Nate Graham
Modified: 2017-09-22 04:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2017-09-21 05:00:24 UTC
With the new top bar added in https://cgit.kde.org/discover.git/commit/?id=d6318b0d0df488cb401964e7607d4dc0ea85a21d, Discover now hides the Launch button behind a hamburger menu, where nobody will ever find it. This is especially odd since the menu only has one item. Let's return it to being a regular button.
Comment 1 Nate Graham 2017-09-21 05:03:48 UTC
Submitted a patch: https://phabricator.kde.org/D7905
Comment 2 Nate Graham 2017-09-22 04:31:02 UTC
Git commit 98c1d5ad33d677d5186217ea9da437913ff907f9 by Nate Graham.
Committed on 22/09/2017 at 04:30.
Pushed by ngraham into branch 'master'.

Remove launch feature from hamburger button and restore to the toolbar

Summary:

Make the Launch feature a button on the toolbar rather than an item in a single-element menu under a hamburger button, where normal users will never see it

Test Plan:
Tested in KDE Neon. Works:

{F3919704}

Reviewers: apol, #discover_software_store

Reviewed By: apol, #discover_software_store

Subscribers: colomar, jensreuterberg, plasma-devel

Tags: #plasma, #discover_software_store

Differential Revision: https://phabricator.kde.org/D7905

M  +3    -8    discover/qml/ApplicationPage.qml

https://commits.kde.org/discover/98c1d5ad33d677d5186217ea9da437913ff907f9