Bug 377157 - [Wayland] It's not possible to take a picture of a rectangle region
Summary: [Wayland] It's not possible to take a picture of a rectangle region
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR major
Target Milestone: ---
Assignee: Boudhayan Gupta
: 383902 387108 404282 (view as bug list)
Depends on:
Reported: 2017-03-03 11:38 UTC by tromzy
Modified: 2019-05-06 21:39 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In: 19.08


Note You need to log in before you can comment on or make changes to this bug.
Description tromzy 2017-03-03 11:38:20 UTC
That's probably more a Kwin_wayland issue, since it's about Wayland ; but in Spectacle, I cannot use the "Rectangle region" to take a picture in a Wayland session. It works fine on X11.
Comment 1 Boudhayan Gupta 2017-03-03 13:29:36 UTC
This feature isn't implemented yet owing to security considerations with the code on Wayland. We should be able to figure this out by the middle of the year.
Comment 2 tromzy 2017-03-03 13:34:25 UTC
Thanks for your answer.
Comment 3 Patrick Silva 2017-11-19 23:56:37 UTC
*** Bug 387108 has been marked as a duplicate of this bug. ***
Comment 4 Patrick Silva 2018-01-23 13:13:19 UTC
same problem with spectacle 17.12.1 + plasma 5.12 beta on Arch Linux.
Comment 5 Fabian Vogt 2018-05-02 09:48:07 UTC
kwin has a dbus interface to do this, so #c1 is wrong (at least now).
Comment 6 Alexander Mentyu 2018-07-13 13:39:48 UTC
*** Bug 383902 has been marked as a duplicate of this bug. ***
Comment 7 Alexander Mentyu 2018-07-13 13:42:06 UTC
And this one is also looks like a duplicate - https://bugs.kde.org/show_bug.cgi?id=387721
Comment 8 Nate Graham 2018-07-13 13:44:39 UTC
Not a duplicate, but this bug depends on that.
Comment 9 Aleix Pol 2018-11-22 16:09:46 UTC
Git commit 053e903727138c30609b9cc92aeeab46101b148f by Aleix Pol.
Committed on 22/11/2018 at 16:07.
Pushed by apol into branch 'master'.

Don't advertise on Wayland features that aren't available

It's quite stressful and it clearly doesn't push developers to implement the features.
Related: bug 386271

Test Plan: Now I don't choose to take a screenshot of the active window and get sad when I can't.

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: hein, ngraham, #spectacle

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D17082

M  +3    -3    src/Gui/KSMainWindow.cpp
M  +1    -1    src/Gui/KSMainWindow.h
M  +13   -7    src/Gui/KSWidget.cpp
M  +1    -1    src/Gui/KSWidget.h
M  +1    -0    src/PlatformBackends/DummyImageGrabber.h
M  +1    -0    src/PlatformBackends/ImageGrabber.h
M  +1    -0    src/PlatformBackends/KWinWaylandImageGrabber.h
M  +1    -0    src/PlatformBackends/X11ImageGrabber.h
M  +1    -1    src/SpectacleConfig.cpp
M  +1    -1    src/SpectacleCore.cpp

Comment 10 Patrick Silva 2019-02-13 12:14:45 UTC
*** Bug 404282 has been marked as a duplicate of this bug. ***
Comment 11 Boudhayan Gupta 2019-05-06 21:20:38 UTC
This was fixed in the branch "bgupta/platform-backend-refactor" (https://cgit.kde.org/spectacle.git/log/?h=bgupta/platform-backend-refactor) which was merged to master with commit 4fb5f57786f9fe3f04857ef893dd0603c34025d6.