[I'm closing my former bugreport and reopening another one as it was not assigned properly] When using a custom icon, previews and especially folders previews being enabled, if the directory contains pictures, the directory icon is replaced by the default folder icon. Reproducible: Always Steps to Reproduce: 1. Create a directory and put a couple of pictures inside of it. 2. In Dolphin settings, make sure thumbnails are enabled for directories 3. Switch the view mode to icons and enable previews 4. Change the icon of the directory with a custom one (any icon from the default set will do : for instance folder-videos) Actual Results: The icon of the created directory will display previews of pictures it contains, over the default folder icon. Expected Results: The icon of the created directory should consist of the pictures previews above the custom icon selected beforehand. Using KDE Neon LTS ; KDE Framework 5.30.
I'm pasting Rog's comment on my preview bugreport which I'm about to close : By my knowledge the kio-extras. Folder thumbnailing is using the icon theme directory icon. ie: https://cgit.kde.org/kio-extras.git/ -> /kio-extras/thumbnail/thumbnail.cpp has, from line 466: //Use the current (custom) folder icon const QMimeDatabase db; const QString iconName = db.mimeTypeForName("inode/directory").iconName(); const QPixmap folder = QIcon::fromTheme(iconName).pixmap(qMin(m_width, m_height));
*** Bug 370247 has been marked as a duplicate of this bug. ***
*** Bug 321856 has been marked as a duplicate of this bug. ***
I can reproduce this issue. The thumbnail protocol should read the custom icon name, which is stored by kio in the .directory file of the folder being 'thumbnailed'.
https://phabricator.kde.org/D4222
Git commit 2524fc27f31af744b0d8bfbb7662ab5f2bd13ec0 by Kai Uwe Broulik. Committed on 24/01/2017 at 11:11. Pushed by broulik into branch 'master'. [Folder thumbnailer] Use custom folder icon if set CHANGELOG: Folder thumbnails now respect custom folder icons Differential Revision: https://phabricator.kde.org/D4222 M +4 -6 thumbnail/thumbnail.cpp https://commits.kde.org/kio-extras/2524fc27f31af744b0d8bfbb7662ab5f2bd13ec0
What a quick fix ! Thank you, you made my day :-)
Thanks for your investigation, was the right spot in the code you found :)
I just bothered the right persons ;) Rog came up with the location of the issue.
Hi ! I just upgraded KDE Frameworks to version 5.31.0 (KDE Neon LTS) and it seems this bugfix is not included in this version. Is it supposed to ? Cheers !
Hmm, it seems kio is part ofr KDE Frameworks but kio-extras seems to be part of KDE Applications. Version 16.12.2 of KDE apps doesn't seem to include this fix. I'll be patient, sorry for bothering ;)
Hi ! Really sorry for bothering again, but it seems the fix didn't make it to KDE apps 16.12.3.
(In reply to Mahendra Tallur from comment #12) > Hi ! Really sorry for bothering again, but it seems the fix didn't make it > to KDE apps 16.12.3. I mean, I just upgraded to KDE apps 16.12.3 (in KDE Neon LTS), logged out, logged back in, browsed directories in Dolphin in "thumbnails mode". Custom icons are shown for a couple of seconds then replaced by the default ones when the directory previews are shown.
@Mahendra: you may want to delete your thumbnail cache folders: ~/.cache/thumbnails/large and ~/.cache/thumbnails/normal
With the Arch Linux. Comparing source of kio-extras 16.12.3-1 and kio-extras master. The https://cgit.kde.org/kio-extras.git/commit/?id=2524fc27f31af744b0d8bfbb7662ab5f2bd13ec0 is not in the kio-extras 16.12.3.
Ah right, it seems the fix was committed on master only.