Bug 374905 - new network manager configuration model is unreadable
Summary: new network manager configuration model is unreadable
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_networkmanagement (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Lukáš Tinkl
URL:
Keywords:
: 374976 375058 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-01-11 09:40 UTC by John Salatas
Modified: 2024-12-23 18:27 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Network Connections List (46.17 KB, image/png)
2017-01-11 09:40 UTC, John Salatas
Details
New Network Connection (81.68 KB, image/png)
2017-01-11 09:41 UTC, John Salatas
Details
Patch to fix unreadable items in new network manager configuration model (645 bytes, patch)
2017-01-11 22:33 UTC, John Salatas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Salatas 2017-01-11 09:40:37 UTC
Created attachment 103346 [details]
Network Connections List

I'm using Breeze light application schemeand Breeze Dark desktop theme and under this combination the new network manager configuration model is unreadable (see atrtached screenshots).
Comment 1 John Salatas 2017-01-11 09:41:15 UTC
Created attachment 103347 [details]
New Network Connection
Comment 2 Jan Grulich 2017-01-11 10:19:26 UTC
I don't think there is anything I can do, I use standard colors from both like plasma theme and application colors. I bet you have similar problem with KCM for windows decoration or with KScreen KCM.
Comment 3 John Salatas 2017-01-11 10:35:40 UTC
Hmmm..... it doesn't seem that I have similar issues elsewhere. :\

However it reminds me a similar issue that I had with the kickoff configuration buttons: 

https://phabricator.kde.org/D2900
and 
https://phabricator.kde.org/D2884

Is this qml related? If so, maybe I can have a look at it. I'm not too comfortable with C++ code yet :(
Comment 4 Jan Grulich 2017-01-11 10:56:17 UTC
Yes it is QML related, you can find the part you are interested in kcm/qml directory.
Comment 5 John Salatas 2017-01-11 22:33:22 UTC
Created attachment 103362 [details]
Patch to fix unreadable items in new network manager configuration model

Please have a look at the attached patch. It seems that it correctly handles all cases of scheme/desktop theme combinations, although the result isn't (always) aesthetically pleasant :\
Comment 6 Jan Grulich 2017-01-12 13:08:18 UTC
I tried it with both breeze light (theme + app color) and breeze dark (theme + app color) and I don't like any of them. Better would be to discuss this with other plasma people on plasma-devel + with VDG I guess.
Comment 7 John Salatas 2017-01-12 18:38:53 UTC
OK. I guess we need to create a differential review in phabricator...
Comment 8 Jan Grulich 2017-01-13 07:21:47 UTC
*** Bug 374976 has been marked as a duplicate of this bug. ***
Comment 9 John Salatas 2017-01-16 00:02:08 UTC
*** Bug 375058 has been marked as a duplicate of this bug. ***
Comment 10 Jan Grulich 2017-01-16 06:02:10 UTC
John, can you please post your patch as review in phabricator?
Comment 11 John Salatas 2017-01-16 07:26:13 UTC
Review created https://phabricator.kde.org/D4153
Comment 12 Jan Grulich 2017-01-16 09:17:09 UTC
Git commit e0e8f0608af1910885a7a011b082d533e1fd3c46 by Jan Grulich.
Committed on 16/01/2017 at 09:17.
Pushed by grulich into branch 'master'.

KCM: Do not use Plasma components as the colors are not consistent

M  +1    -0    kcm/CMakeLists.txt
M  +5    -0    kcm/kcm.cpp
M  +8    -6    kcm/qml/ConnectionItem.qml
M  +12   -13   kcm/qml/Dialog.qml
M  +3    -2    kcm/qml/Header.qml
A  +93   -0    kcm/qml/ListItem.qml     [License: LGPL]
M  +9    -13   kcm/qml/main.qml

https://commits.kde.org/plasma-nm/e0e8f0608af1910885a7a011b082d533e1fd3c46
Comment 13 Jan Grulich 2017-01-16 09:17:41 UTC
Git commit 9351665935c1b01a27415926ac4c85c9329f133a by Jan Grulich.
Committed on 16/01/2017 at 09:17.
Pushed by grulich into branch 'Plasma/5.9'.

KCM: Do not use Plasma components as the colors are not consistent

M  +1    -0    kcm/CMakeLists.txt
M  +5    -0    kcm/kcm.cpp
M  +8    -6    kcm/qml/ConnectionItem.qml
M  +12   -13   kcm/qml/Dialog.qml
M  +3    -2    kcm/qml/Header.qml
A  +93   -0    kcm/qml/ListItem.qml     [License: LGPL]
M  +9    -13   kcm/qml/main.qml

https://commits.kde.org/plasma-nm/9351665935c1b01a27415926ac4c85c9329f133a