Bug 374091 - Theme application menu icons combine theme with icon theme.
Summary: Theme application menu icons combine theme with icon theme.
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: 5.4.0
Platform: Microsoft Windows Microsoft Windows
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-23 17:25 UTC by Geoff King
Modified: 2019-08-31 16:16 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff King 2016-12-23 17:25:34 UTC
I switched to the "ShadeOfGray" theme.  When using  this theme some menu icons were too light and could not be seen as is, so I found the configure>miscellaneous entry for Icon Theme and changed that to "Breeze Dark".  Nice!  All is good now. 

However, maybe you could make it a little easier by including both the Theme and the Icon Theme in the same menu or same configuration page?  Or provide a popup hint reminder to also change Icon Theme when changing the theme?  Or even change them together with a Theme entry of "Shade of Gray using Breeze Dark (restart required)"
A minor issue, but though I would point it out since it took me a while to figure this out again. It does look good now.
Comment 1 caulier.gilles 2017-01-21 11:45:11 UTC
Geoff,

Perhaps we need to make a map of suitable color themes and icon themes.

Can you provide a list of valid combinaisons ?

Of course, if we go in this direction, we can only provide color theme options in main menu. Icon theme will be selected automatically with this option and Setup/misc/Icon theme combobox must be removed.

Your viewpoint ?

Gilles Caulier
Comment 2 Geoff King 2017-01-23 21:30:48 UTC
I like the idea of combining the two.  I think it would be a good simplification to have these settings in the same place or combined.  I have a couple suggestions depending on the OS used (Mac or Windows).  These could be considered separate, but I'll group here for now as they are interrelated.

For Mac 10.11:
-On Mac the background of the system menus (for example the Browse menu at top of screen) always remain the same gray color, regardless of the theme or icons selected [this is different than on Windows].  The icon colors do affect the colors in these menus and the "Breeze Dark" icons are too light (white on gray).  So the Mac version should always use icons and text that have a dark color such as "Breeze" in these menus regardless of other settings.
-The icons and text in the GUI (Such as Properties on the right side or Albums on the left)  are dependent on the selected color theme and icon scheme.  Below is a map of recommended Themes combined with Icons to use in the GUI

Mac :
Theme Name - GUI Icons 
Default - Breeze 
Black Body - Breeze Dark 
Color Contrast - Breeze Dark
Dark Room - Breeze Dark 
Gray Card - Breeze Dark 
High Key - Breeze 
Low  Key - Breeze Dark 
Shade Of  Gray - Breeze Dark 
Sunset Color - Breeze Dark 
White Balance - Breeze 

Windows:
This is a little different.  All the menus have the same color background.  So the same matrix of themes and icons can be used for all.. You could use the same map list as above.

Additionally I've adjusted the names below so that they all have spaces in them (can report a separate bug for this if you like)
Comment 3 Simon 2017-03-27 07:56:35 UTC
*** Bug 378116 has been marked as a duplicate of this bug. ***
Comment 4 Maik Qualmann 2017-07-15 16:26:40 UTC
*** Bug 382366 has been marked as a duplicate of this bug. ***
Comment 5 Maik Qualmann 2019-08-31 16:16:12 UTC
Git commit 68aa10b6330956c0358854775b191136c949eac3 by Maik Qualmann.
Committed on 31/08/2019 at 16:14.
Pushed by mqualmann into branch 'master'.

automatically choose the right icon theme for the color scheme
Related: bug 411289, bug 409084
FIXED-IN: 6.3.0

M  +4    -1    NEWS
M  +39   -0    core/libs/settings/applicationsettings_miscs.cpp

https://invent.kde.org/kde/digikam/commit/68aa10b6330956c0358854775b191136c949eac3