Bug 373824 - Konqueror 16.12 is missing the sidebar
Summary: Konqueror 16.12 is missing the sidebar
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: sidebar (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Raphael Rosch
URL:
Keywords:
: 366762 373866 383357 385497 392486 403165 (view as bug list)
Depends on:
Blocks: 110263 177642
  Show dependency treegraph
 
Reported: 2016-12-18 13:59 UTC by avlas
Modified: 2020-10-27 17:57 UTC (History)
17 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description avlas 2016-12-18 13:59:42 UTC
As far as I can see, Konqueror's sidebar is missing in 16.12 version
Comment 1 David Rosenstrauch 2016-12-20 03:33:35 UTC
You're talking about the left pane / sidebar, correct?  If so, then yeah, I can confirm it's missing from v16.12 (on Arch Linux).  That really sucks - I rely on that feature a lot.  (And Konqueror is pretty useless as a file manager without it.)  I do hope this is just a small bug/oversight and is something that can be fixed soon.
Comment 2 avlas 2016-12-20 14:47:10 UTC
I also use the sidebar a lot, especially to check history and bookmarks, or explore and open files, etc.

Let's keep it positive though, and hope the developers will port the sidebar in KDE Applications 17.04 :)
Comment 3 David Faure 2016-12-20 15:09:50 UTC
The sidebar was still using Qt3Support (which doesn't exist in Qt5), and was full of cruft, I had to kill it.

Dolphin is the file manager with a file-management sidebar. I mostly see konqueror as a universal browser now (web, pdf, etc.). This part isn't open to debate unless someone steps up to maintain the file-management parts of it, I won't.

History is indeed missing, we'll have to find another way to visualize it.

Bookmarks are in the menu and in keditbookmarks, is a third view useful? Firefox has pretty much the same two views, right? (popup menu and full tree). I won't work on a bookmarks sidebar in any case, I loved writing keditbookmarks but I don't actually use bookmarks myself - I memorize URLs instead ;-)

On the other hand I want firefox-like completion in the location bar.

PS: "the developers" (plural) is wishful thinking. Konqueror has 0.01 developer right now (me, with a very low priority for konqueror).
Comment 4 avlas 2016-12-20 15:40:22 UTC
Hi David, 

Thanks for your work. Your dedicated time to Konqueror is very much appreciated by some, although I guess a minority of, users, definitely including me.

Re bookmarks: I have many and having them as a popup is sort of annoying. I rather like the sidebar as I can scroll through them (or search in a search box, although I don't recall now if the search box was available in bookmarks or only in history) and edit/delete them with right click, which is far less annoying. If that is not an option I will have to delete a bunch of bookmarks so the popup ends up being useful again :)

Re: history: Same thing, having it in the sidebar is nice, for the same reasons above would be nice.

Re: other sidebar components: to be frank I use them less frequently as dolphin is my default file browser application. It would be nice to have it, but I understand it would require a lot of effort.

Re: firefox-like completion in the location bar: Cool!

Not that I have much time available, and I don't know much on how to work with kde libraries, but at some point I would like to contribute a bit to maintain Konqueror. I will download the code and will take a look...
Comment 5 avlas 2016-12-20 15:49:16 UTC
Just to be clear, I wish most kde users would see how cool Konqueror is (and how much it could be with some love).
Comment 6 Christoph Feck 2016-12-20 17:53:34 UTC
*** Bug 373866 has been marked as a duplicate of this bug. ***
Comment 7 Cochise César 2016-12-23 20:59:20 UTC
Ths sidebar itself is a feature, I think is important. And inside the sidebar we can have extensions/plugins/watheraver, and it is up to community making tis extensions. 
Can you point where are the sidebar code right now? I wanto to see if it is hard to port to kf5.
Thanks.
Comment 8 David Faure 2016-12-24 13:29:53 UTC
The code is actually still there in the konqueror git repo.

`git clone git://anongit.kde.org/konqueror` if you don't have a KDE identity account.

I'm not convinced that the current sidebar is the best solution for the long term though, nor that there really are extensions/plugins available for it, what did you have in mind?
Comment 9 Cochise César 2016-12-25 05:18:52 UTC
After seeing the actual code, it is a relatively small codebase (5,1 kloc) and is highly modular, so porting it to frameworks five is a activity I can pick. Maybe I can fix the base and the history plugin for the next release.
But I not able to discuss what would be he best solution in long term.
Comment 10 Burkhard Lück 2017-01-16 07:55:27 UTC
*** Bug 366762 has been marked as a duplicate of this bug. ***
Comment 11 Alex6 2017-03-14 09:55:25 UTC
(In reply to David Faure from comment #3)

> 
> Dolphin is the file manager with a file-management sidebar. I mostly see
> konqueror as a universal browser now (web, pdf, etc.). This part isn't open
> to debate unless someone steps up to maintain the file-management parts of
> it, I won't.
> 

Never understood the reason of Dolphins existence (copy other file browsers?)
Now Dolphin has not yet the features of Konqueror Kde 3 version...
Try to use webdav and web browser and file browser in the same Dolphin splitted window!

> PS: "the developers" (plural) is wishful thinking. Konqueror has 0.01
> developer right now (me, with a very low priority for konqueror).

Alas, I know!
Comment 12 electrovesta 2017-04-24 22:14:05 UTC
*** This bug has been confirmed by popular vote. ***
Comment 13 David Faure 2017-06-12 08:15:00 UTC
So it seems there are still konqueror users and they are missing the sidebar ;-)

But before anyone recreates anything... which sidebar modules exactly are you missing, and do they *have* to be in a sidebar?

E.g. the history module could be a separate window, so that more width if available to read titles and URLs.

On the other hand, the folder tree is only useful as a sidebar, but that's pure file management, for which I still think/hope that Dolphin is better suited (and if not, I encourage you to report Dolphin bugs/wishes). Unless... could it be that the main use of "webdav and web browser and file browser in one window" is web development?
Comment 14 avlas 2017-06-12 16:31:45 UTC
(In reply to David Faure from comment #13)
> So it seems there are still konqueror users and they are missing the sidebar
> ;-)
> 
> But before anyone recreates anything... which sidebar modules exactly are
> you missing, and do they *have* to be in a sidebar?
> 
> E.g. the history module could be a separate window, so that more width if
> available to read titles and URLs.
> 
> On the other hand, the folder tree is only useful as a sidebar, but that's
> pure file management, for which I still think/hope that Dolphin is better
> suited (and if not, I encourage you to report Dolphin bugs/wishes).
> Unless... could it be that the main use of "webdav and web browser and file
> browser in one window" is web development?

As far as I recall (after all these months my memory fades out...), I used it for these three things:

1- filter webpages from history
2- filter webpages from bookmarks
- browse files

I cannot recall any other options that were available in the sidebar, my bad :/

Regarding 1 and 2, please note that although extra windows give more room to see things, extra windows are also more annoying (at least for some of us), so it's not bad to activate them via ctrl+h or whatever when we really want/need this, but at least for me, the sidebar always helped me to find things in the best way.

Regarding 3, I, for one, use dolphin as my default file browser and I'm very happy with it, but sometimes while browsing you want to access a file or download to a path, and doing so via the sidebar instead of opening an extra application, may be good. This is also a good option when Konqueror is used to visualize e.g. svg's (my default way to see these files), so you can browse via the sidebar and open them in the same window.

I am sure other people can contribute to this with more examples...
Comment 15 David Rosenstrauch 2017-06-12 17:35:59 UTC
I was using it to display the folder tree in Konqueror's left pane.

However, since I read here that the sidebar wasn't going to be supported any more, I've started using Thunar.
Comment 16 Alex6 2017-06-12 20:20:58 UTC
Only treeview in Dolphin.
No bookmarks (web/filesystem) in Dolphin.
No web in Dolphin.
Now, no root action in Dolphin.
5 years work to destroy konqueror, to make something worse, 5 years wasted work?
Thunar is not KDE!
Comment 17 David Faure 2017-06-14 11:12:55 UTC
Alex6: please remain constructive, I'm offering to spend some of my *free* time recreating the most needed features. Nobody destroyed anything intentionally, the old sidebar was based on Qt3Support which doesn't exist in Qt5, so it had to be rewritten no matter what, with the Qt5 port. I'm just offering to take a step back and think about the best new way to offer these features, rather than just blindly recreating the old sidebar "as is".

David Rosenstrauch: if the folder tree was the only feature you're missing, Dolphin would do the job, right?

avlas: thanks, that's useful feedback.
Comment 18 avlas 2017-06-14 12:38:52 UTC
(In reply to David Faure from comment #17)
> Alex6: please remain constructive, I'm offering to spend some of my *free*
> time recreating the most needed features. Nobody destroyed anything
> intentionally, the old sidebar was based on Qt3Support which doesn't exist
> in Qt5, so it had to be rewritten no matter what, with the Qt5 port. I'm
> just offering to take a step back and think about the best new way to offer
> these features, rather than just blindly recreating the old sidebar "as is".
> 
> David Rosenstrauch: if the folder tree was the only feature you're missing,
> Dolphin would do the job, right?
> 
> avlas: thanks, that's useful feedback.

Thanks to you for willing to port the sidebar in the best way possible to Qt5. It's very much appreciated :)
Comment 19 Alex6 2017-06-14 16:51:30 UTC
There was no anticonstructivism in my comments (on the contrary!) to the people who try to rebuild Konqueror. Thanks, David Faure (and eventual coworkers) !!!

But, it's true, a little caustic concerning the decision to "kill" konqueror and spend work to write a kde-thunar with less features...
Comment 20 ocumo 2017-06-16 19:33:31 UTC
I must join those who very strongly miss and need back the left pane tree view in konqueror.

Dolphin is in my opinion and for my workflow way inferior to konqueror. I never was able to stick to Dolphin although I have been trying it each time there is a new major release, ever since it was first created, ages ago. It is in much aspects bloatware that misses fundamental file management features, such as... the side tree view, which for many people is fundamental in their way to work, like in my case, since so many years of computing.

And like someone said before, Thunar is not KDE, and though nice, it lacks a lot of things that a good file manager like konqueror offers. So, all in all, we are going backwards and are loosing a lot if we loose konqueror.

I feel sorry for the difficulties that the only developer for konqueror has had and can only hope that good people like  @Cochise César can help. Being myself a developer, I don't develop in C++ so I couldn't help, as much as I would like to.

Thanks for all the efforts and good will, nevertheless!
Comment 21 ocumo 2017-06-16 19:40:11 UTC
Oh, and I must add: one of the MAJOR features that konqueror has (until now) is the magnificent splitting feature. Dolphin doesn't even get close to that, because only splits once and vertically. How come this is not obviously a hugely useful feature that Dolphin should have, as file tree side pane, etc., and still Dolphin is the "chosen" one? Basically what we need, then, is that Dolphin becomes konqueror, and then Dolphin will be nice.  How crazy is that?
Comment 22 David Rosenstrauch 2017-06-16 19:56:11 UTC
(In reply to David Faure from comment #17)
> David Rosenstrauch: if the folder tree was the only feature you're missing,
> Dolphin would do the job, right?

Nominally.  Though being able to have Konqueror show the folder tree using the Home Folder as the root in the left pane is an extremely useful additional feature to support.  (See http://darose.net/KonquerorUnderKDE.png vs. http://darose.net/Dolphin.png)  Thunar supports that feature btw.  (See http://darose.net/Thunar.png)
Comment 23 Cochise César 2017-06-16 21:01:33 UTC
Alex6:
WebDAV is implemented in KIO level, not in Dolphin or Konqueror, so, any KDE application have WebDAV support. You can use multiple tabs and split each tab in dolphin. The only resource not supported is rendering HTML interfaces. 

Everyone complaining about Dolphin:
Dolphin is light, just as a file manager needs to be. (https://my.mixtape.moe/prebrn.png) It not aims to replace Konqueror for power users, but to be usable for "average users". The focus is not web, but file search integration. It was born in KDE 4.0 days and when "semantik desktop" was the aim.
As KHTML and QtWebKit started to lack behind other browser engines Konqueror lost traction, not only as a web browser, but as file manager. As free software, is up to users to fix it.
=========================
As a little contribution to the discussion: 

There is a History dialog and Bookmarks bar, menu and dialog. What are the sidebar advantages?

There are KIOs for file creation history (recentdocuments://) and access history (timeline://).
Maybe the best way to solve this is create a KIO for web bookmarks and other for web history and make a sidebar capable of interacting with any KIO, so this data wold be system accessible and the KIOs used in Dolphin would be available em Konqueror took.
Comment 24 ocumo 2017-06-20 11:19:29 UTC
@Cochise César
"What are the sidebar advantages?"

Again. Just to repeat one of them: tree view.
And again: not just the sidebar, but also this: Multiple splitting.

Things like that have nothing to do with "power users". It's not correct to reduce this kind of healthy conversation to "power users" vs. "weak users" or whatever label is the current trend. That is so false and negative.

Having the chance to look the tree in which one is and navigate it trivially with a single click, as opposed to "remember" where one is on his tree, has nothing to do with "power". If anything, the opposite: it actually has to do with the "lack of power" to memorize where on earth is this folder in relation with my other folders.

It has been well explained here by the developer, that the feature was not "removed" because some kind of whim; it was a necessity due to obsolescence of whatever library that was necessary to implement it, which is way, way far different to imply that this is some kind of "evolutionary decision". No: it's a bad consequence of a number of unrelated problems, as explained above.

For the record, neither History dialog, Bookmarks bar, and so on have anything to do with side tree view (and/or multiple splitting features for that matter) and hardly could ever be compared in function with that.

Also, it's a bit disrespectful to imply that because someone doesn't use (or doesn't know or understand) a feature, that feature is "useless", ergo those that use it are wrong in doing so. This type of argumentation wrongly compartmentalize the opinions into false "sides" that don't exist.

One thing seems to be clear and we agree: Dolphin is clearly not a replacement for Konqueror, it's something else, it has its place, but it has nothing to do with power or no power.

In fact, as I see it, Dolphin is actually more difficult to use, and less friendly, because it lacks things that make it easier for me to manage, see and understand my file system in a graphical way, in a glance without so many clicks that hurt my arm's extensor muscles so much (typing with a pack of ice attached to your elbow is not nice).

So, actually it's all about making life of users easier, not the opposite. And while I am fine working with just the command line, my bash or python scripts when I need it, that doesn't mean that I don't like to have a GUI that's easy and functional too, like old konqueror.  I shouldn't need to be firing bash commands to have a glance at my directory trees, or to program myself my own thing to accomplish that. And others, whom are not so "powerful", may not be so lucky.
Comment 25 Cochise César 2017-06-20 18:07:15 UTC
(In reply to ocumo from comment #24)
> "What are the sidebar advantages?"
> Again. Just to repeat one of them: tree view.
> And again: not just the sidebar, but also this: Multiple splitting.
Then, let me be more clear: "What are the advantages of *bookmarks/history* in sidebar over the other views?" 
Tree view is for file system hierarchy, so your answer is out of the scope of my question.
I can think in some:
- consistency with other browsers
- easy of access

> For the record, neither History dialog, Bookmarks bar, and so on have
> anything to do with side tree view.
The bug is about the sidebar, not only about the tree view plugin. The sidebar have also plugins for History and Bookmarks.
Comment 26 avlas 2017-06-20 18:25:20 UTC
I gave reasons above of why I prefer history and bookmarks on a sidebar, so I won't repeat myself... I guess you disagree on those, but I think they are valid reasons, and wish they will be considered, and hopefully implemented at some point. I don't think having this extra functionality would hurt (and for some of us at least it would be very helpful).

Regarding the folder tree. I wish it could be possible to not only show the tree of folders but also to (optionally) show files as well. This way, I could, for instance, browse within a folder of svg files in the sidebar and show them in tabs in the main window.
Comment 27 David Faure 2017-06-22 08:37:02 UTC
Note that you can achieve "a tree of files" and viewing SVGs from that tree, without a sidebar.

* Switch to tree-of-files in the main view
* View / Lock to current location
* Window / "Split view Left/Right"
* Click on the "link" checkbox in the statusbar

Now when you click on a file in the left pane, it will be viewed in the right pane.

This is one of the greatest features of Konqueror IMHO, but I don't know how to make easier to find / set up.
But that's an unrelated discussion, let's not go there.

For now it's a workaround for the lack of folder-tree-in-sidebar.

OK, so the argument "we don't need a folder tree sidebar in konqueror because there's one in Dolphin" doesn't convince all users, because they miss infinite-splitting in Dolphin. Which gives two solutions: 1) implementing infinite-splitting in Dolphin, 2) having a folder tree sidebar again in Konqueror. The downside of option 1 is that the above link-and-lock feature doesn't exist in Dolphin, of course.
Comment 28 avlas 2017-06-23 10:55:02 UTC
(In reply to David Faure from comment #27)
> Note that you can achieve "a tree of files" and viewing SVGs from that tree,
> without a sidebar.
> 
> * Switch to tree-of-files in the main view
> * View / Lock to current location
> * Window / "Split view Left/Right"
> * Click on the "link" checkbox in the statusbar
> 
> Now when you click on a file in the left pane, it will be viewed in the
> right pane.
> 
> This is one of the greatest features of Konqueror IMHO, but I don't know how
> to make easier to find / set up.

Nice trick, didn't know about... thanks! (Actually depending on how hierarchically long is the folder tree, one can also split the view horizontaly; but yes, this doesn't really belong here).
Comment 29 ocumo 2017-06-27 01:42:07 UTC
(In reply to Cochise César from comment #25)

Thank you for the clarification. Sorry if I misunderstood you. In essence, we are basically all in agreement of the needs and the difficulties to fulfill all of them to the satisfaction of everyone, so honestly I don't recognize dispute here, just wishes of improvements. I must emphasize my gratitude to the developers of all these nice tools, (including Dolphin!) despite the challenges. Also, big thanks to David Faure for his good tips.
Comment 30 Drazen Tomic 2017-08-30 14:04:36 UTC
Thank you David Faure!

I solved my problem with
1.) Creating a root folder "a" and linking into what ever I need as short cut
2.) (as David explained) "View / Lock to current location" and "link"
3.) Create all the needed Konqueror windows for each activity and save those as "Session" (File > Sessions)

Et voilà :) Not perfect, but it's working.

Konqueror is great!
Comment 31 Christoph Feck 2017-09-06 20:55:05 UTC
*** Bug 383357 has been marked as a duplicate of this bug. ***
Comment 32 Christoph Feck 2017-10-12 18:20:05 UTC
*** Bug 385497 has been marked as a duplicate of this bug. ***
Comment 33 davejplater@gmail.com 2017-11-02 06:13:11 UTC
I'm also someone who was very disappointed when the sidebar disappeared from konqueror. I also don't like dolphin and my most used file manager is Midnight Commander. If I require a file manager gui I use konqueror and it's a fantastic man and info page browser and (don't know what was called) the services browser in the sidebar was also useful. I mainly used the file tree part of the sidebar it gives flexibility when choosing directories but I cope without it.
I've removed dolphin file manager from the start menu and replaced it with konqueror  --open-session fmngr since dolphin's appearance as the default. I also managed to import all the kde4 konqueror bookmarks etc when it switched to kf5, would have been nice to have had instructions.
+1 to konqueror being a first class file manager with network capabilities.
Comment 34 Christoph Feck 2018-04-26 23:00:01 UTC
*** Bug 392486 has been marked as a duplicate of this bug. ***
Comment 35 Christoph Feck 2019-02-08 15:56:20 UTC
*** Bug 403165 has been marked as a duplicate of this bug. ***
Comment 36 Raphael Rosch 2019-06-24 01:53:43 UTC
It is summer 2019, and I was just forced to do a big upgrade on my machine, and find myself running into this bug. I'm not sure if there has been any coding underway to bring back the sidebar, but I would like to drop my 2 cents:

1- Konqueror is THE killer app. There is no other app I rely on more for my productivity than Konqueror. I use gnome (well, Mate, technically as of last year or so) and have been using Konqueror as my file browser since the KDE 3.5 days, I believe. Nothing, nothing at all comes close to what Konqueror does. I personally don't use it as a browser except under really dire circumstances when all other browsers (chrome, firefox) are completely broken and unusable, ie, only in emergencies. So the browser functionality was only ever just extra for me. I can't say it enough, Konqueror always stood as everything I needed in a file manager and more. It's always the first app I make sure to have installed if I need to do anything graphical (as opposed to text/cli). So my hat is firmly tipped to you, David Faure, and anyone else that contributed code.

2- To answer the question of how we use the sidebar: Besides the already mentioned "tree view" (which I couldn't figure out how to do the workaround you suggest), for the reasons already mentioned (ie: incredibly fast and efficient file navigation), I use the sidebar to do mounts of USB drives or removables (SATA removable drives). All I have ("had" .. *cry*) to do was to click on the little entry in the sidebar and konqueror took care of the udisks mount, everything, including navigating me right to it. That, with the infinite window splitting, seamless drag-drop into sftp, etc, just made my life so easy.

In summary, Konqueror stands next to software like blender, firefox, thunderbird and a terminal emulator (I just now discovered konsole, and am blown away too!) as the standard for how to do the linux desktop. I miss my sidepane, and am willing to help code, debug, test, whatever is needed. I might end up trying to figure out how to compile the old konqueror in the meantime, to bring my productivity back to acceptable levels.

A huge thank you to everyone for giving us Konqueror. I hope I can be of some help.

(Where /do/ I get the old code from? Is it possible to compile the old Konqueror and run it side-by-side with the new one somehow?)
Comment 37 Raphael Rosch 2019-06-24 02:45:50 UTC
I ran git clone git://anongit.kde.org/konqueror
So I have the latest source, and saw there are some cmake files, and from memory I think the way to do it is "mkdir build; cd build; cmake ../src"

 Which gives me the error: 
   CMake Error at CMakeLists.txt:24 (ecm_qt_declare_logging_category): 
   Unknown CMake command "ecm_qt_declare_logging_category".

So I'm stuck.

I'm ready to rock, I just need some help getting all set up (and someone to tell me at least a couple of pointer on how to start hacking away at this). I've joined #kde-devel on freenode irc. (I figure this bug report is not the place for this sort of discussion.. if someone could please point me in the right direction for where the right place to discuss is, that would be much appreciated!)
Comment 38 Raphael Rosch 2019-07-01 03:32:27 UTC
For the curious landing here from google, I had to install (on fc27): 

dnf install qt5-qtwebengine-devel  extra-cmake-modules kf5-kdesu-devel  kf5-kwallet-devel  kf5-kparts-devel kf5-kcmutils-devel kf5-khtml-devel kf5-kdelibs4support-devel kf5-karchive-devel kf5-kcrash-devel

and all the dependencies those pulled in. I can successfully compile (and run the result) now, and am about to start hacking away.

I promise that's the last off-topic reply (I couldn't edit my previous ones).
Comment 39 Raphael Rosch 2019-08-10 21:14:04 UTC
Hi all, I have been talking to Stefano Crocco and David Faure, while I worked on coding this feature. It is now working, and the code will be cleaned up, and submitted for review in the next few days/weeks. Stay tuned.
Comment 40 Drazen Tomic 2019-08-12 12:46:44 UTC
(In reply to Raphael Rosch from comment #39)
> Hi all, I have been talking to Stefano Crocco and David Faure, while I
> worked on coding this feature. It is now working, and the code will be
> cleaned up, and submitted for review in the next few days/weeks. Stay tuned.

Great news !!!!
Thank you so very much :)
Comment 41 DePitte 2019-11-22 18:34:07 UTC
Hello,
I tried to test the new changes with the sidebar and downloaded today the source from GitHub, compiled and installed it. But I can't find any sidebar or a way to activate it.
Or are the changes not yet in the official code?
Thanks a lot
DePitte
Comment 42 Raphael Rosch 2019-11-22 21:26:58 UTC
Hi DePitte,

the code is still going through the review and modification process, and there are still a couple of things that need to be fixed before it makes it into master, but for the time being, you can try the branch (which is still missing some of my latest changes) at: 

https://github.com/insaner/konqueror/tree/konqsidebar_tree_module

(if I'm not mistaken, a simple "git checkout konqsidebar_tree_module" should do the trick if you already have the github repo loaded -- this would for sure be the easiest way to get the next set of changes of course)

and of course, if you have any feedback or run into any issues do let me know!


Of note, in sidebar/tree_module/tree_module.h

https://github.com/insaner/konqueror/blob/konqsidebar_tree_module/sidebar/tree_module/tree_module.h

line 34, you can select whether to use the QDirModel (with root node for "/") option or the KDirModel option (which will soon have that root node as well. David Faure is implementing it in KIO, and once done it will become the only option and the QDirModel code will likely be removed before release).


Once compiled, installed, and running, you activate the sidebar by simply pressing F9.
Comment 43 DePitte 2019-11-23 18:59:48 UTC
Hello Raphael, 

thanks for your quick answer.
I'm not experienced with git & Co, but I tried my best.

I cloned https://github.com/insaner/konqueror/ and compiled it. But it stopped on
Linking CXX shared library libkwebenginepart.so (see below)

I've no idea what the error means (undefined reference to `WebEnginePartHtmlEmbedder::staticMetaObject'
collect2: error: ld returned 1 exit status)

make output:
[ 40%] Linking CXX shared library libkwebenginepart.so
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/kwebenginepartlib.dir/webenginepartkiohandler.cpp.o: in function `WebEnginePartKIOHandler::processSlaveOutput()':
webenginepartkiohandler.cpp:(.text+0x619): undefined reference to `WebEnginePartHtmlEmbedder::startEmbedding(QByteArray const&, QString const&)'
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/kwebenginepartlib.dir/webenginepartkiohandler.cpp.o: in function `WebEnginePartKIOHandler::htmlEmbedder()':
webenginepartkiohandler.cpp:(.text+0x7ba): undefined reference to `WebEnginePartHtmlEmbedder::WebEnginePartHtmlEmbedder(QObject*)'
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: webenginepartkiohandler.cpp:(.text+0x7d5): undefined reference to `WebEnginePartHtmlEmbedder::finished(QString const&)'
/usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: CMakeFiles/kwebenginepartlib.dir/webenginepartkiohandler.cpp.o: in function `QMetaObject::Connection QObject::connect<void (WebEnginePartHtmlEmbedder::*)(QString const&), void (WebEnginePartKIOHandler::*)(QString const&)>(QtPrivate::FunctionPointer<void (WebEnginePartHtmlEmbedder::*)(QString const&)>::Object const*, void (WebEnginePartHtmlEmbedder::*)(QString const&), QtPrivate::FunctionPointer<void (WebEnginePartKIOHandler::*)(QString const&)>::Object const*, void (WebEnginePartKIOHandler::*)(QString const&), Qt::ConnectionType)':
webenginepartkiohandler.cpp:(.text._ZN7QObject7connectIM25WebEnginePartHtmlEmbedderFvRK7QStringEM23WebEnginePartKIOHandlerFvS4_EEEN11QMetaObject10ConnectionEPKN9QtPrivate15FunctionPointerIT_E6ObjectESE_PKNSD_IT0_E6ObjectESJ_N2Qt14ConnectionTypeE[_ZN7QObject7connectIM25WebEnginePartHtmlEmbedderFvRK7QStringEM23WebEnginePartKIOHandlerFvS4_EEEN11QMetaObject10ConnectionEPKN9QtPrivate15FunctionPointerIT_E6ObjectESE_PKNSD_IT0_E6ObjectESJ_N2Qt14ConnectionTypeE]+0x78): undefined reference to `WebEnginePartHtmlEmbedder::staticMetaObject'
collect2: error: ld returned 1 exit status
make[2]: *** [webenginepart/src/CMakeFiles/kwebenginepartlib.dir/build.make:541: webenginepart/src/libkwebenginepart.so] error 1
make[1]: *** [CMakeFiles/Makefile2:1320: webenginepart/src/CMakeFiles/kwebenginepartlib.dir/all] error 2
make: *** [Makefile:141: all] error 2
Comment 44 Raphael Rosch 2019-12-26 23:39:36 UTC
Newest set of changes is now up, waiting for review.

https://github.com/insaner/konqueror/tree/konqsidebar_tree_module

I added a couple of small features. The "bookmarks:" button doesn't work yet. But I don't know if that's something to be fixed on my side of the code.

DePitte, I'm not sure what could be causing your problem, my only suggestion at this point would be to try to pull the new changes (if you still have the git repo up) and try again ("git pull"... and make sure that you checked out the right branch: "git checkout konqsidebar_tree_module"). If that doesn't work, my first suspicion is that you might be missing some of the -dev or -devel files. I'm not sure how SuSE does it.
Comment 45 DePitte 2020-01-05 10:30:22 UTC
(In reply to Raphael Rosch from comment #44)
Hello Raphael,

sorry for the delay, took some time...

I managed now to compile and install the source code from konqsidebar_tree_module.

I can start Konqueror, but when I activated the navigation bar (checkbox 'Show Navigationsbereich F9'), I got the error:
>>>
"There was an error loading the module Navigationsbereich. The diagnostics is: The shared library was not found."
<<<
konsole says: org.kde.kcoreaddons: Error loading plugin "konq_sidebar" "The shared library was not found." 
Plugin search paths are ("/usr/lib64/qt5/plugins", "/usr/local/bin") 
The environment variable QT_PLUGIN_PATH might be not correctly set
org.kde.konqueror: no part could be loaded

Suppose my KDE configuration is incorrect (use of German wording for navigation bar as 'Navigationsbereich' is also strange), but I have installed regular Plasma5 konqueror (5.0.97), KDE4 konqueror (4.14.38) and now the version from  konqsidebar_tree_module in parallel.

I solved it by copying the plugins to /usr/local/bin and now I've the navigation bar!

I can see (and use, beside bookmarks as you said) the buttons bookmarks, history, places, HOME, SYSTEM (ROOT), remote/network, services and settings (can't see the latter in KDE4).
It's possible to use the options 'Multiple Views' and 'Show Tabs Right/Left' in navigation bar and to show and use the settings button for navigation bar.
The only thing which don't work is the 'Add New' functionality in the settings button, which includes the menu option 'Rollback to System Default', but not the possibility to add e.g. 'Web Sidebar Module', 'Folder', 'History Sidebar Module' or 'Places Sidebar Module'.

So, this looks SUPERB, thank you!!!

Will use now version from konqsidebar_tree_module and make further testing.
Comment 46 DePitte 2020-01-06 21:28:29 UTC
Hello Raphael,

what I found out by further testing:
(all of minor importance for a release, for some 'problems' workarounds are available, two improvement suggestions see below)

1. a) Konqueror konqsidebar_tree_module version doesn't remember the activation of the navigation bar on the next start. That's due to the not longer existing 'profilemagement' in Plasma5. Calling /usr/bin/konqueror (KDE4) without anything, the navigation bar is not activated, calling with --profile filemanagement, --open-session <your_session> or with a file related URL it is. (KDE4 profile 'filemanagement' and session contain 'Container0', which is the navigation bar)
For konqsidebar_tree_module version (Plasma5), it's possible to use the 'sessionmanagement' and call it by konqueror --open-session <your_session>. To prevent to have more than one window on start, it's necessary to store the session with the option 'Open tabs inside current window', which is Plasma5 standard I suppose.
b) Konqueror remembers the last used tree area for next start in KDE4 and Plasma5 (~config/konqsidebartngrc OpenViews=<tree_area> e.g. 'home.desktop').

2. Using the tree area button 'Home Folder' and 'Root Folder' is slightly different:
KDE4:
a) Using 'Home Folder', the tree shows only the $HOME, using 'Root Folder', the tree shows the full / (root) tree. Both have a 'root node' on top ('Home Folder' and 'Root Folder').
More precise: The configured URL from the tree area button is shown recursively from top.
b) 'highlighted' folders in tree area and content of active tab/view:
- on Konqueror start: no folder is highlighted
More precise: There is no 'stored' highlighted folder from start, neither without or with a profile or session. (there are stored URL resp. '...Buffer=' entries in the session, but they are not called like in Plasma5, see below)
- choosing another folder in tab/view or tree area: folder is highlighted (unless it's not available in tree area) and content of tab/view changes
- switching between tabs/views or tree areas: folder in tree area is not changed by tab/view, content of tab/view is not changed by tree area
More precise: A tree area is not 'linked' directly with a tab/view, no immediate changes.
Plasma5:
a) In the konqsidebar_tree_module version (Plasma5), a tree (for file views) shows always the full root tree. There is no 'root node' on top.
Improvement: For clearness it would be better to reduce the shown tree by the configured URL, as it is in KDE4. A top node is quite handy to jump on the top.
b) 'highlighted' folders in tree area and content of active tab/view:
- on Konqueror start: highlighted folder is the folder from first tab (F9 to open navigation bar) or active tab from stored session (opened navigation bar is restored). (in some tree areas this don't work, e.g. in 'Services' but also not in 'Home Folder'!)
More precise: The highlighted folder is taken either from $HOME/.config/konquerorrc StartURL= or from the stored session ('...Buffer=' from active tab or view in a container)
Improvement: 'Home Folder' should react like 'Root Folder' reactivating the last used folder and not the folder from configurated URL. (I've seen on changing URL of this Button, a configuration is stored in ~.local/share/konqsidebartng/entries/ with URL[$e]=file:$HOME/<my_change>, maybe the variable $HOME somewhere is a problem!?)
- choosing another folder in a tab/view or tree area: same as in KDE4
- switching between tabs/views or tree areas: folder in tree area is changed by tab/view (unless it's not available in tree area), content of tab/view is changed by tree area
More precise: A tree area is 'linked' directly with a tab/view, immediate changes.

3. As I said in previous comment, it's not possible to add e.g. a new Button 'Folder'. But it's possible to change the settings (Name, URL, Icon) for a tree area button. 

And nice to know:
The settings for the start behaviour of Konqueror in Plasma5 are a little bit tricky:
In the menu 'Configure Konqueror' there is:
a) 'When Konqueror starts:' with drop-down menu and an input field beside it
b) The input field 'Home Page'
b) influences the Button 'Home Folder' in Konqueror (switching between the field and $HOME)
a) influences the start page of Konqueror and depends on the drop down:
- Show Introduction Page = fixed about:konqueror
- Show My start page = variable
- Show Blank Page = fixed about:blank
- Show My Bookmarks = fixed bookmarks:
Both input fields a) and b) don't work with a simple path (e.g. /home/<your_home>), but only with the prefix file:///... 
On using the Button 'Home Folder' or to start Konqueror without URL or session, you will get the error "Unsupported Protocol - The protocol <strong></strong> is not supported by the KDE programs currently installed on this computer. Possible Causes: The requested protocol may not be supported."
Comment 47 Raphael Rosch 2020-01-07 04:34:07 UTC
That's great news! Thanks for the report!

Argh, you're right, I forgot to mention that konqueror needs to be installed from the local directory you compiled in order to pick up the new files.

My current workflow is:

cd /path/to/konq-git

# only run these lines for cmake once, to set it all up:
mkdir build
cd build
cmake -DCMAKE_INSTALL_PREFIX=/opt/konq-sidebar ..

# then to compile:
cd /path/to/konq-git/build
make && make install

# and to run the new konq:
cd /path/to/konq-git/build
. prefix.sh 
/opt/konq-sidebar/bin/konqueror /

Note the space between the dot and prefix.sh, you are sourcing the file (in bash). Also, if you run make with -j, you can compile much faster, I have an 8-core cpu, so I run it as: "make -j8".


Do let me know if you have any feedback. I'm still ironing out a couple more bugs to do with sessions and the like, which are a little annoying (when restoring a session, the location in the active view gets overwritten with one of the button urls from the sidebar). David Faure also has a fix to KF5 and Qt5 which I need to test that will fix a crash in closing a view, and add the root node to the tree in the sidebar.
Comment 48 Raphael Rosch 2020-01-07 04:41:59 UTC
Thank you for the second post too, I just now saw it and will be looking into all the points you raised.
Comment 49 Raphael Rosch 2020-03-30 23:26:16 UTC
New branch pushed to github.

https://github.com/insaner/konqueror/tree/konqsidebar_tree_module_qdirmodel

This will be the last version that includes the QDirModel code (already enabled by default) for those wanting a root node but lacking the most recent KDirModel which has the root node (just recently finished by David Faure).

The next version will be pushed to:

https://github.com/insaner/konqueror/tree/konqsidebar_tree_module

and will include a great many fixes and improvements and features (as with the QDirModel version). It will still work with old KDirModel releases, but obviously will be lacking that root node. Enabling KDirModel code in sidebar/tree_module/tree_module.h:35 will give you a preview of those if you use the QDirModel branch.

Stay tuned. I look forward to any feedback. I will not be providing bugfixes related to QDirModel problems, but feel free to fork and work on it yourself if you feel so inclined.
Comment 50 Raphael Rosch 2020-04-02 22:09:04 UTC
Hot and fresh, right out of the oven:

https://github.com/insaner/konqueror/tree/konqsidebar_tree_module

Please test. Some features will require patching Qt and KF5, or using git latest versions of each.
Comment 51 DePitte 2020-04-03 11:28:44 UTC
(In reply to Raphael Rosch from comment #50)
> Hot and fresh, right out of the oven:
> 
> https://github.com/insaner/konqueror/tree/konqsidebar_tree_module
> 
> Please test. Some features will require patching Qt and KF5, or using git
> latest versions of each.

Hello Raphael,

I downloaded the source, but when I try make, I get the errors
.../konqueror-konqsidebar_tree_module/sidebar/tree_module/tree_module.cpp:67:16: error: ‘class KDirModel’ has no member named ‘openUrl’
         model->openUrl(m_initURL, KDirModel::ShowRoot);
.../konqueror-konqsidebar_tree_module/sidebar/tree_module/tree_module.cpp:67:46: error: ‘ShowRoot’ is not a member of ‘KDirModel’
         model->openUrl(m_initURL, KDirModel::ShowRoot);

You said 'patching Qt and KF5' and I've seen KDirModel is in package kio-devel and kdelibs4support-devel (openSUSE), but how to 'patch' them?
I'll try my best, but I'm not experienced enough to solve this on my own ;-)
Comment 52 Raphael Rosch 2020-04-03 21:29:22 UTC
Hi DePitte, you have a couple of options.

 One (and the simplest one) is to edit sidebar/tree_module/tree_module.h:41 to comment out that line. The result will be that you don't have the root node, but it should compile. (What version of KF5 are you running? KDirModel should have openUrl no matter what, not sure why you are getting that error).

The other option is to patch your KF5-KIO with https://phabricator.kde.org/D25315. I'm using Fedora 30's KF5 version 5.64. Not sure how to do it in SuSE, but I think building an rpm is pretty much the same as in Fedora, right? (Basically you install the src rpm --as a regular user-- for the version you have, then edit the .spec file to include the two lines to patch the source, and a line to increase the revision of the package, to avoid file conflicts. Drop the patch in ~/rpmbuild/SOURCES, and run rpmbuild with the appropriate options. Then you install the new rpms and rebuild konq. Let me know if you need help with that. Feel free to email me directly, so we don't fill up everyone else's mailboxes with this.)

You don't really need to patch Qt to check out the new code, but there are some bugs that have since been fixed that improve stability and usability (at least for me).
Comment 53 davejplater@gmail.com 2020-04-04 08:31:59 UTC
/insaner/konqueror master can't find khtml for some reason but one commit back:
919437c532a7ed79f85427356110b158a58b8b85 has built successfully using a barely modified konqueror.spec from openSUSE:Tumbleweed/konqueror. I still have to add all the sidebar parts to the package and hopefully it works.

See https://build.opensuse.org/package/show/home:plater/konqueror
If it works I'll submit it to KDE:Extra
Comment 54 davejplater@gmail.com 2020-04-04 08:36:01 UTC
Got it, in master 430c4c9f411cd1c6da436745512974c65bdf686e we have:
    Don't find KHTML
    
    Summary: It isn't linked any more
    
    Reviewers: #konqueror, dfaure, vkrause
    
    Reviewed By: #konqueror, dfaure, vkrause
    
    Subscribers: vkrause
    
    Maniphest Tasks: T11543
    
    Differential Revision: https://phabricator.kde.org/D26471
Comment 55 davejplater@gmail.com 2020-04-04 13:34:49 UTC
I've built it in openSUSE's obs and installed it on my Leap:15.1 box happy to say it works fine apart from not having KDirModel yet.
Comment 56 Raphael Rosch 2020-05-11 20:02:04 UTC
Some good news in the midst of all this craziness: Kong sidebar code has landed!! It should soon be available in all distributions that carry konqueror. For now, of course, it is available in git.

Of note, given all the many other corollary fixes and code changes (to KF5 as well as Qt), you will be able to create your own .desktop files for buttons in the sidebar where you can specify the root node (with many thanks to David Faure for that fix!)! Just follow the example set for the "home" sidebar button.

You can create a button for any url that konq can handle (like the "fonts:/", "remote:/", "applications:/", and "settings:/", for which I already included buttons). I also created some skeleton code (cf the "bookmarks:/" module) that can be used for more complex buttons in the future as well. I'm sure someone can do some fun and interesting things with that.
Comment 57 hyiltiz 2020-06-06 22:11:45 UTC
In Debian Testing, 64bfeab built successfully with the following steps:
1. apt build-dep konqueror
2. add unstable to /etc/apt/sources.list and apt update
3. apt install libkf5itemmodels-dev/unstable
4. build using cmake
5. remove unstable from /etc/apt/sources.list and apt update
6. remove build dependencies

Sidebar works as expected (shown once F9 is pressed). However, it would be better if an option in the menubar is also shown in addition to the F9 activation. For example, click View / Panel / Places (doesn't exist yet) to activate.

Thanks everyone who worked so much on getting this support back!!!
Comment 58 Raphael Rosch 2020-07-09 08:18:08 UTC
@hyiltiz

> it would be better if an option in the menubar is also shown in addition to the F9 activation.

You have two easy options:

1 - Go to: Settings > Show sidebar

2 - Right click on the top bar, enable "Extra toolbar" and one of the buttons is the "sidebar" toggle, if that is not there you can add it by right clicking on the extra toolbar, and going to "Configure toolbars" and then adding the action "Show Sidebar" to the "Current actions" list by searching for it in the "Available actions" (in "Extra Toolbar <Konqueror>") and then selecting it and clicking the right arrow button (which should become highlighted after you select it).
Comment 59 DePitte 2020-10-24 20:28:11 UTC
@Raphael Rosch, @davejplater@gmail.com & @David Faure

sorry for the long absence, was busy with other items

I finally managed to patch my KIO (version 5.55 from openSUSE 15.1) and compiled https://github.com/insaner/konqueror/tree/konqsidebar_tree_module again.

for this:
- I added in ~/sidebar/web_module/CMakeLists.txt 'find_package(KF5KHtml NO_MODULE)', solved for me the KHTML problem
- I changed some already changed or missing lines in patch D25315.diff and changed in patchlines for kdirmodel.cpp 'qCDebug(category)' to 'qCDebug(KIO_WIDGETS)'
updated 2nd Konqueror is now available for me via /opt/konqueror with sidebar and root node!

Additionaly, I got source from https://download.opensuse.org/repositories/home:/plater/Leap_15.2/src/ and compiled & installed successfully new konqueror RPMs with konqueror-plugins-sidebar :-)

Thanks a lot for your very appreciated work! I'm looking forward for future openSUSE updates or upgrades including the sidebar.
Comment 60 Raphael Rosch 2020-10-25 00:16:58 UTC
That's great to hear, DePitte! You should know that many more fixes and feature additions have been added to the sidebar code and related packages. You might want to get the most recent KF5 (I'm running 5.73 here) and the konqueror git code from

 https://invent.kde.org/network/konqueror/

The one at https://github.com/insaner/konqueror/tree/konqsidebar_tree_module is now quite outdated.
Comment 61 DePitte 2020-10-27 17:57:22 UTC
Hi Raphael,

thanks for your answer.
I run openSUSE 15.1 ('old') with KF5 version 5.55 and QT version 5.9.7 (instead of 5.71.0 and 5.12 in CMakeList.txt from https://invent.kde.org/network/konqueror/).
I've no idea to change to the higher versions aside from using a different RPM repository and installing new versions from there.
But this would be quite an effort and I fear an unstable system.
Or is there another way to do this?

Cheers DePitte