Bug 373767 - Changing global colourscheme leaves "Colour themes" menu in wrong state
Summary: Changing global colourscheme leaves "Colour themes" menu in wrong state
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-kconfigwidgets
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.29.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
: 404554 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-17 14:28 UTC by Francis Herne
Modified: 2022-01-13 04:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francis Herne 2016-12-17 14:28:50 UTC
Using current git 2c04b1a

KDevelop follows changes to the global colour scheme, even when a theme has been explicitly selected in the new Colour Themes menu.

The menu radiobuttons continue to indicate the last theme chosen from the menu, although the new global scheme is now being used.

KDevelop should either not follow global scheme changes when a theme is chosen internally, or the menu state should be updated when doing so.
Comment 1 Francis Herne 2017-02-16 22:49:34 UTC
This menu is created wholesale by KColorSchemeManager, moving.
Comment 2 Ahmad Samir 2019-08-29 21:57:03 UTC
KColorSchemeManager creates the menu, and has a slot to activate a kcolorscheme, that's about it. The application using kcolorschememanager is responsible for saving the user color scheme choice, or treating it as transient.

IIUC, the problem here isn't with KColorSchemeManager, but that application using it, is still affected by the system-wide color scheme change, and it only affects  a running instance of the app, for example if you restart the application in question the color scheme chosen in kcolorschememanager will be applied (if the application saved and restored the user's choice) regardless of the system-wide one.

Changing the color scheme via the colors kcm causes kstyle[1] to apply the new scheme[1]; the latter has an event filter; maybe apps can reimplement that event filter and reapply the scheme that was activated via kcolorscheme manager or just bypass the QEvent::PaletteChanged event.

I think, ultimately the fix will have to be in the application not in kcolorschememanager.

https://cgit.kde.org/frameworkintegration.git/tree/src/kstyle/kstyle.cpp#n95
Comment 3 Nate Graham 2021-12-14 20:38:14 UTC
Cannot reproduce with Frameworks 5.89 anymore. Can you?
Comment 4 Nate Graham 2021-12-14 20:39:05 UTC
*** Bug 404554 has been marked as a duplicate of this bug. ***
Comment 5 Bug Janitor Service 2021-12-29 04:34:50 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2022-01-13 04:37:10 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!