Bug 373676 - Bent lines showing up on OSX.
Summary: Bent lines showing up on OSX.
Status: RESOLVED DUPLICATE of bug 385276
Alias: None
Product: krita
Classification: Applications
Component: Tablets (tablet issues are only very rarely bugs in Krita!) (show other bugs)
Version: 3.1.1
Platform: macOS (DMG) macOS
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 374989 377188 382555 384052 384060 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-15 10:05 UTC by Cerys
Modified: 2018-02-02 10:54 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
i have attached a screenshot so you can see properly what i mean with bent lines. (290.27 KB, image/png)
2016-12-15 10:05 UTC, Cerys
Details
3.2.0 opengl test (367.20 KB, image/png)
2017-09-27 13:00 UTC, jdreske
Details
intel vs. amd doodle performance test (314.03 KB, image/png)
2017-09-28 08:26 UTC, jdreske
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cerys 2016-12-15 10:05:57 UTC
Created attachment 102792 [details]
i have attached a screenshot so you can see properly what i mean with bent lines.

When i use my wacom CTH-490 comic tablet, or any other tablet for that matter, i get bent lines when i use the brush. However, when i use the mouse that is not the case. I have talked to very helpful people on the krita forum, yet we have not found a solution. I will attach a screenshot so you can properly see what i mean.
Comment 1 Halla Rempt 2016-12-15 10:08:38 UTC
I can confirm the issue. It seems OSX specific. The Qt::AA_CompressHighFrequencyEvents flag only is relevant on X11, it's false by default on OSX and Windows according to http://doc.qt.io/qt-5/qt.html. However, it's pretty clear that some form of event compression is going on. I suspect we'll have to patch Qt again or fork Qt's OSX tablet support...
Comment 2 wolthera 2017-01-22 19:18:41 UTC
*** Bug 374989 has been marked as a duplicate of this bug. ***
Comment 3 Halla Rempt 2017-03-04 09:34:18 UTC
*** Bug 377188 has been marked as a duplicate of this bug. ***
Comment 4 Halla Rempt 2017-07-27 13:42:22 UTC
*** Bug 382555 has been marked as a duplicate of this bug. ***
Comment 5 Halla Rempt 2017-08-26 14:48:36 UTC
*** Bug 384052 has been marked as a duplicate of this bug. ***
Comment 6 Alvin Wong 2017-09-20 03:04:28 UTC
*** Bug 384060 has been marked as a duplicate of this bug. ***
Comment 7 Halla Rempt 2017-09-20 09:20:55 UTC
Git commit f386cdb7686c50ddc0a0842d2921aa3eff87b98e by Boudewijn Rempt.
Committed on 20/09/2017 at 09:19.
Pushed by rempt into branch 'krita/3.3'.

Improve stylus precision on OSX

Patch by Bernhard Liebl
Differential Revision: https://phabricator.kde.org/D7880

M  +8    -0    libs/ui/CMakeLists.txt
M  +9    -1    libs/ui/KisApplication.cpp
A  +22   -0    libs/ui/osx.h     [License: LGPL (v2+)]
A  +32   -0    libs/ui/osx.mm

https://commits.kde.org/krita/f386cdb7686c50ddc0a0842d2921aa3eff87b98e
Comment 8 Halla Rempt 2017-09-20 09:24:53 UTC
Git commit d4bca56cde88f9be851d151aec8091a7a252ad46 by Boudewijn Rempt.
Committed on 20/09/2017 at 09:24.
Pushed by rempt into branch 'master'.

Improve stylus precision on OSX

Patch by Bernhard Liebl
Differential Revision: https://phabricator.kde.org/D7880

M  +8    -0    libs/ui/CMakeLists.txt
M  +9    -1    libs/ui/KisApplication.cpp
A  +22   -0    libs/ui/osx.h     [License: LGPL (v2+)]
A  +32   -0    libs/ui/osx.mm

https://commits.kde.org/krita/d4bca56cde88f9be851d151aec8091a7a252ad46
Comment 9 Alvin Wong 2017-09-21 16:41:24 UTC
This should be improved in 3.3.0-rc.1: https://krita.org/en/item/krita-3-3-0-first-release-candidate/

Please check.
Comment 10 jdreske 2017-09-27 13:00:39 UTC
Created attachment 108056 [details]
3.2.0 opengl test
Comment 11 Alvin Wong 2017-09-27 13:04:15 UTC
(In reply to jdreske from comment #10)
> Created attachment 108056 [details]
> 3.2.0 opengl test

Any testing should be done with 3.3.0-rc.1 or a later version instead, it is meaningless to test with 3.2.0 anymore.
Comment 12 jdreske 2017-09-27 13:07:40 UTC
I found in Krita 3.2.0 turning off OpenGL helps with the jagged lines. 
But this only helps when I explicitly turn off OpenGl. Restarting Krita with OpenGl unchecked results in jagged lines again. I have to turn on and off OpenGl Acceleration to be able to draw smooth curves.

In 3.3.0 rc 1 the OpenGl options are greyed out. It is no more possible to turn on and off OpenGl and thus drawn lines look as jagged as with 3.2.0. started with OpenGl unchecked...

( screenshot above)
Comment 13 Alvin Wong 2017-09-28 07:04:55 UTC
(In reply to jdreske from comment #12)
> I found in Krita 3.2.0 turning off OpenGL helps with the jagged lines. 
> But this only helps when I explicitly turn off OpenGl. Restarting Krita with
> OpenGl unchecked results in jagged lines again. I have to turn on and off
> OpenGl Acceleration to be able to draw smooth curves.
> 
> In 3.3.0 rc 1 the OpenGl options are greyed out. It is no more possible to
> turn on and off OpenGl and thus drawn lines look as jagged as with 3.2.0.
> started with OpenGl unchecked...
> 
> ( screenshot above)

From what I understand, in Krita 3.3 OpenGL is intentionally disabled for AMD graphics due to bug 369014. I have been told that you should be able to force OS X to use the Intel integrated graphics to run Krita, can you test that?

I have no clue why toggling OpenGL on and then off in 3.2 would cause a change in the input behaviour.
Comment 14 jdreske 2017-09-28 08:24:19 UTC
I just checked what happens, using gfxCardStatus to force using the integrated intel gpu.
the Acceleration checkbox is not greyed out anymore. 
on start it was checked (openGl on), performance was very bad. 
unchecked it - performance is not good, but usable.

By the way I tried to save my test as a .png and Krita got stuck like in previous versions. Creating a new document by keyboard shortcut (cmd-n) helps and the menus get populated again. This means AMD is not responsible for this bug, since krita used the integrated intel gpu.

(For 3.2.0 it feels like OpenGL is on by default and krita does not check or apply this option on starting up. I think it is the same using the intel gpu, but less obvious, because the integrated gpu is slower than the discreet AMD gpu)
Comment 15 jdreske 2017-09-28 08:26:51 UTC
Created attachment 108072 [details]
intel vs. amd doodle performance test
Comment 16 Halla Rempt 2018-02-02 10:54:03 UTC

*** This bug has been marked as a duplicate of bug 385276 ***