Bug 370428 - Tool-Tip Text is Unreadable In File and digiKam Properties
Summary: Tool-Tip Text is Unreadable In File and digiKam Properties
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Themes (show other bugs)
Version: 5.9.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-10 20:43 UTC by hardy.public
Modified: 2018-09-30 11:29 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments
Image of problem. (51.89 KB, image/png)
2016-10-10 20:45 UTC, hardy.public
Details
screenshot crop of file properties hover window (47.80 KB, image/png)
2017-12-03 09:44 UTC, Peter Marquardt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hardy.public 2016-10-10 20:43:31 UTC
Wherever File and/or digiKam properties are displayed, the font is white on a light yellow background and is therefore almost impossible to read. Changing the font in setup has no effect.

Reproducible: Always

Steps to Reproduce:
1. Hover the mouse over a thumbnail.
2.
3.

Actual Results:  
See attached picture.

Expected Results:  
The font should be at least black.
Comment 1 hardy.public 2016-10-10 20:45:32 UTC
Created attachment 101516 [details]
Image of problem.
Comment 2 caulier.gilles 2016-11-19 17:21:16 UTC
Which color scheme theme do you use in Settings menu ?

Gilles Caulier
Comment 3 hardy.public 2016-11-19 18:26:17 UTC
Thanks for the hint. I was only using Default but I just tried all the themes. Most are unreadable, some are partially readable, and 3 are OK. So for now, I'll just use one I can read.

Not Readable. White font on light background.
  Default
  Black Body
  DarkRoom
  High Key
  White Balance

Difficult To Read. Light gray font on light background.
  SunsetColor
  GrayCard

Readable. Dark gray font on light background.
  LowKey
  ShadeOfGray
  ColorContrast
Comment 4 Maik Qualmann 2017-07-15 16:30:24 UTC
*** Bug 382367 has been marked as a duplicate of this bug. ***
Comment 5 Peter Marquardt 2017-12-03 09:44:35 UTC
Created attachment 109185 [details]
screenshot crop of file properties hover window

file properties window with default theme with unreadable colors.
Comment 6 Peter Marquardt 2017-12-03 09:49:08 UTC
This is still an issue in 5.8.0 build http://commits.kde.org/digikam/7f1c8a4ba87362587d825dd8a727eba7fe281e85
Comment 7 hardy.public 2017-12-03 10:47:15 UTC
(In reply to Peter Marquardt from comment #6)
> This is still an issue in 5.8.0 build
> http://commits.kde.org/digikam/7f1c8a4ba87362587d825dd8a727eba7fe281e85

Peter, do you use the Windows version? I get the feeling this is only a problem on Windows.

I also get the feeling this is not simple to resolve. Personally I would settle for an additional 'Windows' theme where a any workable combination, however ugly, could be found to allow tool-tip text and icons to be readable at the same time and forego any aesthetic beauty.
Comment 8 caulier.gilles 2017-12-03 10:58:39 UTC
yes exactly. This problem exist only with non X11 platform, as MacOS and Windows.

The color theme are constructed under under Linux with X11 composite. The port to other platform are just given for testing.

the color theme are text files description and can be adjusted easily. If you found the right values for Windows, we can customize the code to wrap themes accordingly with OS.

Note : The widget style as also a side effect on the color rendering. It's a big puzzle. This is why we only provide one widget style for MacOS and Windows. Under Linux all work as expected.

Note2 : The color theme engine come from KDE core with some improvements done in digiKam core. There are complex algorithms inside. The problem can be also in these implementations (as i'm sure that KDE dev has never tested these implementation outside Linux).

https://cgit.kde.org/digikam.git/tree/libs/widgets/mainview/schememanager.cpp


Gilles Caulier
Comment 9 hardy.public 2017-12-03 11:04:49 UTC
(In reply to caulier.gilles from comment #8)
> the color theme are text files description and can be adjusted easily. If
> you found the right values for Windows, we can customize the code to wrap
> themes accordingly with OS.

Thanks Gilles. If you tell me which text files to change I'm happy to experiment and propose some values.
Comment 10 Peter Marquardt 2017-12-03 11:13:37 UTC
(In reply to caulier.gilles from comment #8)
> yes exactly. This problem exist only with non X11 platform, as MacOS and
> Windows.

Sorry forgot to mention: Windows port.

> https://cgit.kde.org/digikam.git/tree/libs/widgets/mainview/schememanager.cpp

Thanks for he pointer, I'm setting up a configure-make-make-install session 8-)
Comment 11 Maik Qualmann 2017-12-03 11:20:23 UTC
For me it looks as if the background color of the tool tip is not changed at all. We have the same problem under Windows with the DWizardDlg (QWizard) tools. The theme color is not included here.

Maik
Comment 12 caulier.gilles 2017-12-03 11:29:17 UTC
The colors scheme files are defined here :

https://cgit.kde.org/digikam.git/tree/data/colorschemes

Under Windows, the files are copied as well on the install path (see data/digikam/ sub-dir), and can be easily customized with a text editor. You can create a new one, it will be automatically proposed in digiKam at next restart. The new created file must be stored at the same place than others one of course.

Note : The color scheme files are managed by the schememanager.cpp class in background to render color on GUI.

Gilles Caulier
Comment 13 Peter Marquardt 2017-12-03 11:38:58 UTC
(In reply to caulier.gilles from comment #12)

> Under Windows, the files are copied as well on the install path

Yep found them in C:\Program Files\digiKam\data\digikam\colorschemes

But these are the optional theme colors, not the default 8(

Is there a way to export the "Default" ? And make it load "default.colors" on startup when there is no user theme defined ?

Maybe something like "only use hardcoded defaults when there is no default.colors found" ?
Comment 14 Maik Qualmann 2017-12-03 12:13:43 UTC
Git commit f142f9fb87be3132ed7aea071e3a321c084ad302 by Maik Qualmann.
Committed on 03/12/2017 at 12:12.
Pushed by mqualmann into branch 'master'.

fix wrong colors in the tooltip under Windows
FIXED-IN: 5.8.0

M  +2    -1    NEWS
M  +0    -2    libs/widgets/itemview/ditemtooltip.cpp

https://commits.kde.org/digikam/f142f9fb87be3132ed7aea071e3a321c084ad302
Comment 15 hardy.public 2017-12-07 19:09:36 UTC
Yes, definitely fixed in 7-Dec build. Thanks guys!
Comment 16 Peter Marquardt 2018-09-30 08:20:07 UTC
Just installed 5.9.0 and the issue is back.
No need to take a screenshot, since it's exactly the same.
Comment 17 Maik Qualmann 2018-09-30 11:29:22 UTC
This problem is now fixed in digiKam-6.0.0 beta1.

https://files.kde.org/digikam/

If you want to test the beta, make a backup of the database if you want to go back.

Maik