Bug 369451 - brush angle tied to canvas rotation instead of being absolute
Summary: brush angle tied to canvas rotation instead of being absolute
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: 3.0.1
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-27 21:54 UTC by kaerhon
Modified: 2016-11-22 09:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kaerhon 2016-09-27 21:54:31 UTC
when used with "tilt direction" the brush angle is tied to the canvas view rotation. The brush angle is offset by the rotated canvas view, where in precedent krita versions it was absolute, and easy to predict

Reproducible: Always

Steps to Reproduce:
1.select a brush with a "tilt direction" "rotation" sensor
2.rotate your canvas with shift+middle button or numpad
3.see how the angle is dependent of the canvas view

Actual Results:  
the brush angle is offset by the canvas view angle

Expected Results:  
the brush angle should remain absolute, and tied only to the stylus tilt direction
Comment 1 animtim 2016-09-28 01:50:20 UTC
Actually it's even worse, like if the rotation of the brush depends on the canvas rotation but the brush angle is not directly the same as the canvas angle.
Comment 2 animtim 2016-09-28 01:52:31 UTC
Also there's a problem with the brush being mirrored with mirrored canvas. It might be related.

Also: all these issues happen if either tilt direction or tilt elevation is selected for rotation.
Comment 3 animtim 2016-09-28 02:48:36 UTC
The tilt rotation issue was already reported there:
https://bugs.kde.org/show_bug.cgi?id=366289
Comment 4 Halla Rempt 2016-10-07 09:58:46 UTC
Let's combine the two issues then

*** This bug has been marked as a duplicate of bug 366289 ***
Comment 5 Dmitry Kazakov 2016-11-22 08:47:32 UTC
Git commit 1b88a3d2886a4e82b14ea4ebd8884cfc797f9641 by Dmitry Kazakov.
Committed on 21/11/2016 at 10:41.
Pushed by dkazakov into branch 'krita/3.1'.

Fix Tilt-elevation to work with rotated/mirrored canvas

We should pass already normalized base angle values to the sensor
Related: bug 366289

M  +2    -2    plugins/paintops/libpaintop/kis_curve_option.cpp
M  +10   -3    plugins/paintops/libpaintop/kis_curve_option.h
M  +1    -1    plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
M  +6    -4    plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp

http://commits.kde.org/krita/1b88a3d2886a4e82b14ea4ebd8884cfc797f9641
Comment 6 Dmitry Kazakov 2016-11-22 09:16:30 UTC
Git commit ef4cec6f8f4626b7815c5ceaf1bb208c867ead93 by Dmitry Kazakov.
Committed on 22/11/2016 at 09:09.
Pushed by dkazakov into branch 'rempt/impex-refactoring'.

Fix Tilt-elevation to work with rotated/mirrored canvas

We should pass already normalized base angle values to the sensor
Related: bug 366289

M  +2    -2    plugins/paintops/libpaintop/kis_curve_option.cpp
M  +10   -3    plugins/paintops/libpaintop/kis_curve_option.h
M  +1    -1    plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
M  +6    -4    plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp

http://commits.kde.org/krita/ef4cec6f8f4626b7815c5ceaf1bb208c867ead93