Bug 366289 - When mirroring canvas (Mirror View) is ON - tilt direction for brush rotation works incorrectly
Summary: When mirroring canvas (Mirror View) is ON - tilt direction for brush rotation...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: 3.0.1 Alpha
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-30 22:58 UTC by SirPigeonz
Modified: 2016-11-22 09:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SirPigeonz 2016-07-30 22:58:06 UTC
krita-3.0.1-Alpha-4c91a18-x86_64.appimage (MD5: 772ca9e719cf00d4de49fe68c226c41f)

When Canvas is mirrored tablet tilt direction works incorrectly. Works correctly in 3.0.0

Reproducible: Always

Steps to Reproduce:
1. Turn ON Mirror View for canvas
2. Use brush with Rotation + Tilt Direction dynamic


Actual Results:  
Brush follows bad rotations different than in non mirrored canvas state.

Expected Results:  
Work the same as in non mirrored canvas state
Comment 1 Halla Rempt 2016-08-12 11:29:23 UTC
Hi Przemyslaw,

Thanks for your report. I can confirm that this is still an issue in the latest 3.0.1 alpha 2 build.
Comment 2 Halla Rempt 2016-10-07 09:58:46 UTC
*** Bug 369451 has been marked as a duplicate of this bug. ***
Comment 3 Halla Rempt 2016-10-07 09:59:08 UTC
See also https://bugs.kde.org/show_bug.cgi?id=369451

"when used with "tilt direction" the brush angle is tied to the canvas view rotation. The brush angle is offset by the rotated canvas view, where in precedent krita versions it was absolute, and easy to predict Reproducible: Always Steps to Reproduce: 1.select a brush with a "tilt direction" "rotation" sensor 2.rotate your canvas with shift+middle button or numpad 3.see how the angle is dependent of the canvas view Actual Results: the brush angle is offset by the canvas view angle Expected Results: the brush angle should remain absolute, and tied only to the stylus tilt direction"
Comment 4 Dmitry Kazakov 2016-11-22 08:47:32 UTC
Git commit 1b88a3d2886a4e82b14ea4ebd8884cfc797f9641 by Dmitry Kazakov.
Committed on 21/11/2016 at 10:41.
Pushed by dkazakov into branch 'krita/3.1'.

Fix Tilt-elevation to work with rotated/mirrored canvas

We should pass already normalized base angle values to the sensor
Related: bug 369451

M  +2    -2    plugins/paintops/libpaintop/kis_curve_option.cpp
M  +10   -3    plugins/paintops/libpaintop/kis_curve_option.h
M  +1    -1    plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
M  +6    -4    plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp

http://commits.kde.org/krita/1b88a3d2886a4e82b14ea4ebd8884cfc797f9641
Comment 5 Dmitry Kazakov 2016-11-22 09:16:30 UTC
Git commit ef4cec6f8f4626b7815c5ceaf1bb208c867ead93 by Dmitry Kazakov.
Committed on 22/11/2016 at 09:09.
Pushed by dkazakov into branch 'rempt/impex-refactoring'.

Fix Tilt-elevation to work with rotated/mirrored canvas

We should pass already normalized base angle values to the sensor
Related: bug 369451

M  +2    -2    plugins/paintops/libpaintop/kis_curve_option.cpp
M  +10   -3    plugins/paintops/libpaintop/kis_curve_option.h
M  +1    -1    plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp
M  +6    -4    plugins/paintops/libpaintop/kis_pressure_rotation_option.cpp

http://commits.kde.org/krita/ef4cec6f8f4626b7815c5ceaf1bb208c867ead93