Bug 364183 - Stabilizer's Finish line option is down
Summary: Stabilizer's Finish line option is down
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: 3.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2016-06-10 13:10 UTC by eliotJ
Modified: 2016-08-14 12:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description eliotJ 2016-06-10 13:10:54 UTC
It looks like it's broken-down after commited Stabilizer fix (https://bugs.kde.org/show_bug.cgi?id=362445). But I'm not sure...

It definitely works correctly in v2.9.10ae. I very like this 'Finish line' option and using it a lot...

Reproducible: Always
Comment 1 elkmug 2016-06-13 21:43:53 UTC
I can definitely confirm some very unusual behavior with Stabilizer smoothing on Win 7 sp1 64-bit. I believe it started with Krita 3.0 da5496d. This does not happen on Linux.

This is a bit long, but trying to describe a bug clearly can be surprisingly difficult sometimes.

1: Make sure Stabilizer smoothing is active. Turn off 'Delay', this can make what's happening a bit easier to see. 'Finish line' can either be on or off, it doesn't seem to matter.

2: Create a new document

The next steps assume you are using a mouse

3: Somewhere in the middle of the image click & hold the left mouse button, do not move the mouse while clicking & holding. 

4: The cursor will jump to the upper left corner, in other words image coordinate [0,0] & a line will be drawn from your click point to [0,0]. 

5: When you release the left mouse button, the cursor will jump back to the click point.

6: Move to a new position and this time after you click, hold, & the line is drawn to [0,0], start moving the mouse to draw a stroke. 

7: The cursor will jump back to where you are drawing, creating a line from [0,0] to the point where the cursor catches up with your brushstroke.

8: Release the mouse button & move a new position & do a click & hold again. The end of the just drawn brushstroke is now the point that the cursor jumps to.

While this is unwanted behavior for Stabilizer, I think the behavior itself, with some tweaking & options, might be a very useful addition to the Line tool.

Perhaps a 'Click Drawing' on/off switch could be added. With options to 'Draw to Specified Point' or 'Draw from Last Point to Current'

'Draw to Specified Point' would allow the user to set a coordinate for the 'draw to' point, via numeric entry or a UI widget on the canvas

'Draw from Last Point to Current' would in essence emulate Photoshop's shift-click functionality for drawing straight lines on the fly. This would be somewhat redundant given Krita's Polyline Tool, but the ability to do this on fly, via the 'v' key, without having to switch tools is very appealing. Plus no double-clicking or enter key required to finish drawing would streamline things even more.
Comment 2 eliotJ 2016-07-19 12:46:51 UTC
I mean I'm sure "Finish line" is broken down now... But I'm not 100% sure about if this is really by Stabilizer fix. Simply it looks like these Stabilizer fix destroyed "Finish line". I have noticed these stop of working ("Finish line") in build with Stabilizer fix, earlier it has worked ok.
Comment 3 Dmitry Kazakov 2016-07-20 07:43:39 UTC
Confirmed on a local build
Comment 4 Dmitry Kazakov 2016-08-12 13:33:14 UTC
Git commit 54098bcd976ee40eb8ea0dc9c2d234c86b30d1ad by Dmitry Kazakov.
Committed on 12/08/2016 at 13:29.
Pushed by dkazakov into branch 'master'.

Fix Stabilizer Finish Line feature broken by the stabilizer fix in 3.0
Fixes T3272

M  +13   -2    libs/ui/tool/kis_stabilized_events_sampler.cpp
M  +1    -0    libs/ui/tool/kis_stabilized_events_sampler.h
M  +4    -9    libs/ui/tool/kis_tool_freehand_helper.cpp

http://commits.kde.org/krita/54098bcd976ee40eb8ea0dc9c2d234c86b30d1ad
Comment 5 eliotJ 2016-08-14 12:04:48 UTC
Thank you so much, Dmitry :). I will wait for new win dev build. Then I will test fixed Finish line feature.